Re: Review Request 39306: AMBARI-13418. Stop-and-Start Upgrade: Upgrade START call cannot find upgrade pack to use (branch-2.1)

2015-10-14 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39306/#review102704 --- Ship it! Ship It! - Jayush Luniya On Oct. 14, 2015, 8:29 p.m.,

Re: Review Request 39306: AMBARI-13418. Stop-and-Start Upgrade: Upgrade START call cannot find upgrade pack to use (branch-2.1)

2015-10-14 Thread Alejandro Fernandez
> On Oct. 14, 2015, 8:38 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java, > > line 140 > > > > > > No need to test, or holdup

Re: Review Request 39306: AMBARI-13418. Stop-and-Start Upgrade: Upgrade START call cannot find upgrade pack to use (branch-2.1)

2015-10-14 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39306/#review102696 --- Ship it! ambari-server/src/main/java/org/apache/ambari/server/con

Re: Review Request 39306: AMBARI-13418. Stop-and-Start Upgrade: Upgrade START call cannot find upgrade pack to use (branch-2.1)

2015-10-14 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39306/ --- (Updated Oct. 14, 2015, 8:29 p.m.) Review request for Ambari, Dmytro Grinenko,

Re: Review Request 39306: AMBARI-13418. Stop-and-Start Upgrade: Upgrade START call cannot find upgrade pack to use

2015-10-14 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39306/ --- (Updated Oct. 14, 2015, 6:15 p.m.) Review request for Ambari, Dmytro Grinenko,

Re: Review Request 39306: AMBARI-13418. Stop-and-Start Upgrade: Upgrade START call cannot find upgrade pack to use

2015-10-14 Thread Alejandro Fernandez
> On Oct. 14, 2015, 5:33 a.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java, > > line 198 > > > > > > Is this only supported for unit tests? From the API we

Re: Review Request 39306: AMBARI-13418. Stop-and-Start Upgrade: Upgrade START call cannot find upgrade pack to use

2015-10-14 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39306/#review102673 --- ambari-server/src/main/java/org/apache/ambari/server/controller/in

Re: Review Request 39306: AMBARI-13418. Stop-and-Start Upgrade: Upgrade START call cannot find upgrade pack to use

2015-10-14 Thread Alejandro Fernandez
> On Oct. 14, 2015, 12:38 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java, > > line 225 > > > > > > Use StringUtils.isEmpty() here Will fix > On Oct. 14, 2

Re: Review Request 39306: AMBARI-13418. Stop-and-Start Upgrade: Upgrade START call cannot find upgrade pack to use

2015-10-14 Thread Alejandro Fernandez
> On Oct. 14, 2015, 3:01 a.m., Dmytro Grinenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java, > > line 203 > > > > > > Problably this required for unit-tests, but this also

Re: Review Request 39306: AMBARI-13418. Stop-and-Start Upgrade: Upgrade START call cannot find upgrade pack to use

2015-10-14 Thread Nate Cole
> On Oct. 14, 2015, 8:38 a.m., Nate Cole wrote: > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml, > > line 20 > > > > > > HDP-2.2.0 is too specific for this field. It feels like the co

Re: Review Request 39306: AMBARI-13418. Stop-and-Start Upgrade: Upgrade START call cannot find upgrade pack to use

2015-10-14 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39306/#review102618 --- ambari-server/src/main/java/org/apache/ambari/server/controller/in

Re: Review Request 39306: AMBARI-13418. Stop-and-Start Upgrade: Upgrade START call cannot find upgrade pack to use

2015-10-14 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39306/#review102610 --- ambari-server/src/main/java/org/apache/ambari/server/state/Upgrade

Re: Review Request 39306: AMBARI-13418. Stop-and-Start Upgrade: Upgrade START call cannot find upgrade pack to use

2015-10-13 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39306/#review102578 --- ambari-server/src/main/java/org/apache/ambari/server/controller/in

Re: Review Request 39306: AMBARI-13418. Stop-and-Start Upgrade: Upgrade START call cannot find upgrade pack to use

2015-10-13 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39306/#review102574 --- ambari-server/src/main/java/org/apache/ambari/server/state/Upgrade

Re: Review Request 39306: AMBARI-13418. Stop-and-Start Upgrade: Upgrade START call cannot find upgrade pack to use

2015-10-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39306/ --- (Updated Oct. 14, 2015, 2:42 a.m.) Review request for Ambari, Dmytro Grinenko,

Review Request 39306: AMBARI-13418. Stop-and-Start Upgrade: Upgrade START call cannot find upgrade pack to use

2015-10-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39306/ --- Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley,