Re: Review Request 40499: Create base infrastructure to allow for granular role based access control

2015-11-19 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40499/ --- (Updated Nov. 19, 2015, 9:44 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 40499: Create base infrastructure to allow for granular role based access control

2015-11-19 Thread Robert Levas
> On Nov. 19, 2015, 5:29 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java, > > line 32 > > > > > > Not critical - may be its OK that a

Re: Review Request 40499: Create base infrastructure to allow for granular role based access control

2015-11-19 Thread Robert Levas
> On Nov. 19, 2015, 5:29 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/internal/InternalAuthenticationToken.java, > > line 70 > > > > > > Is this a breakin

Re: Review Request 40499: Create base infrastructure to allow for granular role based access control

2015-11-19 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40499/#review107255 --- Ship it! My comments are benign - so code can be committed without

Re: Review Request 40499: Create base infrastructure to allow for granular role based access control

2015-11-19 Thread Sumit Mohanty
> On Nov. 19, 2015, 10:29 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AuthorizationException.java, > > line 32 > > > > > > Type - drop the "does" Typo i

Re: Review Request 40499: Create base infrastructure to allow for granular role based access control

2015-11-19 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40499/#review107252 --- ambari-server/src/main/java/org/apache/ambari/server/security/auth

Review Request 40499: Create base infrastructure to allow for granular role based access control

2015-11-19 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40499/ --- Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, Ro