Re: Review Request 40855: Exported blueprint does not contain "policymgr_external_url" property

2015-12-02 Thread Mahadev Konar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40855/#review108781 --- Ship it! Ship It! - Mahadev Konar On Dec. 2, 2015, 3:35 p.m., S

Re: Review Request 40855: Exported blueprint does not contain "policymgr_external_url" property

2015-12-02 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40855/ --- (Updated Dec. 2, 2015, 4:35 p.m.) Review request for Ambari, Dmitro Lisnichenko

Re: Review Request 40855: Exported blueprint does not contain "policymgr_external_url" property

2015-12-02 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40855/#review108641 --- Ship it! Patch looks fine, just a minor javadoc issue below. amb

Re: Review Request 40855: Exported blueprint does not contain "policymgr_external_url" property

2015-12-02 Thread Dmitro Lisnichenko
> On Dec. 2, 2015, 1:07 p.m., Dmitro Lisnichenko wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py, > > line 314 > > > > > > maybe strip().isempty() ? Thinking a bit more, we an

Re: Review Request 40855: Exported blueprint does not contain "policymgr_external_url" property

2015-12-02 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40855/#review108629 --- Ship it! ambari-server/src/main/resources/stacks/HDP/2.0.6/servic

Review Request 40855: Exported blueprint does not contain "policymgr_external_url" property

2015-12-01 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40855/ --- Review request for Ambari, Dmitro Lisnichenko and Robert Nettleton. Bugs: AMBAR