Re: svn commit: r393996 - /ant/core/trunk/src/main/org/apache/tools/ant/launch/Launcher.java

2006-04-14 Thread Kevin Jackson
ok, I think the consensus is that I shouldn't have committed this change ie -1 to this change from while -> for. I'll change it back to the while loop on Monday when I get to work. Thanks Kev - To unsubscribe, e-mail: [EMAIL PRO

DO NOT REPLY [Bug 39295] - white spaces in path

2006-04-14 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 39295] - white spaces in path

2006-04-14 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 39298] - %HOME% should be %HOMEPATH% in ant.bat on XP

2006-04-14 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 39300] - Classpath with '\' as last character breaks the Launcher when using ant.bat

2006-04-14 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: svn commit: r393996 - /ant/core/trunk/src/main/org/apache/tools/ant/launch/Launcher.java

2006-04-14 Thread Martijn Kruithof
Antoine Levy-Lambert wrote: I also think that the code was more readable before. The variable myTokenizer or tzr being a variable of a private function goes quickly out of scope anyway. Something like this would alleviate the remark of Martijn concerning where the incrementation takes place but

svn commit: r394115 - /ant/core/trunk/docs/manual/CoreTasks/unzip.html

2006-04-14 Thread mbenson
Author: mbenson Date: Fri Apr 14 08:04:54 2006 New Revision: 394115 URL: http://svn.apache.org/viewcvs?rev=394115&view=rev Log: Note is a file-only resource collection. Modified: ant/core/trunk/docs/manual/CoreTasks/unzip.html Modified: ant/core/trunk/docs/manual/CoreTasks/unzip.html URL:

Re: [VOTE] removal of the test task based upon the org.apache.testlet framework

2006-04-14 Thread Matt Benson
--- Antoine Levy-Lambert <[EMAIL PROTECTED]> wrote: > Hello, > > Do you want to remove from ant the usage of the > org.apache.testlet > framework : > > see this document : [1] describing the optional > task. > > [+1] Yes > > [ ] No > -Matt > I consider this a code change, requiring lazy >

Re: [VOTE] removal of Visual for Java based tasks

2006-04-14 Thread Matt Benson
--- Antoine Levy-Lambert <[EMAIL PROTECTED]> wrote: > Hello, > > Do you want to remove from ant the usage of Visual > Age for Java : > > see this document : [1] > I believe that IBM has replaced Visual Age for Java > with WSAD since a > long time. > Stefan Bodewig also wrote that the Visual Age

Re: [VOTE] removal of icontract based task in ant

2006-04-14 Thread Matt Benson
--- Antoine Levy-Lambert <[EMAIL PROTECTED]> wrote: > Hello, > > Do you want to remove from ant the usage of > icontract : > see the documentation of the optional task > icontract [1]. The link [2] > contained in the page [3] listing the library > dependencies of ant is dead. > > [+1] Yes > >

Re: [VOTE] removal of the test task based upon the org.apache.testlet framework

2006-04-14 Thread jm
+1 Martijn On Fri, 14 Apr 2006, Antoine Levy-Lambert wrote: Hello, Do you want to remove from ant the usage of the org.apache.testlet framework : see this document : [1] describing the optional task. [ ] Yes [ ] No I consider this a code change, requiring lazy approval and then lazy consen

Re: [VOTE] removal of Visual for Java based tasks

2006-04-14 Thread jm
+1, Martijn On Fri, 14 Apr 2006, Antoine Levy-Lambert wrote: Hello, Do you want to remove from ant the usage of Visual Age for Java : see this document : [1] I believe that IBM has replaced Visual Age for Java with WSAD since a long time. Stefan Bodewig also wrote that the Visual Age Tasks i

Re: [VOTE] removal of icontract based task in ant

2006-04-14 Thread jm
+1 Martijn On Fri, 14 Apr 2006, Antoine Levy-Lambert wrote: Hello, Do you want to remove from ant the usage of icontract : see the documentation of the optional task icontract [1]. The link [2] contained in the page [3] listing the library dependencies of ant is dead. [ ] Yes [ ] No I con

[VOTE] removal of the test task based upon the org.apache.testlet framework

2006-04-14 Thread Antoine Levy-Lambert
Hello, Do you want to remove from ant the usage of the org.apache.testlet framework : see this document : [1] describing the optional task. [ ] Yes [ ] No I consider this a code change, requiring lazy approval and then lazy consensus from the active committers. Let me start with my +1. Reg

[VOTE] removal of Visual for Java based tasks

2006-04-14 Thread Antoine Levy-Lambert
Hello, Do you want to remove from ant the usage of Visual Age for Java : see this document : [1] I believe that IBM has replaced Visual Age for Java with WSAD since a long time. Stefan Bodewig also wrote that the Visual Age Tasks in ant cannot work any more any way because they require Java 1.1

[VOTE] removal of icontract based task in ant

2006-04-14 Thread Antoine Levy-Lambert
Hello, Do you want to remove from ant the usage of icontract : see the documentation of the optional task icontract [1]. The link [2] contained in the page [3] listing the library dependencies of ant is dead. [ ] Yes [ ] No I consider this a code change, requiring lazy approval and then lazy

DO NOT REPLY [Bug 38732] - rmic task doesn't work with -Xnew and JDK 6.0

2006-04-14 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: svn commit: r393996 - /ant/core/trunk/src/main/org/apache/tools/ant/launch/Launcher.java

2006-04-14 Thread Antoine Levy-Lambert
Martijn Kruithof wrote: > Hi, > > I think the while construct is cleaner and more readable, and do not > see any real benefit of this code change. > Especially against using the for loop is that when using the for loop > the step of the loop should take place in the third part of the for, > and not

Re: svn commit: r393996 - /ant/core/trunk/src/main/org/apache/tools/ant/launch/Launcher.java

2006-04-14 Thread Kev Jackson
Martijn Kruithof wrote: Hi, I think the while construct is cleaner and more readable, and do not see any real benefit of this code change. Especially against using the for loop is that when using the for loop the step of the loop should take place in the third part of the for, and not somewh