Re: svn commit: r580302 - /ant/core/trunk/src/main/org/apache/tools/ant/types/resources/JavaResource.java

2007-09-28 Thread Peter Reilly
On 9/28/07, Alexey Solofnenko <[EMAIL PROTECTED]> wrote: > In general, I do not see a reason to replace perfectly readable single > liners with several lines of code - it just increases code bloat. We agreed to use the checkstyle config (src/etc/checkstyle/checkstyle-config) for ant about 2 years

svn commit: r580393 - /ant/core/trunk/src/main/org/apache/tools/ant/types/resources/JavaResource.java

2007-09-28 Thread peterreilly
Author: peterreilly Date: Fri Sep 28 08:47:45 2007 New Revision: 580393 URL: http://svn.apache.org/viewvc?rev=580393&view=rev Log: fix scoping Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/resources/JavaResource.java Modified: ant/core/trunk/src/main/org/apache/tools/ant/typ

Re: svn commit: r580302 - /ant/core/trunk/src/main/org/apache/tools/ant/types/resources/JavaResource.java

2007-09-28 Thread Alexey Solofnenko
In general, I do not see a reason to replace perfectly readable single liners with several lines of code - it just increases code bloat. Anybody with high IQ should be able to read old code as is. In this case the change is warranted, but please move "is" variable and try/finally inside "else"

svn commit: r580348 - in /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs: email/MimeMailer.java optional/jsp/WLJspc.java

2007-09-28 Thread peterreilly
Author: peterreilly Date: Fri Sep 28 06:35:41 2007 New Revision: 580348 URL: http://svn.apache.org/viewvc?rev=580348&view=rev Log: checkstyle: remove inner assignment Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/email/MimeMailer.java ant/core/trunk/src/main/org/apache/

DO NOT REPLY [Bug 43503] - add the if/unless like attributes to all core tasks

2007-09-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 28882] - Add if and unless attributes to ProjectComponent.

2007-09-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r580302 - /ant/core/trunk/src/main/org/apache/tools/ant/types/resources/JavaResource.java

2007-09-28 Thread peterreilly
Author: peterreilly Date: Fri Sep 28 04:13:19 2007 New Revision: 580302 URL: http://svn.apache.org/viewvc?rev=580302&view=rev Log: checkstyle: remove inner assignment Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/resources/JavaResource.java Modified: ant/core/trunk/src/main/

DO NOT REPLY [Bug 43503] New: - add the if/unless like attributes to all core tasks

2007-09-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 43438] - looping/race condition in Property/PropertyHelper

2007-09-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

[EMAIL PROTECTED]: Project dotnet-antlib-test (in module ant-antlibs) failed

2007-09-28 Thread Gump Integration Build
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project dotnet-antlib-test has an issue affecting its community integration. This issue a