Re: [VOTE] [second attempt] release of ant 1.8.0

2010-02-01 Thread Kevin Jackson
> this vote cancels and replaces the vote started on Friday. The vote of > Friday is cancelled because of a > bug affecting the junit task which would have suppressed the stack traces of > failing tests. > > The new build incorporates the fix for the junit stack traces issue. > > a candidate for an

Re: [VOTE] [second attempt] release of ant 1.8.0

2010-02-01 Thread Stefan Bodewig
On 2010-02-02, Antoine Levy Lambert wrote: > a candidate for ant 1.8.0 is available under > http://people.apache.org/~antoine/dist/apache-ant-1.8.0/ > Vote > [X] Release as Apache Ant 1.8.0 > [] Do not release yet +1 Stefan

Re: [PATCH] JUnitTestRunner.filterStack(String) does not flush BufferedWriter

2010-02-01 Thread Stefan Bodewig
On 2010-02-01, N C wrote: > --- On Mon, 2/1/10, Stefan Bodewig wrote: >> I'll revisit the remaining classes I have changed to ensure >> they close the writers now if they didn't do so before. > If you haven't, you might want to take a look at > PlainJUnitResultFormatter. It isn't clear to me

[VOTE] [second attempt] release of ant 1.8.0

2010-02-01 Thread Antoine Levy Lambert
Hi, this vote cancels and replaces the vote started on Friday. The vote of Friday is cancelled because of a bug affecting the junit task which would have suppressed the stack traces of failing tests. The new build incorporates the fix for the junit stack traces issue. a candidate for ant 1.

Re: [PATCH] JUnitTestRunner.filterStack(String) does not flush BufferedWriter

2010-02-01 Thread Antoine Levy Lambert
Thanks to you too again. We are redoing the next 1.8.0 RC because of what you found :-). Regards, Antoine N C wrote: --- On Sun, 1/31/10, Antoine Levy-Lambert wrote: If you are setup to build/compile ant yourself, you can update your working copy from svn and report whether the change fi

Re: [PATCH] JUnitTestRunner.filterStack(String) does not flush BufferedWriter

2010-02-01 Thread N C
--- On Mon, 2/1/10, Stefan Bodewig wrote: > > I'll revisit the remaining classes I have changed to ensure > they close the writers now if they didn't do so before. If you haven't, you might want to take a look at PlainJUnitResultFormatter. It isn't clear to me that the BufferedWriter "wri" is

Re: [PATCH] JUnitTestRunner.filterStack(String) does not flush BufferedWriter

2010-02-01 Thread N C
--- On Sun, 1/31/10, Antoine Levy-Lambert wrote: > If you are setup to build/compile ant yourself, you can > update your working copy from svn and report whether the change fixes > the problem for you. I've built from r905382. The problem is resolved in this build. Thanks. -

Re: [VOTE] release of ant 1.8.0

2010-02-01 Thread Jesse Glick
Stefan Bodewig wrote: "I don't get any stack traces in junit reports" may become an important issue This is a serious regression. -1 on releasing 1.8.0 with this bug. - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org F

Re: [VOTE] release of ant 1.8.0

2010-02-01 Thread Antoine Levy Lambert
Stefan Bodewig wrote: On 2010-01-30, Antoine Levy Lambert wrote: a candidate for ant 1.8.0 is available under http://people.apache.org/~antoine/dist/apache-ant-1.8.0/ The files look good and I'd give you my +1 for the release, but given that nobody else has voted so far and the "I do

Re: [VOTE] release of ant 1.8.0

2010-02-01 Thread Stefan Bodewig
On 2010-01-30, Antoine Levy Lambert wrote: > a candidate for ant 1.8.0 is available under > http://people.apache.org/~antoine/dist/apache-ant-1.8.0/ The files look good and I'd give you my +1 for the release, but given that nobody else has voted so far and the "I don't get any stack traces in ju

Re: [PATCH] JUnitTestRunner.filterStack(String) does not flush BufferedWriter

2010-02-01 Thread Stefan Bodewig
On 2010-02-01, Stefan Bodewig wrote: > I'll revisit the remaining classes I have changed to ensure they close > the writers now if they didn't do so before. I've identified a few cases where the writer wouldn't get flushed or closed in the error case - but things should be fine with the revision