Re: IvyDE JIRA issues and changes for proposed release?

2017-06-14 Thread Nicolas Lalevée
> Le 14 juin 2017 à 05:22, J Pai a écrit : > > There’s been some good progress on reviving the Ivy project (thanks Nicolas > and Jan for helping out with the reviews and merging PRs) and we seem to be > moving towards a state where the release is a possibility. The other project > IvyDE (the

Re: IVYDE-382 proposed patch

2017-06-14 Thread Nicolas Lalevée
Hi, For some reason git apply was refusing to process the patch and was just returning an error: corrupt patch at line 1964 So I played with git commands and work with the sources available on github. I have create a branch on the ASF repo, ivyDECredentials, which has one commit which squash al

Re: [VOTE] Release Compress Antlib 1.5 based on RC3

2017-06-14 Thread Matt Sicker
I generally import each project's KEYS file, and having been to a key signing party before at ApacheCon, I have a small web of trust to help verify those signatures. The more people sign each other's keys, the easier it is to verify. On 14 June 2017 at 02:59, Jan Matèrne (jhm) wrote: > My first

[GitHub] ant-ivy issue #43: Generics and related fixes in tests and tutorials

2017-06-14 Thread janmaterne
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/43 Merged that, thanks. Hint for future PRs: smaller are better (easier to review) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] ant-ivy pull request #43: Generics and related fixes in tests and tutorials

2017-06-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/43 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] ant-ivy issue #43: Generics and related fixes in tests and tutorials

2017-06-14 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/43 I mean, why use an NPE when one can have an assertion that fails? It's a cleaner approach. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] ant-ivy issue #43: Generics and related fixes in tests and tutorials

2017-06-14 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/43 That's exactly why I introduced assertNotNull :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] ant-ivy issue #43: Generics and related fixes in tests and tutorials

2017-06-14 Thread janmaterne
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/43 Nop ... yes. You're right with 'null instanceof SomeClass'==true. But the two assertions are different: moduleId = null; assertFalse(moduleId.equals(null);; --> this will throw a NullPo

AW: [VOTE] Release Compress Antlib 1.5 based on RC3

2017-06-14 Thread jhm
My first thought was 'I want to have all the stuff inside the distro.' That means also the ASC. But having the ASC inside the distro means letting the key on the lock ... So the 2nd thought was: how to verify the download? - download - hashvalue checksum - pgp check We could provide a howto file

Re: [VOTE] Release Compress Antlib 1.5 based on RC3

2017-06-14 Thread Stefan Bodewig
On 2017-06-13, Jan Matèrne (jhm) wrote: >> Should we include the PGP [e.g. 1] signature in the future? > Answer myself: should be only on ASF server, so people could trust that ;) > Maybe place a note (next time) how to check that (do we have a build snippet > for that?) I'm not exactly sure wha