[GitHub] ant issue #76: bz-43144 - Improve the performance of the tar task when it us...

2018-11-04 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/76 Quite a bit of code :-) Looks as if you had found a solution with minimal API impact that can be extended to cases other than just `tar` although I'm afraid we are using resource collections

[GitHub] ant issue #76: bz-43144 - Improve the performance of the tar task when it us...

2018-11-04 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/76 Quite a bit of code :-) Looks as if you had found a solution with minimal API impact that can be extended to cases other than just `tar` although I'm afraid we are using resource collections

[GitHub] ant issue #77: Avoid FileInputStream and FileOutputStream.

2018-11-04 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/77 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/83/ ---

[GitHub] ant issue #77: Avoid FileInputStream and FileOutputStream.

2018-11-04 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/77 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/89/ ---

[GitHub] ant issue #77: Avoid FileInputStream and FileOutputStream.

2018-11-04 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/77 this is ok to test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail:

[GitHub] ant pull request #77: Avoid FileInputStream and FileOutputStream.

2018-11-04 Thread reudismam
GitHub user reudismam opened a pull request: https://github.com/apache/ant/pull/77 Avoid FileInputStream and FileOutputStream. Avoid FileInputStream and FileOutputStream. These classes override the finalize method. As a result, their objects are only cleaned when the garbage

[GitHub] ant issue #77: Avoid FileInputStream and FileOutputStream.

2018-11-04 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/77 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail:

[GitHub] ant issue #77: Avoid FileInputStream and FileOutputStream.

2018-11-04 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/77 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail:

Re: [1/2] ant git commit: Checkstyle: dangling operators

2018-11-04 Thread Stefan Bodewig
-1 Gintas please revert this and the three following SonarQube commits. They are to big, add no value at all and introduce regressions (you've already found one and revertd it and I fear there are more of them). Stefan - To