Re: [PR] Exit ant.bat with ERROR_ENVVAR_NOT_FOUND if ANT_HOME isn't/can't be set [ant]

2025-07-03 Thread via GitHub
bodewig commented on PR #222: URL: https://github.com/apache/ant/pull/222#issuecomment-3034658573 Your call. Thanks again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Exit ant.bat with ERROR_ENVVAR_NOT_FOUND if ANT_HOME isn't/can't be set [ant]

2025-07-03 Thread via GitHub
robho commented on PR #222: URL: https://github.com/apache/ant/pull/222#issuecomment-3033450671 Thanks for merging! No need to credit me for this change :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Exit ant.bat with ERROR_ENVVAR_NOT_FOUND if ANT_HOME isn't/can't be set [ant]

2025-07-03 Thread via GitHub
bodewig merged PR #222: URL: https://github.com/apache/ant/pull/222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For

Re: [PR] Exit ant.bat with ERROR_ENVVAR_NOT_FOUND if ANT_HOME isn't/can't be set [ant]

2025-07-03 Thread via GitHub
bodewig commented on PR #222: URL: https://github.com/apache/ant/pull/222#issuecomment-3032715013 Many thanks @robho - do you want us to credit you in CONTRIBUTORS and contributors.xml? If so which name do you want us to use? -- This is an automated message from the Apache Git Service. To

Re: [PR] Exit ant.bat with ERROR_ENVVAR_NOT_FOUND if ANT_HOME isn't/can't be set [ant]

2025-07-03 Thread via GitHub
robho commented on PR #222: URL: https://github.com/apache/ant/pull/222#issuecomment-303227 I have changed to use ERROR_ENVVAR_NOT_FOUND. There wasn't much thought behind choosing ERROR_FILE_NOT_FOUND and I agree that ERROR_ENVVAR_NOT_FOUND does seem more appropriate. -- This i

Re: [PR] Exit ant.bat with ERROR_FILE_NOT_FOUND if ANT_HOME isn't/can't be set [ant]

2025-07-03 Thread via GitHub
bodewig commented on PR #222: URL: https://github.com/apache/ant/pull/222#issuecomment-3031963845 I'm not too familiar with Windows error codes, but 3 seems to mean "path not found" which may be closer to the cause of the error. And then https://learn.microsoft.com/en-us/windows/win3