Github user aprelev closed the pull request at:
https://github.com/apache/ant-ivy/pull/74
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user aprelev commented on the issue:
https://github.com/apache/ant-ivy/pull/74
Do you think overhead decrease achieved by using `singletonList()`
outweighs breaking the pattern of `List` initialisations in test body? This is
my second week with Java, these subtle differences
Github user aprelev commented on the issue:
https://github.com/apache/ant-ivy/pull/74
I replaced `Arrays.equals()` with `List.containsAll()`, as you suggested;
thank you.
---
-
To unsubscribe, e-mail: dev-unsubscr
GitHub user aprelev opened a pull request:
https://github.com/apache/ant-ivy/pull/74
Fix IVY-982 by subtracting negated entries from wildcard bin
### Issue
Configurations negation (exclusion) as in `conf="*, !foo->@"` does not work,
This issue is reported in
[I
Github user aprelev commented on the issue:
https://github.com/apache/ant-ivy/pull/73
Why doesn't it show as **merged** though?
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional comman
Github user aprelev closed the pull request at:
https://github.com/apache/ant-ivy/pull/73
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user aprelev commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/73#discussion_r207675516
--- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java ---
@@ -193,16 +193,8 @@ public void startElement(String uri, String localName,
String
Github user aprelev commented on the issue:
https://github.com/apache/ant-ivy/pull/73
Okay, I've implemented robust ASN.1-like encoding as
```
prefix* qualifierLength separator qualifier* separator* name
```
such as `extra-3.foo-bar` for `foo:bar`, and `extra-0.foo
Github user aprelev commented on the issue:
https://github.com/apache/ant-ivy/pull/73
To be honest, I do not like the idea of imposing implicit requirements on
naming of namespaces. Escaping dashes in prefixes seems more robust and
error-prone given correct codec is implemented. I
Github user aprelev commented on the issue:
https://github.com/apache/ant-ivy/pull/73
> Using a simple '-' as a separator may cause trouble if somebody decides
to use a namespace prefix with '-'.
I don't actually see a problem with that: we can
Github user aprelev commented on the issue:
https://github.com/apache/ant-ivy/pull/73
@twogee, why don't we just stick with deterministic encoding like
```Java
extra- // e.g. extra-e:foo, extra-m:classifier, extra-foo
```
since both `'-'` and `'
Github user aprelev commented on the issue:
https://github.com/apache/ant-ivy/pull/73
By the way, found [issue
IVY-1104](https://issues.apache.org/jira/browse/IVY-1104) in your issue
tracker, seems to be the case
Github user aprelev commented on the issue:
https://github.com/apache/ant-ivy/pull/73
As of now, two sets of dependencies are constructed in a different ways:
- *currently resolved dependecies* are produced by Ivy resolve engine, with
**both qualified and unqualified
Github user aprelev commented on the issue:
https://github.com/apache/ant-ivy/pull/73
@twogee Can you point me in the right direction regarding namespace URL?
And what are your thoughts on including the namespace prefix in the report
Github user aprelev commented on the issue:
https://github.com/apache/ant-ivy/pull/73
Should I reopen PR?
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h
Github user aprelev commented on the issue:
https://github.com/apache/ant-ivy/pull/73
> Rather than hardcoding prefix, shouldn't we retrieve it by URL
"http://ant.apache.org/ivy/extra";?
Can you elaborate on prefix retrieving? The **extra-** prefix is [ha
Github user aprelev commented on the issue:
https://github.com/apache/ant-ivy/pull/73
> Tests have passed https://builds.apache.org/job/Ivy-GithubPR/361/
Not really, my changes were not applied in this build.
Test *testDepsWithAttributesChanged* should have run un
Github user aprelev commented on the issue:
https://github.com/apache/ant-ivy/pull/73
By the way, latest commits 43ddccb859b94c79350ece7520af4c991c2bb5e6 and
5918182e0d6836d89c42260da9de4428d4cbcec0 introduced [nested "javaversion"
element](https://github.com/apache/an
GitHub user aprelev opened a pull request:
https://github.com/apache/ant-ivy/pull/73
Enable XML report parser to produce qualified extra attributes
### Issue
`${ivy.deps.changed}` is always `true` for dependencies with extra
attributes.
### Problem
`XmlReportParser
19 matches
Mail list logo
