[GitHub] ant-ivy issue #70: IVY-1321 Make Main.run() public

2018-03-21 Thread supertick
Github user supertick commented on the issue: https://github.com/apache/ant-ivy/pull/70 Looks great ! (had to look up what REPL is - thanks for the heads up) --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] ant-ivy issue #70: IVY-1321 Make Main.run() public

2018-03-20 Thread supertick
Github user supertick commented on the issue: https://github.com/apache/ant-ivy/pull/70 I would make a default overload which took only a String[] arg to model **exactly** the Main.main input, but all the rest is perfect, including the better isCli boolean vs silly cli option

[GitHub] ant-ivy issue #70: Make Main.run() usable programmatically

2018-03-19 Thread supertick
Github user supertick commented on the issue: https://github.com/apache/ant-ivy/pull/70 I agree @twogee now that I've seen your change, your solution would be better. I felt too, adding a new command line option was not the best, but also felt strongly, with minimal work

[GitHub] ant-ivy issue #69: 2.4.x

2018-03-19 Thread supertick
Github user supertick commented on the issue: https://github.com/apache/ant-ivy/pull/69 I think it would be great "not" to have an additional CLI option, but then you cannot have a System.exit(1) terminating the client code (https://github.com/apache/ant-ivy/blob/2.4.x/sr

[GitHub] ant-ivy pull request #69: 2.4.x

2018-03-18 Thread supertick
GitHub user supertick opened a pull request: https://github.com/apache/ant-ivy/pull/69 2.4.x You can merge this pull request into a Git repository by running: $ git pull https://github.com/supertick/ant-ivy 2.4.x Alternatively you can review and apply these changes