Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

On 2018-05-20, Gintautas Grigelionis wrote: > This time, I tried to start a discussion first, and I got no response. > There were attempts to modernize the codebase about a year ago. AFAICS > there was no discussion then. True. I for one didn't expect you to try weeding out all deprecated APIs

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-20 16:08 GMT+02:00 Stefan Bodewig : > I'm afraid you misunderstood my question. I didn't ask why streams may > be preferable over Enumerations when you write new code or change > existing code. I was asking how does this benefit the existing code > right now when there

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-18 16:11 GMT+02:00 Johan Corveleyn : > 2) There is clearly no consensus here on the merits / desirability of > these bulk changes. Gintas, I understand your desire to move things > along, and you clearly have an opinion about it, but IMHO you really > need to stop doing

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

On 2018-05-20, Gintautas Grigelionis wrote: > 2018-05-18 16:51 GMT+02:00 Stefan Bodewig : >> On 2018-05-18, Gintautas Grigelionis wrote: >>> I believe that Streams API can at least implement the logic run by an >>> original Enumeration in a more concise way, or provide more

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-18 16:51 GMT+02:00 Stefan Bodewig : > On 2018-05-18, Gintautas Grigelionis wrote: > > > I believe that Streams API can at least implement the logic run by an > > original Enumeration in a more concise way, or provide more powerful > idioms. > > That IMO makes it worth

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

On 2018-05-18, Gintautas Grigelionis wrote: > I believe that Streams API can at least implement the logic run by an > original Enumeration in a more concise way, or provide more powerful idioms. > That IMO makes it worth the while to investigate the Streams alternatives. I agree to do that as

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

On Fri, May 18, 2018 at 10:07 AM, Gintautas Grigelionis wrote: > I accepted the original criticism that going Enumeration -> List -> Stream > has an overhead and I tried to address that by using a decorator. > I believe that Streams API can at least implement the logic

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

e. Especially when it's being done on something like for archive >>>> >>>>> entries which can betoo many depending on the archive that is being >>>>> dealt >>>>> with. >>>>> >>>>> -Jaikiran >>>

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

a List just for iterating it doesn't seem performance and memory wise a good idea to me. Maarten Van: "gin...@apache.org" <gin...@apache.org> Aan: notificati...@ant.apache.org Verzonden: woensdag 16 mei 19:13 2018 Onderwerp: [1/2] ant git commit: Deprecate Collection

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

d memory wise a good idea to me. >>>> Maarten >>>> >>>> Van: "gin...@apache.org" <gin...@apache.org> >>>>Aan: notificati...@ant.apache.org >>>>Verzonden: woensdag 16 mei 19:13 2018 >>>>Onderw

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

Verzonden: woensdag 16 mei 19:13 2018 Onderwerp: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration Repository: ant Updated Branches: refs/heads/master ac35c0014 -> 070c3bc86 http://git-wip-us.apache.org/repos/asf/ant/blob/070c3bc8/s

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

@apache.org" <gin...@apache.org> >> Aan: notificati...@ant.apache.org >> Verzonden: woensdag 16 mei 19:13 2018 >> Onderwerp: [1/2] ant git commit: Deprecate CollectionUtils and >> Enumerations; reduce explicit use of Enumeration >> Repository: ant >

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

and memory wise a good idea to me. Maarten Van: "gin...@apache.org" <gin...@apache.org> Aan: notificati...@ant.apache.org Verzonden: woensdag 16 mei 19:13 2018 Onderwerp: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

Converting an Enumeration to a List just for iterating it doesn't seem performance and memory wise a good idea to me. Maarten Van: "gin...@apache.org" <gin...@apache.org> Aan: notificati...@ant.apache.org Verzonden: woensdag 16 mei 19:13 2018 Onderwerp: [1/2] ant git c