[GitHub] ant-ivy issue #33: More code cleanup

2017-05-29 Thread janmaterne
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/33 You're right. I looked at a dictionary. I'll change that, so haven't to think about that in the future. ;) --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] ant-ivy issue #33: More code cleanup

2017-05-29 Thread nlalevee
Github user nlalevee commented on the issue: https://github.com/apache/ant-ivy/pull/33 In french we have "ssi" which is a contraction of "si et seulement si" which has a mathematical meaning about absolute equivalence between two propositions. I bet that in english "iff" means the

[GitHub] ant-ivy issue #33: More code cleanup

2017-05-29 Thread janmaterne
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/33 merged, thanks for the huge work. What about the "iff"? I am not a native speaker and dont want to judge ;) --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] ant-ivy issue #33: More code cleanup

2017-05-29 Thread janmaterne
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/33 Because of the problems I dont merge this ATM. We should discuss them on the dev list before. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] ant-ivy issue #33: More code cleanup

2017-05-29 Thread janmaterne
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/33 build.xml - Nice idea with the copyright statement in Javadoc ( (c)${years} ; years=tstamp("2007-") ). You found a lot of spell errors ;) MatcherLookup.java#get(Map): new

[GitHub] ant-ivy issue #33: More code cleanup

2017-05-28 Thread janmaterne
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/33 start reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or