[GitHub] ant issue #24: fix 60150 values containing backtick or $ character cause she...

2016-09-28 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/24 merged, many thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] ant issue #24: fix 60150 values containing backtick or $ character cause she...

2016-10-07 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/24 @jwadamson do you think you could have a look at the Solaris problems with args processing in https://bz.apache.org/bugzilla/show_bug.cgi?id=59321 ? I must admit I'm confused by the different escaping st

[GitHub] ant issue #24: fix 60150 values containing backtick or $ character cause she...

2016-10-07 Thread jwadamson
Github user jwadamson commented on the issue: https://github.com/apache/ant/pull/24 Solaris is not my expertise either. The attachment https://bz.apache.org/bugzilla/attachment.cgi?id=34221&action=diff looks reasonable. So it is wrapping each $arg with double-quotes

[GitHub] ant issue #24: fix 60150 values containing backtick or $ character cause she...

2016-10-07 Thread jwadamson
Github user jwadamson commented on the issue: https://github.com/apache/ant/pull/24 playing with this alternate impl for now. So far works with dash and ksh and a torture parameter: $ ./bin/ant --execdebug run "-Dfoo=dollar\$backtick\`single'double\"backslash\\" ```

[GitHub] ant issue #24: fix 60150 values containing backtick or $ character cause she...

2016-10-08 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/24 Thanks, I'll push your alternative and ask the original reporter to give it a try. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] ant issue #24: fix 60150 values containing backtick or $ character cause she...

2016-10-08 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/24 Many, many thanks, I've pushed your alternative and asked the original reporter to give it a try. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] ant issue #24: fix 60150 values containing backtick or $ character cause she...

2016-10-08 Thread jwadamson
Github user jwadamson commented on the issue: https://github.com/apache/ant/pull/24 I hate dealing with arbitrary arguments. Those regex expressions still don't feel 100% comfortable to me as to even why they seem to work. Trial and error is not a good way to figure out patterns. Shou

[GitHub] ant issue #24: fix 60150 values containing backtick or $ character cause she...

2016-10-08 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/24 I realized the "torture line" was broken but managed to figure it out myself :-) I'm afraid it is more about the different versions of `sed` than the shell. I vaguely recall having to use differ

[GitHub] ant issue #24: fix 60150 values containing backtick or $ character cause she...

2016-10-08 Thread jwadamson
Github user jwadamson commented on the issue: https://github.com/apache/ant/pull/24 and apparently bash built-in echo also interprets sequences in arguments. That is sort of my concern too. We may need to detect platforms and have different expressions. Using personal mac now,

[GitHub] ant issue #24: fix 60150 values containing backtick or $ character cause she...

2016-10-08 Thread jwadamson
Github user jwadamson commented on the issue: https://github.com/apache/ant/pull/24 I see a couple options: 1) we can continue playing with sed, but probably should use `printf '%s' "$X"` instead of echo to pipe the input to avoid issues with trailing newlines and echo interpreta

[GitHub] ant issue #24: fix 60150 values containing backtick or $ character cause she...

2016-10-10 Thread jwadamson
Github user jwadamson commented on the issue: https://github.com/apache/ant/pull/24 I think dash may not support that substitution pattern :-( Still investigating --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] ant issue #24: fix 60150 values containing backtick or $ character cause she...

2016-10-10 Thread jwadamson
Github user jwadamson commented on the issue: https://github.com/apache/ant/pull/24 Will have another attempt at this later today. So far tested on ubunutu ksh, bash, dash as the bin/sh. Will try to get a true solarus and mac platforms to test since this is what led to back to thi

[GitHub] ant issue #24: fix 60150 values containing backtick or $ character cause she...

2016-10-10 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/24 Thanks Jeff. I've asked for help on the dev and user mailing lists. It's not only Solaris but also HP/UX which may be even more difficult to get hold of. --- If your project is set up for it, you can re

[GitHub] ant issue #24: fix 60150 values containing backtick or $ character cause she...

2016-10-10 Thread jwadamson
Github user jwadamson commented on the issue: https://github.com/apache/ant/pull/24 Thanks, will try to find the threads on mailing list. Still making improvments, fixed an issue with mac sed that it doesn't support group-0. Annoying. Also finally figured out why so many backslashes,

[GitHub] ant issue #24: fix 60150 values containing backtick or $ character cause she...

2016-10-10 Thread jwadamson
Github user jwadamson commented on the issue: https://github.com/apache/ant/pull/24 So I think I figured out some of this in terms of why escaping was so funny. Also found an issue with sed on mac (no group-0 reference) in my earlier fix. The bash variable replacement s

[GitHub] ant issue #24: fix 60150 values containing backtick or $ character cause she...

2016-10-10 Thread jwadamson
Github user jwadamson commented on the issue: https://github.com/apache/ant/pull/24 Oh, and the final two lines of ant script needed quotes to preserve intra-argument whitespace properly --Jeff On Mon, Oct 10, 2016 at 3:36 PM, Jeff Adamson wrote: > S