Re: [Patch] removed multiple returns from AntTypeDefinition.getTypeClass

2004-11-05 Thread Kevin Jackson
Well, I for one disagree ;-) I always return early for trivial cases, getting them out of the way, making it obvious that the meat or rest of a method works only for given validated inputs (pre-conditions of sort). It also avoids having to scroll down to figure out what happens next, like the valu

RE: [Patch] removed multiple returns from AntTypeDefinition.getTypeClass

2004-11-04 Thread Dominique Devienne
> From: Kevin Jackson [mailto:[EMAIL PROTECTED] > It's not a fix or anything, but IM(very humble)O having one return makes > the code easier to understand. Well, I for one disagree ;-) I always return early for trivial cases, getting them out of the way, making it obvious that the meat or rest of

[Patch] removed multiple returns from AntTypeDefinition.getTypeClass

2004-11-04 Thread Kevin Jackson
Hi, Another quick one. AntTypeDefinition.getTypeClass if(clazz != null) { return clazz; } try { }catch() etc etc return clazz; I've reversed the logic and now there's only one return from this method. ie if (clazz == null) { try { [loads of things] } catch() { return clazz; It's not a fix or anyt