Re: Bugzilla Issue 45902 (Up-to-date checks for JARs broken due to comparison of dir timestamps)

2009-01-30 Thread Stefan Bodewig
On 2009-01-29, Jesse Glick wrote: > Stefan Bodewig wrote: >> Did I sound like "if you think you understand Zip.java better than I >> do"? If so, please forgive me, this was in no way intended. > I just meant that you likely have a deeper understanding of Zip - and > in particular the newer res

Re: Bugzilla Issue 45902 (Up-to-date checks for JARs broken due to comparison of dir timestamps)

2009-01-29 Thread Jesse Glick
Stefan Bodewig wrote: * a single empty directory is added to the sources - I think Ant will now no longer create a new archive Is this really a bug? Some people say so https://issues.apache.org/bugzilla/show_bug.cgi?id=20366 True, although skipping dir timestamps just means that such a

Re: Bugzilla Issue 45902 (Up-to-date checks for JARs broken due to comparison of dir timestamps)

2009-01-29 Thread Stefan Bodewig
On 2009-01-28, Jesse Glick wrote: > Stefan Bodewig wrote: >> has been changed to ignore directory resources > The intent was to ignore timestamp changes in directory resources > when determining whether or not to rebuild an existing JAR, not to > ignore directories altogether. >> * a single em

Re: Bugzilla Issue 45902 (Up-to-date checks for JARs broken due to comparison of dir timestamps)

2009-01-28 Thread Jesse Glick
Stefan Bodewig wrote: has been changed to ignore directory resources The intent was to ignore timestamp changes in directory resources when determining whether or not to rebuild an existing JAR, not to ignore directories altogether. * a single empty directory is added to the sources - I th

Bugzilla Issue 45902 (Up-to-date checks for JARs broken due to comparison of dir timestamps)

2009-01-28 Thread Stefan Bodewig
In http://svn.eu.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Zip.java?r1=738330&r2=738329&pathrev=738330 has been changed to ignore directory resources and I'm afraid this is going to cause some issues. without reviewing the code just now (zip is a pretty convulted pie