RE: DynamicTag

2003-04-16 Thread peter reilly
Dominique Devienne wrote: Interesting... So how come DynamicTag is not compatible with Ant 1.6, when it compiles and works fine with 1.5.1??? Sounds like an incompatible API change to me, which hopefully will be fixed. It compiles on Ant 1.6, but currently the unknownelement returned does not get

RE: DynamicTag

2003-04-16 Thread Costin Manolache
Dominique Devienne wrote: 2) DynamicTag is lazy, thanks to UnknownElement. Your rewrite is creating the element at parse-time, my implementation does it only at runtime. Again, I favor delaying the instantiation and configuration. Ant should never have mingled parsing of the XML

Re: DynamicTag

2003-04-16 Thread Conor MacNeill
On Wed, 16 Apr 2003 12:55 am, Dominique Devienne wrote: 2) DynamicTag is lazy, thanks to UnknownElement. Your rewrite is creating the element at parse-time, my implementation does it only at runtime. Again, I favor delaying the instantiation and configuration. Ant should never have mingled

Re: DynamicTag

2003-04-16 Thread Steve Loughran
- Original Message - From: Conor MacNeill [EMAIL PROTECTED] To: Ant Developers List [EMAIL PROTECTED] Sent: Tuesday, April 15, 2003 22:42 Subject: Re: DynamicTag The first place was a very long time ago and there was a lot of history for why Ant is the way it is. You might

RE: DynamicTag

2003-04-15 Thread peter reilly
Hi, I am on holidays, but have followed this thread. I have been playing with DynamicTag and it is quite neat, but there are some issues with it.. I have made some modifications (well rewrite...) 1) DynamicTag uses UnknownElement. This part of ant code is undergoing a number of changes

RE: DynamicTag

2003-04-15 Thread Dominique Devienne
Interesting... So how come DynamicTag is not compatible with Ant 1.6, when it compiles and works fine with 1.5.1??? Sounds like an incompatible API change to me, which hopefully will be fixed. I have a few remarks: 1) I favor composition over inheritance. DynamicTag is designed to be composed