Re: Ivy - BasicURLHandler ignoring timeout during connection?

2017-05-20 Thread J Pai
>>I was merely speculating as to why HttpClient is there and what challenges >> lay ahead should that part of code be refreshed. Understood :) >> Sorry for digressing, adding setConnectTimeout is fine I sent a PR with minimal changes for now https://github.com/apache/ant-ivy/pull/23 >> (even

Re: Ivy - BasicURLHandler ignoring timeout during connection?

2017-05-20 Thread Gintautas Grigelionis
I was merely speculating as to why HttpClient is there and what challenges lay ahead should that part of code be refreshed. Sorry for digressing, adding setConnectTimeout is fine (even though setTimeout from HttpClient corresponds to setReadTimeout in URLConnection -- perhaps that should be change

Re: Ivy - BasicURLHandler ignoring timeout during connection?

2017-05-20 Thread J Pai
Having been involved in a HttpClient 3 to 4 migration in an unrelated project, I think at this point, it’s too big a change to consider. A few stable Ivy releases down the line, maybe we can re-evaluate this and consider the HttpClient libraries and their state at that time. -Jaikiran On 20-May

Re: Ivy - BasicURLHandler ignoring timeout during connection?

2017-05-20 Thread Gintautas Grigelionis
Looks like HttpClientHandler was added as an alternative to handle proxies with authentication by wrapping HttpClient from Commons. There is a maintenance problem because HttpClient has a major API change between version 3 (that Ivy uses currently) and 4. Perhaps it makes sense to look at AsyncHtt

Re: Ivy - BasicURLHandler ignoring timeout during connection?

2017-05-20 Thread Nicolas Lalevée
I don’t know the history of that code, it probably is older that its incubation into Apache. But from what I can read, I think that timeout was introduced but just supported by one implementation of URLHandler: the HttpClient one, HttpClientHandler. Proper support in the BasicURLHandler will pr

Re: Ivy - BasicURLHandler ignoring timeout during connection?

2017-05-19 Thread Gintautas Grigelionis
My 2¢: timeout has only effect on doHead, in all other cases Ivy is trying the hardest it can. Just search for setTimeout :-) 2017-05-19 16:10 GMT+02:00 J Pai : > I was looking at some timing issues in test cases and noticed that the > BasicURLHandler.getURLInfo with a timeout[1] seems to be ign

Ivy - BasicURLHandler ignoring timeout during connection?

2017-05-19 Thread J Pai
I was looking at some timing issues in test cases and noticed that the BasicURLHandler.getURLInfo with a timeout[1] seems to be ignoring that timeout completely. Am I missing something or is it just a oversight/bug? Furthermore, the javadoc of URLHandler.getURLInfo doesn’t tell much about what t