Re: Need a Second Pair of Eyes

2018-02-14 Thread Stefan Bodewig
On 2018-02-14, Stefan Bodewig wrote: > On 2018-02-14, Jaikiran Pai wrote: >> You are right. The change introduces a different behaviour than what >> was there before. Just to be extra sure that we indeed are reading it >> right, I added a (dummy) test case in my personal repo, which compares >> t

Re: Need a Second Pair of Eyes

2018-02-14 Thread Stefan Bodewig
On 2018-02-14, Jaikiran Pai wrote: > You are right. The change introduces a different behaviour than what > was there before. Just to be extra sure that we indeed are reading it > right, I added a (dummy) test case in my personal repo, which compares > the previous logic and the new logic and it d

Re: Need a Second Pair of Eyes

2018-02-13 Thread Jaikiran Pai
I forgot to add that, as you note, as a result of the change, the new created path will retain all elements from destPath that aren't in dependClassPath, which is unlike the behaviour before the change. -Jaikiran On 14/02/18 9:59 AM, Jaikiran Pai wrote: Hi Stefan, You are right. The change

Re: Need a Second Pair of Eyes

2018-02-13 Thread Jaikiran Pai
Hi Stefan, You are right. The change introduces a different behaviour than what was there before. Just to be extra sure that we indeed are reading it right, I added a (dummy) test case in my personal repo, which compares the previous logic and the new logic and it does shows that the change i

Need a Second Pair of Eyes

2018-02-13 Thread Stefan Bodewig
Hi all I'm currently reviewing the big change that introduced the regression in 1.10.2 as we may have overlooked more than this issue. It is a *big* change and so it is taking time. While looking at the hunk starting at https://github.com/apache/ant/commit/b7d1e9bde44cb8e5233d6e70bb96e14cbb2f3e2