Re: enhancement for PropertyFile, have a patch

2005-10-03 Thread Phil Hourihane
Created as issue 36901 in bugzilla. http://issues.apache.org/bugzilla/show_bug.cgi?id=36901 PHiL --- Phil Hourihane <[EMAIL PROTECTED]> wrote: > Oops. Sorry about that. Will do. > > PHiL > > --- Dominique Devienne <[EMAIL PROTECTED]> wrote: > > > > The changes listed below are contained in t

Re: enhancement for PropertyFile, have a patch

2005-10-03 Thread Phil Hourihane
Oops. Sorry about that. Will do. PHiL --- Dominique Devienne <[EMAIL PROTECTED]> wrote: > > The changes listed below are contained in the > patch > > file. The other files are attached individually. > > This list strips attachments usually. Please open a > BugZilla > enhancement isntead, and at

Re: enhancement for PropertyFile, have a patch

2005-09-04 Thread Phil Hourihane
Steve, > I wonder if any of the CLASSPATH/Harmony java tests > for property file parsing could be used here I have a test class to accompany the submission. It doesn't expand on the test class for the PropertyFile task (which is, in fact, unchanged). Instead it puts the new Properties subclass th

Re: enhancement for PropertyFile, have a patch

2005-09-04 Thread Steve Loughran
Phil Hourihane wrote: Dominique, I was pretty sure that Sun's stuff, although available in source form, wasn't open-source per se, so I avoided hacking their code. The class I have is subclassed from Properties (to allow for polymorphic substitution), and includes its own code for parsing the in

Re: enhancement for PropertyFile, have a patch

2005-09-03 Thread Dominique Devienne
See bottom of http://www.apache.org/licenses/ and http://www.apache.org/licenses/software-grant.txt. --DD - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: enhancement for PropertyFile, have a patch

2005-09-03 Thread Phil Hourihane
Dominique, I was pretty sure that Sun's stuff, although available in source form, wasn't open-source per se, so I avoided hacking their code. The class I have is subclassed from Properties (to allow for polymorphic substitution), and includes its own code for parsing the incoming file and handling

Re: enhancement for PropertyFile, have a patch

2005-09-03 Thread Dominique Devienne
I agree with your analysis. Your enhanced PropertyFile task doesn't fit the filterchain framework, although as Antoine rightly writes, many other things do fit it and should be implemented or retrofitted into that framework. Regarding your submission per se, it really depends on how you coded it.

RE: enhancement for PropertyFile, have a patch

2005-09-02 Thread Phil Hourihane
vy-Lambert [mailto:[EMAIL PROTECTED] > > > Sent: Friday, September 02, 2005 10:03 AM > > To: Ant Developers List > > Subject: Re: enhancement for PropertyFile, have a > > patch > > > > Hello Phil, > > I wonder whether, instead of patching > PropertyF

RE: enhancement for PropertyFile, have a patch

2005-09-02 Thread Phil Hourihane
te: > +1 - excellent proposal > > -Original Message- > From: Antoine Levy-Lambert [mailto:[EMAIL PROTECTED] > Sent: Friday, September 02, 2005 10:03 AM > To: Ant Developers List > Subject: Re: enhancement for PropertyFile, have a > patch > > Hello Phil, > I w

Re: enhancement for PropertyFile, have a patch

2005-09-02 Thread Antoine Levy-Lambert
Hello Phil, I wonder whether, instead of patching PropertyFile, you should not study how the framework works and implement the functionalitiy of propertyfile as a filter. Then it should be possible to change the implementation of propertyfile to make it use filters. To my opinion, all tasks which

RE: enhancement for PropertyFile, have a patch

2005-09-02 Thread Burgess, Benjamin
+1 - excellent proposal -Original Message- From: Antoine Levy-Lambert [mailto:[EMAIL PROTECTED] Sent: Friday, September 02, 2005 10:03 AM To: Ant Developers List Subject: Re: enhancement for PropertyFile, have a patch Hello Phil, I wonder whether, instead of patching PropertyFile, you