Re: SSH tracking - Take 4

2004-04-08 Thread Stefan Bodewig
On Wed, 7 Apr 2004, Rami Ojares <[EMAIL PROTECTED]> wrote: >> What we need now, are docs. > > Yep, I think also Jsch would need some docs and an API that does not > need one to write bytes by hand but that is another story. True. > I can help of course with the docs (but slowly :) A patch that

Re: SSH tracking - Take 4

2004-04-07 Thread Rami Ojares
> Thanks, I've committed the patch with some (minor) modifications. The pleasure is mine. > What we need now, are docs. Yep, I think also Jsch would need some docs and an API that does not need one to write bytes by hand but that is another story. I can help of course with the docs (but slowly :

Re: SSH tracking - Take 3

2004-04-07 Thread Stefan Bodewig
On Wed, 7 Apr 2004, Rami Ojares <[EMAIL PROTECTED]> wrote: > Here are answers to your questions + new patches. Thanks, I've committed the patch with some (minor) modifications. What we need now, are docs. Also, I'm not sure whether the form of the progess report is really optimal, that's why I

Re: SSH tracking - Take 3

2004-04-07 Thread Rami Ojares
Here are answers to your questions + new patches. Q: I don't see you using SSHBase in AbstractSshMessage at all, so you don't need to add it as an attribute. The subclasses only need to know whether verbose output has been requested, so they don't need a reference to sshbase either, just th

Re: SSH tracking

2004-04-07 Thread Stefan Bodewig
On Tue, 6 Apr 2004, Rami Ojares <[EMAIL PROTECTED]> wrote: > Have a look at this patch Stefan. (It's patch from the whole > directory) I added verbose attribute and rearranged things a little. A few comments. * I don't see you using SSHBase in AbstractSshMessage at all, so you don't need to ad

Re: SSH tracking

2004-04-06 Thread Rami Ojares
> I'd like to see your patch modified so that you'll only see a progress > report when the (new) attribute verbose has been set to true. Just > like does today. Have a look at this patch Stefan. (It's patch from the whole directory) I added verbose attribute and rearranged things a little. cvs

Re: SSH tracking

2004-04-06 Thread Stefan Bodewig
On Mon, 5 Apr 2004, Rami Ojares <[EMAIL PROTECTED]> wrote: > I was planning a small improvement to SCP task. If you are copying > large files they take time. And it would be nice to see that > something is happening if a transfer takes long (in quite normal > cases a transfer of one file can tak

Re: SSH tracking

2004-04-05 Thread Rami Ojares
I noticed that the attachment somehow disappeared from my posting so here it is inline: Index: ScpToMessage.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/optional/ssh/ScpT oMessage.java,v retrieving rev

SSH tracking

2004-04-05 Thread Rami Ojares
Hi,   I was planning a small improvement to SCP task. If you are copying large files they take time. And it would be nice to see that something is happening if a transfer takes long (in quite normal cases a transfer of one file can take minutes sometimes even hours).   So here is a small pat