cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs/optional/sitraka ClassFileTest.java

2003-10-28 Thread antoine
antoine 2003/10/28 01:33:41 Modified:src/testcases/org/apache/tools/ant/taskdefs/optional/sitraka Tag: ANT_16_BRANCH ClassFileTest.java Log: Merge from HEAD Revision ChangesPath No revision No revision 1.7.2.

cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs/optional/sitraka ClassFileTest.java

2003-10-28 Thread antoine
antoine 2003/10/28 01:29:50 Modified:src/testcases/org/apache/tools/ant/taskdefs/optional/sitraka ClassFileTest.java Log: Simplify assertion in testcase (remark of Martin Kruithof) Revision ChangesPath 1.9 +2 -6 ant/src/testcases/org/ap

AW: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs/optional/sitraka ClassFileTest.java

2003-10-27 Thread Antoine Levy-Lambert
You are right Martijn, I will revert to your original patch. Cheers, Antoine -Ursprungliche Nachricht- Von: Martijn Kruithof [mailto:[EMAIL PROTECTED] Gesendet: Montag, 27. Oktober 2003 20:05 An: Ant Developers List Betreff: Re: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs

Re: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs/optional/sitraka ClassFileTest.java

2003-10-27 Thread Martijn Kruithof
Hi I also verified my patch against jdk 1.4.2 and IBM jdk 1.4.1 and am sure it keeps running. The numerals in assertHasMethod are lower limits according to the test case, so the if is not necessery and furthermore makes in necessary to also verify again against jdk 1.3 and ibm jdk's. Furthermore

cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs/optional/sitraka ClassFileTest.java

2003-10-27 Thread antoine
antoine 2003/10/27 10:32:13 Modified:src/testcases/org/apache/tools/ant/taskdefs/optional/sitraka Tag: ANT_16_BRANCH ClassFileTest.java Log: Merge from HEAD Prevent ClassFileTest from failing under JDK 1.2 PR: 23919 Submitted by: Martijn Kruithof Re

cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs/optional/sitraka ClassFileTest.java

2003-10-27 Thread antoine
antoine 2003/10/27 10:29:53 Modified:src/testcases/org/apache/tools/ant/taskdefs/optional/sitraka ClassFileTest.java Log: Make org.apache.tools.ant.taskdefs.optional.sitraka.ClassFileTest pass under JDK 1.2 PR: 23919 Submitted by: Martijn Kruithof (ant a