Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/34
Hi @ansell , in my last commit I've pushed a coupe of (hopefully)
satisfying additions, namely
* removal of open module from CLI (meaning that, by default the open
extractor is not executed by
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/34
Hi @ansell yes this is a separate module however currently it always builds
with CLI module. I'm going to push an update which disables the module tests by
default.
---
If your project is set up for
Github user ansell commented on the issue:
https://github.com/apache/any23/pull/34
Is it an optional plugin in the current setup to avoid having users need to
load it if they have minimal memory available. I haven't had time to look
through it, but I see there is a new openie module.
Github user ansell commented on the issue:
https://github.com/apache/any23/pull/34
My main objections before were about the larger memory requirements for
default use and not being able to run the tests without OOM in my mid-range
development machine.
---
If your project is set up
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/34
Will commit within next day or so if there are no objections.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/34
Hi @ansell I finally got around to addressing your comments. Just to
refresh your memory, use of FileOutputStream (as oppose to
ByteArrayOutputStream) within the OpenExtractorTest.java logic is more
Github user ansell commented on the issue:
https://github.com/apache/any23/pull/34
Tests failed for me with OOM:
```
[INFO] Compiling 1 source file to
/home/mint/gitrepos/any23/openie/target/test-classes
[INFO]
[INFO] --- maven-surefire-plugin:2.19.1:test
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/34
PING... anyone that is able to provide a review? Would be very much
appreciated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/34
Hi @ansell this is now fixed... if you could pull the code and let me know
how you get on it would be appreciated.
After a good bit of debugging I discovered that some erroneous
``
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/34
Yep your right. Bang on the money. I'll update the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ansell commented on the issue:
https://github.com/apache/any23/pull/34
The cli module may need the new module added as a dependency to pull it
onto the classpath. Strangely enough, it appears as though none of the other
plugins are cli dependencies.
---
If your project
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/34
OK so implementing ExtractorPlugin is not necessary... none of the other
plugins use this logic.
I'm trying to get it working via cli appassembler script however no joy yet.
---
If your project
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/34
@ansell is it necessary to put this new module into ```plugins``` and have
the new extractor implement
13 matches
Mail list logo
