[GitHub] apex-core pull request #364: APEXCORE-448 Made operator name available in op...

2016-08-03 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-core/pull/364#discussion_r73448985 --- Diff: engine/src/test/java/com/datatorrent/stram/engine/OperatorContextTest.java --- @@ -0,0 +1,112 @@ +/** + * Licensed to the Apache

[GitHub] apex-core pull request #364: APEXCORE-448 Made operator name available in op...

2016-08-03 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-core/pull/364#discussion_r73444389 --- Diff: engine/src/test/java/com/datatorrent/stram/engine/OperatorContextTest.java --- @@ -0,0 +1,112 @@ +/** + * Licensed to the Apache

[GitHub] apex-core pull request #364: APEXCORE-448 Made operator name available in op...

2016-08-03 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-core/pull/364#discussion_r7334 --- Diff: engine/src/test/java/com/datatorrent/stram/engine/OperatorContextTest.java --- @@ -0,0 +1,112 @@ +/** + * Licensed to the Apache

[GitHub] apex-core pull request #364: APEXCORE-448 Made operator name available in op...

2016-08-03 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-core/pull/364#discussion_r73444164 --- Diff: engine/src/test/java/com/datatorrent/stram/engine/OperatorContextTest.java --- @@ -0,0 +1,112 @@ +/** + * Licensed to the Apache

[GitHub] apex-core pull request #364: APEXCORE-448 Made operator name available in op...

2016-08-03 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-core/pull/364#discussion_r73439463 --- Diff: engine/src/test/java/com/datatorrent/stram/engine/OperatorContextTest.java --- @@ -0,0 +1,99 @@ +/** + * Licensed to the Apache

[GitHub] apex-core pull request #358: *Review only* [APEXCORE-482]Make the downstream...

2016-07-27 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-core/pull/358#discussion_r7249 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/physical/PTOperator.java --- @@ -85,6 +85,7 @@ private static final long

[GitHub] apex-core pull request #358: *Review only* [APEXCORE-482]Make the downstream...

2016-07-27 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-core/pull/358#discussion_r72490248 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/physical/PTOperator.java --- @@ -85,6 +85,7 @@ private static final long

[GitHub] apex-core pull request #350: APEXCORE-222 Purging the stale data present in ...

2016-07-15 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-core/pull/350#discussion_r71005395 --- Diff: bufferserver/src/main/java/com/datatorrent/bufferserver/internal/DataList.java --- @@ -176,21 +176,20 @@ public void reset

[GitHub] apex-core pull request #357: APEXCORE-488: Issues in SSL communication with ...

2016-07-14 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-core/pull/357#discussion_r70900700 --- Diff: engine/src/main/java/com/datatorrent/stram/util/ConfigUtils.java --- @@ -68,15 +68,30 @@ public static String getRMUsername(Configuration

[GitHub] apex-core pull request #357: APEXCORE-488: Issues in SSL communication with ...

2016-07-14 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-core/pull/357#discussion_r70900320 --- Diff: engine/src/main/java/com/datatorrent/stram/util/ConfigUtils.java --- @@ -68,15 +68,30 @@ public static String getRMUsername(Configuration

[GitHub] apex-core pull request #357: APEXCORE-488: Issues in SSL communication with ...

2016-07-14 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-core/pull/357#discussion_r70899542 --- Diff: engine/src/main/java/com/datatorrent/stram/util/ConfigUtils.java --- @@ -68,15 +68,30 @@ public static String getRMUsername(Configuration

[GitHub] apex-core pull request #357: APEXCORE-488: Issues in SSL communication with ...

2016-07-14 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-core/pull/357#discussion_r70848037 --- Diff: engine/src/main/java/com/datatorrent/stram/util/ConfigUtils.java --- @@ -68,15 +68,30 @@ public static String getRMUsername(Configuration

[GitHub] apex-core pull request #357: APEXCORE-488: Issues in SSL communication with ...

2016-07-13 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-core/pull/357#discussion_r70740902 --- Diff: engine/src/main/java/com/datatorrent/stram/StreamingAppMasterService.java --- @@ -614,7 +615,16 @@ protected void serviceStart() throws

[GitHub] apex-core pull request #357: APEXCORE-488: Issues in SSL communication with ...

2016-07-13 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-core/pull/357#discussion_r70728942 --- Diff: engine/src/main/java/com/datatorrent/stram/StreamingAppMasterService.java --- @@ -614,7 +615,16 @@ protected void serviceStart() throws

[GitHub] apex-core pull request #351: APEXCORE-405 Common API to launch on local mode...

2016-07-08 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-core/pull/351#discussion_r70111000 --- Diff: api/src/main/java/com/datatorrent/api/ClusterMode.java --- @@ -0,0 +1,67 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] apex-core issue #352: Fixed the typo while determing the pending deploy for ...

2016-07-07 Thread gauravgopi123
Github user gauravgopi123 commented on the issue: https://github.com/apache/apex-core/pull/352 @tweise : Please review it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] apex-core pull request #352: Fixed the typo while determing the pending depl...

2016-07-07 Thread gauravgopi123
GitHub user gauravgopi123 opened a pull request: https://github.com/apache/apex-core/pull/352 Fixed the typo while determing the pending deploy for strongly connec… …ted group You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] apex-core pull request #351: APEXCORE-405 Common API to launch on local mode...

2016-07-07 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-core/pull/351#discussion_r70019363 --- Diff: api/src/main/java/com/datatorrent/api/ClusterMode.java --- @@ -0,0 +1,67 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] apex-core issue #351: APEXCORE-405 Common API to launch on local mode or clu...

2016-07-07 Thread gauravgopi123
Github user gauravgopi123 commented on the issue: https://github.com/apache/apex-core/pull/351 @PramodSSImmaneni : Can you please point me to the discussion on dev for this? I don't see anything on Jira for this.. --- If your project is set up for it, you can reply to this emai

[GitHub] apex-core pull request #351: APEXCORE-405 Common API to launch on local mode...

2016-07-07 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-core/pull/351#discussion_r69962835 --- Diff: api/src/main/java/com/datatorrent/api/Attribute.java --- @@ -146,6 +146,8 @@ public String toString() Set, Object>> en

[GitHub] apex-core pull request #351: APEXCORE-405 Common API to launch on local mode...

2016-07-07 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-core/pull/351#discussion_r69962030 --- Diff: api/src/main/java/com/datatorrent/api/LocalMode.java --- @@ -18,34 +18,46 @@ */ package com.datatorrent.api; -import

[GitHub] apex-core pull request #351: APEXCORE-405 Common API to launch on local mode...

2016-07-07 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-core/pull/351#discussion_r69961409 --- Diff: api/src/main/java/com/datatorrent/api/ClusterMode.java --- @@ -0,0 +1,67 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] apex-malhar pull request #316: High-level WindowedStream API (Review only)

2016-06-09 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/316#discussion_r66509417 --- Diff: stream/src/main/java/org/apache/apex/malhar/stream/api/CompositeStreamTransform.java --- @@ -0,0 +1,29 @@ +/** + * Licensed to

[GitHub] apex-malhar pull request #316: High-level WindowedStream API (Review only)

2016-06-09 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/316#discussion_r66507851 --- Diff: stream/pom.xml --- @@ -94,6 +94,18 @@ cglib 3.2.1 + + + org.twitter4j

[GitHub] apex-malhar pull request #315: [APEXMALHAR-2102] Support clone partitioner

2016-06-08 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/315#discussion_r66322765 --- Diff: library/src/test/java/com/datatorrent/lib/partitioner/ClonePartitionerTest.java --- @@ -0,0 +1,314 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #315: [APEXMALHAR-2102] Support clone partitioner

2016-06-08 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/315#discussion_r66322272 --- Diff: library/src/test/java/com/datatorrent/lib/partitioner/ClonePartitionerTest.java --- @@ -0,0 +1,314 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #315: [APEXMALHAR-2102] Support clone partitioner

2016-06-08 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/315#discussion_r66321951 --- Diff: library/src/main/java/com/datatorrent/lib/partitioner/ClonePartitioner.java --- @@ -0,0 +1,144 @@ +/** + * Licensed to the

[GitHub] apex-malhar pull request #315: [APEXMALHAR-2102] Support clone partitioner

2016-06-08 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/315#discussion_r66321909 --- Diff: library/src/test/java/com/datatorrent/lib/partitioner/ClonePartitionerTest.java --- @@ -0,0 +1,314 @@ +/** + * Licensed to the

[GitHub] incubator-apex-core pull request #339: APEXCORE-466 #resolve improved loggin...

2016-06-03 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/339#discussion_r65788854 --- Diff: engine/src/main/java/com/datatorrent/stram/client/RecordingsAgent.java --- @@ -640,7 +640,7 @@ public JSONObject process

[GitHub] incubator-apex-core pull request #339: APEXCORE-466 #resolve improved loggin...

2016-06-02 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/339#discussion_r65602951 --- Diff: engine/src/main/java/com/datatorrent/stram/client/EventsAgent.java --- @@ -125,7 +125,7 @@ protected EventsIndexLine

[GitHub] incubator-apex-core pull request #339: APEXCORE-466 #resolve improved loggin...

2016-06-01 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/339#discussion_r65485278 --- Diff: engine/src/main/java/com/datatorrent/stram/client/EventsAgent.java --- @@ -125,7 +125,7 @@ protected EventsIndexLine

[GitHub] incubator-apex-malhar pull request #307: [APEXMALHAR-2106] Support multiple ...

2016-06-01 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/307#discussion_r65472797 --- Diff: library/src/main/java/com/datatorrent/lib/stream/StreamMerger.java --- @@ -41,35 +47,57 @@ @Stateless public class

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2066 JdbcPolling,idempotent,p...

2016-05-31 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/282#discussion_r65282201 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -0,0 +1,652

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2066 JdbcPolling,idempotent,p...

2016-05-31 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/282#discussion_r65245106 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -0,0 +1,652

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2103 Fixed the scanner issue ...

2016-05-31 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/300#discussion_r65244972 --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java --- @@ -375,11 +374,18 @@ public void run

[GitHub] incubator-apex-core pull request: [APEXCORE-332][WIP] Improve part...

2016-05-27 Thread gauravgopi123
Github user gauravgopi123 commented on the pull request: https://github.com/apache/incubator-apex-core/pull/347#issuecomment-41796 @ilganeli : As @tweise mentioned please start a discussion on @dev --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2103 Fixed the scan...

2016-05-27 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/300#discussion_r64951249 --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java --- @@ -375,11 +374,11 @@ public void run

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2103 Fixed the scan...

2016-05-27 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/300#discussion_r64950338 --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java --- @@ -375,11 +374,11 @@ public void run

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2096: Add property ...

2016-05-26 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/287#discussion_r64840077 --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/FSInputModule.java --- @@ -59,6 +58,9 @@ private long blockSize

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2096: Add property ...

2016-05-26 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/287#discussion_r64828460 --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/AbstractFileSplitter.java --- @@ -53,6 +53,7 @@ * This is a threshold

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2096: Add property ...

2016-05-26 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/287#discussion_r64828487 --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/FSInputModule.java --- @@ -59,6 +58,9 @@ private long blockSize

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2066 JdbcPolling,id...

2016-05-26 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/282#discussion_r64826973 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -0,0 +1,652

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2066 JdbcPolling,id...

2016-05-26 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/282#discussion_r64826243 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -0,0 +1,652

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2066 JdbcPolling,id...

2016-05-26 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/282#discussion_r64825921 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -0,0 +1,652

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2066 JdbcPolling,id...

2016-05-26 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/282#discussion_r64825894 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -0,0 +1,652

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2066 JdbcPolling,id...

2016-05-26 Thread gauravgopi123
Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/282#discussion_r64825830 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java --- @@ -0,0 +1,652

[GitHub] incubator-apex-core pull request: [APEXCORE-146] Add ClonePartitio...

2016-05-26 Thread gauravgopi123
Github user gauravgopi123 commented on the pull request: https://github.com/apache/incubator-apex-core/pull/344#issuecomment-221932938 Should this be part of malhar under https://github.com/apache/incubator-apex-malhar/tree/master/library/src/main/java/com/datatorrent/lib/partitioner