[GitHub] apex-malhar pull request #393: APEXMALHAR-2207 implemented proper assertions...

2016-08-30 Thread shubham-pathak22
GitHub user shubham-pathak22 opened a pull request: https://github.com/apache/apex-malhar/pull/393 APEXMALHAR-2207 implemented proper assertions. Removed console outputs @yogidevendra Please review. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] apex-malhar pull request #376: APEXMALHAR-2152 - FSLoader fixed length suppo...

2016-08-23 Thread shubham-pathak22
GitHub user shubham-pathak22 opened a pull request: https://github.com/apache/apex-malhar/pull/376 APEXMALHAR-2152 - FSLoader fixed length support You can merge this pull request into a Git repository by running: $ git pull https://github.com/shubham-pathak22/incubator-apex

[GitHub] apex-malhar pull request #364: APEXMALHAR-2151 delimited file format support...

2016-08-15 Thread shubham-pathak22
Github user shubham-pathak22 closed the pull request at: https://github.com/apache/apex-malhar/pull/364 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] apex-malhar pull request #364: APEXMALHAR-2151 delimited file format support...

2016-08-10 Thread shubham-pathak22
GitHub user shubham-pathak22 opened a pull request: https://github.com/apache/apex-malhar/pull/364 APEXMALHAR-2151 delimited file format support to FSLoader @chinmaykolhatkar Could you please review You can merge this pull request into a Git repository by running: $ git pull

[GitHub] apex-malhar pull request #357: APEXMALHAR-2167 json formatter

2016-07-29 Thread shubham-pathak22
GitHub user shubham-pathak22 opened a pull request: https://github.com/apache/apex-malhar/pull/357 APEXMALHAR-2167 json formatter Please review. Refers to https://github.com/DataTorrent/examples/tree/master/tutorials/parser You can merge this pull request into a Git

[GitHub] apex-malhar pull request #348: APEXMALHAR-2157 Json formatter improvements

2016-07-25 Thread shubham-pathak22
Github user shubham-pathak22 commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/348#discussion_r72049665 --- Diff: library/src/test/java/com/datatorrent/lib/formatter/JsonFormatterTest.java --- @@ -182,14 +173,19 @@ public void

[GitHub] apex-malhar pull request #348: APEXMALHAR-2157 Json formatter improvements

2016-07-25 Thread shubham-pathak22
Github user shubham-pathak22 commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/348#discussion_r72048793 --- Diff: library/src/main/java/com/datatorrent/lib/formatter/Formatter.java --- @@ -48,6 +49,13 @@ { protected transient Class

[GitHub] apex-malhar pull request #348: APEXMALHAR-2157 Json formatter improvements

2016-07-21 Thread shubham-pathak22
Github user shubham-pathak22 commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/348#discussion_r71666431 --- Diff: library/src/test/java/com/datatorrent/lib/formatter/JsonFormatterTest.java --- @@ -35,6 +35,8 @@ import

[GitHub] apex-malhar pull request #348: APEXMALHAR-2157 Json formatter improvements

2016-07-20 Thread shubham-pathak22
GitHub user shubham-pathak22 opened a pull request: https://github.com/apache/apex-malhar/pull/348 APEXMALHAR-2157 Json formatter improvements You can merge this pull request into a Git repository by running: $ git pull https://github.com/shubham-pathak22/incubator-apex

[GitHub] apex-malhar pull request #306: APEXMALHAR-2105 enhancing CSV formatter to re...

2016-06-08 Thread shubham-pathak22
Github user shubham-pathak22 closed the pull request at: https://github.com/apache/apex-malhar/pull/306 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-apex-core pull request #338: APEXCORE-463 : fixed condition to all...

2016-06-02 Thread shubham-pathak22
Github user shubham-pathak22 commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/338#discussion_r65658413 --- Diff: engine/src/main/java/com/datatorrent/stram/webapp/TypeGraph.java --- @@ -355,7 +356,8 @@ public int size

[GitHub] incubator-apex-malhar pull request: Apexmalhar 2033 streaming pars...

2016-05-27 Thread shubham-pathak22
Github user shubham-pathak22 commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/288#discussion_r64864410 --- Diff: contrib/src/main/java/com/datatorrent/contrib/parser/StreamingJsonParser.java --- @@ -0,0 +1,431

[GitHub] incubator-apex-malhar pull request: Apexmalhar 2033 streaming pars...

2016-05-25 Thread shubham-pathak22
Github user shubham-pathak22 commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/288#discussion_r64560543 --- Diff: contrib/src/main/java/com/datatorrent/contrib/parser/StreamingJsonParser.java --- @@ -0,0 +1,451

[GitHub] incubator-apex-malhar pull request: Apexmalhar 2033 streaming pars...

2016-05-25 Thread shubham-pathak22
Github user shubham-pathak22 commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/288#discussion_r64559707 --- Diff: contrib/src/main/java/com/datatorrent/contrib/parser/StreamingJsonParser.java --- @@ -0,0 +1,451

[GitHub] incubator-apex-malhar pull request: Apexmalhar 2033 streaming pars...

2016-05-25 Thread shubham-pathak22
Github user shubham-pathak22 commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/288#discussion_r64557644 --- Diff: contrib/src/test/java/com/datatorrent/contrib/parser/StreamingJsonParserTest.java --- @@ -0,0 +1,269

[GitHub] incubator-apex-malhar pull request: Apexmalhar 2033 streaming pars...

2016-05-25 Thread shubham-pathak22
Github user shubham-pathak22 commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/288#discussion_r64539994 --- Diff: contrib/src/main/java/com/datatorrent/contrib/parser/StreamingJsonParser.java --- @@ -0,0 +1,451