Github user asfgit closed the pull request at:
https://github.com/apache/apex-core/pull/360
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user sandeshh commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r73610135
--- Diff: engine/src/test/java/com/datatorrent/stram/cli/ApexCliTest.java
---
@@ -180,4 +188,40 @@ public void
testLaunchAppPackagePrecedenceWithConfigPa
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r73609127
--- Diff: engine/src/test/java/com/datatorrent/stram/cli/ApexCliTest.java
---
@@ -180,4 +188,40 @@ public void
testLaunchAppPackagePrecedenceWithConfig
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r73589696
--- Diff: engine/src/test/java/com/datatorrent/stram/cli/ApexCliTest.java
---
@@ -180,4 +188,40 @@ public void
testLaunchAppPackagePrecedenceWithConfig
Github user sandeshh commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r73586551
--- Diff: engine/src/test/java/com/datatorrent/stram/cli/ApexCliTest.java
---
@@ -53,16 +56,16 @@
private static File configFile;
-
Github user sandeshh commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r73584686
--- Diff: engine/src/test/java/com/datatorrent/stram/cli/ApexCliTest.java
---
@@ -180,4 +188,40 @@ public void
testLaunchAppPackagePrecedenceWithConfigPa
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r73583092
--- Diff: engine/src/test/java/com/datatorrent/stram/cli/ApexCliTest.java
---
@@ -53,16 +56,16 @@
private static File configFile;
Github user sandeshh commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r73582926
--- Diff: engine/src/test/java/com/datatorrent/stram/cli/ApexCliTest.java
---
@@ -180,4 +188,40 @@ public void
testLaunchAppPackagePrecedenceWithConfigPa
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r73582886
--- Diff:
engine/src/test/resources/testConfigPackage/testConfigPackageSrc/app/testApp.json
---
@@ -0,0 +1 @@
+{"displayName":"testApp","attributes
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r73582758
--- Diff:
engine/src/test/resources/testAppPackage/mydtapp/src/main/resources/com/example/mydtapp/Application/ExtRes.html
---
@@ -0,0 +1,21 @@
+
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r73582496
--- Diff: engine/src/test/java/com/datatorrent/stram/cli/ApexCliTest.java
---
@@ -126,10 +130,14 @@ public void testLaunchAppPackagePropertyPrecedence()
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r73582122
--- Diff: engine/src/test/java/com/datatorrent/stram/cli/ApexCliTest.java
---
@@ -103,8 +107,8 @@ public static void finished()
public void testL
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r73581887
--- Diff: engine/src/test/java/com/datatorrent/stram/cli/ApexCliTest.java
---
@@ -180,4 +188,40 @@ public void
testLaunchAppPackagePrecedenceWithConfig
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r73581539
--- Diff: engine/src/test/java/com/datatorrent/stram/cli/ApexCliTest.java
---
@@ -180,4 +188,40 @@ public void
testLaunchAppPackagePrecedenceWithConfig
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r73581176
--- Diff: engine/src/main/java/com/datatorrent/stram/client/AppPackage.java
---
@@ -49,6 +49,8 @@
import net.lingala.zip4j.exception.ZipException;
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r73580877
--- Diff:
apex-conf-archetype/src/main/resources/archetype-resources/pom.xml ---
@@ -25,6 +25,7 @@
1..
classpath/*
fi
Github user sandeshh commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r72671495
--- Diff:
engine/src/test/resources/testOperators/src/main/java/org/apache/apex/test/RandomGen.java
---
@@ -16,24 +16,44 @@
* specific language gov
Github user sandeshh commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r72670932
--- Diff:
engine/src/test/java/com/datatorrent/stram/support/StramTestSupport.java ---
@@ -157,21 +160,42 @@ public static void
waitForWindowComplete(Ope
Github user sandeshh commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r72670717
--- Diff:
engine/src/main/java/com/datatorrent/stram/client/ConfigPackage.java ---
@@ -71,6 +72,7 @@
private final Map properties = new TreeM
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r72670575
--- Diff:
engine/src/test/resources/testOperators/src/main/java/org/apache/apex/test/DevNull.java
---
@@ -16,25 +16,19 @@
* specific language gov
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r72670501
--- Diff:
engine/src/test/resources/testOperators/src/main/java/org/apache/apex/test/RandomGen.java
---
@@ -16,24 +16,44 @@
* specific language g
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r72670240
--- Diff:
engine/src/test/java/com/datatorrent/stram/support/StramTestSupport.java ---
@@ -157,21 +160,42 @@ public static void
waitForWindowComplete(O
Github user sandeshh commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r72670234
--- Diff: engine/src/main/java/com/datatorrent/stram/cli/ApexCli.java ---
@@ -3850,6 +3908,9 @@ private Option add(Option opt)
final Option exactM
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r72670019
--- Diff:
engine/src/main/java/com/datatorrent/stram/client/ConfigPackage.java ---
@@ -71,6 +72,7 @@
private final Map properties = new Tre
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r72669919
--- Diff: engine/src/main/java/com/datatorrent/stram/cli/ApexCli.java ---
@@ -3850,6 +3908,9 @@ private Option add(Option opt)
final Option exac
25 matches
Mail list logo
