Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/342
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/342#discussion_r64679977
--- Diff: engine/src/main/java/com/datatorrent/stram/webapp/TypeGraph.java
---
@@ -827,6 +827,16 @@ private void getAllPortsWithAncestor(Ty
Github user siyuanh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/342#discussion_r64671776
--- Diff: engine/src/main/java/com/datatorrent/stram/webapp/TypeGraph.java
---
@@ -827,6 +827,16 @@ private void getAllPortsWithAncestor(TypeGrap
Github user siyuanh commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/342#issuecomment-221739828
@bhupeshchawda looks good to me, once you rename the method, I'll merge it
---
If your project is set up for it, you can reply to this email and have your
GitHub user bhupeshchawda reopened a pull request:
https://github.com/apache/incubator-apex-core/pull/342
APEXCORE-461: Fixed hiding of overridden ports. Refactored unit test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bhupe
Github user bhupeshchawda closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/342
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user bhupeshchawda commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/342#issuecomment-221436622
@siyuanh Please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
GitHub user bhupeshchawda opened a pull request:
https://github.com/apache/incubator-apex-core/pull/342
APEXCORE-461: Fixed hiding of overridden ports. Refactored unit test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bhupesh
