Handling wildcard imports

2015-10-01 Thread Chandni Singh
The discussion about wildcards spun off from a previous discussion about imports. Summarizing the options: 1. Currently with checkstyle we cannot validate that a wildcard import was inserted only if the count is greater than a specified number. However in the settings we provide we can specify t

[GitHub] incubator-apex-malhar pull request: - MLHR-1864 #resolve #comment ...

2015-10-01 Thread davidyan74
Github user davidyan74 commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/45#discussion_r40991914 --- Diff: library/src/main/java/com/datatorrent/lib/appdata/query/QueryManagerAsynchronous.java --- @@ -123,7 +124,7 @@ public void endWindo

[GitHub] incubator-apex-malhar pull request: - MLHR-1864 #resolve #comment ...

2015-10-01 Thread ilooner
GitHub user ilooner opened a pull request: https://github.com/apache/incubator-apex-malhar/pull/46 - MLHR-1864 #resolve #comment Made adding a query to a queue atomic - Fixed race condition where a query could be accessed from the queue and then have its countdown decremented. Yo

[GitHub] incubator-apex-malhar pull request: - MLHR-1864 #resolve #comment ...

2015-10-01 Thread ilooner
GitHub user ilooner opened a pull request: https://github.com/apache/incubator-apex-malhar/pull/45 - MLHR-1864 #resolve #comment Made adding a query to a queue atomic - Fixed race condition where a query could be accessed from the queue and then have its countdown decremented. Yo

[GitHub] incubator-apex-core pull request: App not launching with HA and se...

2015-10-01 Thread PramodSSImmaneni
Github user PramodSSImmaneni commented on the pull request: https://github.com/apache/incubator-apex-core/pull/83#issuecomment-144897743 Will squash it. I didn't try by setting the connect address property. If you have a setup handy it would be great if you could give it a try. Thanks

[GitHub] incubator-apex-core pull request: App not launching with HA and se...

2015-10-01 Thread vrozov
Github user vrozov commented on the pull request: https://github.com/apache/incubator-apex-core/pull/83#issuecomment-144895491 Looks good, can you squash commits. Do you want me to test the fix on the HA Secure cluster or this was already done? --- If your project is set up for it, y

Re: Import order enforced by checkstyle

2015-10-01 Thread David Yan
I'm +1 on disallowing wildcards altogether. On Thu, Oct 1, 2015 at 6:22 PM, Chandni Singh wrote: > Please note the standard checkstyle configurations of sun and google > completely avoid wildcard imports and the rationale is : > > > Rationale: Importing all classes from a package or static membe

Re: Import order enforced by checkstyle

2015-10-01 Thread Chandni Singh
Please note the standard checkstyle configurations of sun and google completely avoid wildcard imports and the rationale is : Rationale: Importing all classes from a package or static members from a class leads to tight coupling between packages or classes and might lead to problems when a new ve

Re: Import order enforced by checkstyle

2015-10-01 Thread Chandni Singh
Currently with checkstyle we cannot validate that a wildcard import was inserted only if the count is greater than a specified number. However in the settings we provide we can specify this number only for regular imports not static imports. I think it should be 10, i.e., if class count is great

Re: Import order enforced by checkstyle

2015-10-01 Thread David Yan
Chandni, What's the policy of using wildcards? David On Thu, Oct 1, 2015 at 5:25 PM, Chandni Singh wrote: > Yes we do. > > On Thu, Oct 1, 2015 at 4:57 PM, Siyuan Hua wrote: > > > Do we allow wildcard import? > > > > On Wed, Sep 30, 2015 at 10:37 PM, Priyanka Gugale < > > priya...@datatorrent.

Re: dynamic application properties proposal

2015-10-01 Thread Amol Kekre
The issue comes up when property has to be changed in multiple operators, logical or physical. Since it does not matter if this is triggered by an input adapter or any parent of this operators, stram can pick common ancestor. Property change commands (operator id, prop name, prop val) can be in

Re: Import order enforced by checkstyle

2015-10-01 Thread Chandni Singh
Yes we do. On Thu, Oct 1, 2015 at 4:57 PM, Siyuan Hua wrote: > Do we allow wildcard import? > > On Wed, Sep 30, 2015 at 10:37 PM, Priyanka Gugale < > priya...@datatorrent.com> > wrote: > > > Mine also +1 for single commit for import order changes. > > Doing this there will be clear distinction o

Re: Import order enforced by checkstyle

2015-10-01 Thread Siyuan Hua
Do we allow wildcard import? On Wed, Sep 30, 2015 at 10:37 PM, Priyanka Gugale wrote: > Mine also +1 for single commit for import order changes. > Doing this there will be clear distinction of changes made for formatting > (import order change) and actual code change. > > On Thu, Oct 1, 2015 at

Re: Test failure on malhar/devel-3

2015-10-01 Thread Chandni Singh
https://malhar.atlassian.net/browse/MLHR-1852 Tim had created the ticket. Will look into it. On Thu, Oct 1, 2015 at 2:12 PM, Sandesh Hegde wrote: > I also saw the same error, created a fresh clone and building it failed > for me. > > Thanks > Sandesh > > On Thu, Oct 1, 2015 at 1:49 PM Munagala

Test failure on malhar/devel-3

2015-10-01 Thread Sandesh Hegde
I also saw the same error, created a fresh clone and building it failed for me. Thanks Sandesh On Thu, Oct 1, 2015 at 1:49 PM Munagala Ramanath wrote: > FileSplitterInputTest.testRecoveryOfPartialFile:408 New file expected:<1> > but was:<0> > > Ram > >

Re: dynamic application properties proposal

2015-10-01 Thread Gaurav Gupta
Pramod, The new special property change tuple will be send to all the Operators and all the operators will have to check if the property change is applicable for it. Although such requests may be very few, but is there a way to optimize it? Thanks - Gaurav > On Sep 28, 2015, at 3:44 PM, Pramod

Re: [malhar-users] HDFS file read

2015-10-01 Thread Chandni Singh
Hey Krishna, Can you please try split("\u0001") if you are trying to split on the unicode character. Thanks, Chandni On Thu, Oct 1, 2015 at 8:50 AM, Munagala Ramanath wrote: > Couple of questions: > > (a) Why do you have a backslash in the separator string ? Are you trying to > split on the no

Re: [malhar-users] HDFS file read

2015-10-01 Thread Munagala Ramanath
Couple of questions: (a) Why do you have a backslash in the separator string ? Are you trying to split on the non-printable ASCII code 1 ? (b) The first line does not have the sub-string "001", so what are you getting as the result of split() call and what are you expecting ? (c) The second line d

Re: [malhar-users] HDFS file read

2015-10-01 Thread kalikrishna . pasumarti
Hi, Below you can find the row which we are trying to split. 1855003555798283MFRAPS1858-11-17F1302015-08-282015-08-28 18:29:44CHG9003REGCA201508P Thanks, krishna On Thursday, October 1, 2015 at 1:33:12 PM UTC+5:30, Ashwin Chandra Putta wrote: > > Krishna, > > Can you paste the line you are tr

Re: [malhar-users] HDFS file read

2015-10-01 Thread kalikrishna . pasumarti
Hi, I am using AbstactFileInputOperator to read HDFS file and once i get the first row and am trying to separate it by finding \001. There it is unable to identify that separator. Below you can have the reference code. String temp=br.readLine(); *if*(temp!=*null*){ ar

[GitHub] incubator-apex-core pull request: App not launching with HA and se...

2015-10-01 Thread PramodSSImmaneni
Github user PramodSSImmaneni commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/83#discussion_r40901158 --- Diff: engine/src/main/java/com/datatorrent/stram/client/StramClientUtils.java --- @@ -284,6 +279,20 @@ public void addRMDelegationTok

Re: [malhar-users] HDFS file read

2015-10-01 Thread Ashwin Chandra Putta
Krishna, Can you paste the line you are trying to split? Regards, Ashwin. On Oct 1, 2015 12:22 AM, wrote: > Hi, > > I am using AbstactFileInputOperator to read HDFS file and once i get the > first row and am trying to separate it by finding \001. There it is unable > to identify that separator.