Re: Renaming Idempotent Storage Manager

Name WindowDataLogger sounds like class is responsible for plain dump log of data(at window level). It does not reflect if it used for recovery or any other purpose. WindowDataManager is more generic name which does not reflect any specific purpose. It can do any umbrella activity required to mana

RE: [VOTE] PPMC change

As one of the initial active folks on the list of committers (and thus a PPMC member) I'm acutely aware that I'm potentially forfeiting a seat on the PMC by voting for this proposal. However, I fundamentally believe that the folks who should have a meaningful influence on a project's direction

[GitHub] incubator-apex-malhar pull request: MLHR-1910 #resolve #comment fi...

GitHub user chandnisingh opened a pull request: https://github.com/apache/incubator-apex-malhar/pull/102 MLHR-1910 #resolve #comment fixed style violations and warnings in Bl… …ock Reader classes You can merge this pull request into a Git repository by running: $ git pull h

[GitHub] incubator-apex-malhar pull request: MLHR-1906 #resolve #comment Sn...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/100#discussion_r45027429 --- Diff: library/src/test/java/com/datatorrent/lib/appdata/snapshot/AppDataSnapshotServerTagsSupportTest.java --- @@ -0,0 +1,67 @@ +pack

[GitHub] incubator-apex-malhar pull request: MLHR-1906 #resolve #comment Sn...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/100#discussion_r45027363 --- Diff: library/src/main/java/com/datatorrent/lib/appdata/schemas/SnapshotSchema.java --- @@ -246,6 +247,26 @@ private void initialize() th

[GitHub] incubator-apex-malhar pull request: Release 3.2

Github user asfgit closed the pull request at: https://github.com/apache/incubator-apex-malhar/pull/101 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-apex-malhar pull request: Release 3.2

GitHub user tweise opened a pull request: https://github.com/apache/incubator-apex-malhar/pull/101 Release 3.2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/tweise/incubator-apex-malhar release-3.2 Alternatively you can review

Re: Renaming Idempotent Storage Manager

--- I like 1 and 3 but prefer 3 because we may not always be logging data but saving meta-data. -- We are saving data or meta-data somewhere for recovery. WindowDataManager doesn't reflect that data or meta-data is persisted. Chandni On Mon, Nov 16, 2015 at 10:12 PM, Yogi Devendra wrote: > +1

Re: [VOTE] PPMC change

-0. This is effectively asking a bunch of the initial committers to resign from the PPMC. That said, this is not a -1 from me as it is up to the initial folks who came in as part of the Incubation proposal to decide on how they would like to move forward and foster the community for the longer t

Re: Renaming Idempotent Storage Manager

+1 for WindowDataManager On 17 November 2015 at 10:58, Sandeep Deshmukh wrote: > +1 for 3. > On 17 Nov 2015 07:25, "Timothy Farkas" wrote: > > > +1 for 1 > > > > On Mon, Nov 16, 2015 at 2:35 PM, Pramod Immaneni > > > wrote: > > > > > I like 1 and 3 but prefer 3 because we may not always be log

Re: [VOTE] PPMC change

Hi, +0 from me. I think this is going to be more work and make it harder for you to graduate. But that being said it’s up to the PPMC/PMC on how they want to run things. Thanks, Justin

[GitHub] incubator-apex-malhar pull request: MLHR-1906 #resolve #comment Sn...

Github user brightchen commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/100#discussion_r45023991 --- Diff: library/src/test/java/com/datatorrent/lib/appdata/snapshot/AppDataSnapshotServerTagsSupportTest.java --- @@ -0,0 +1,67 @@ +p

[GitHub] incubator-apex-core pull request: Providing a way for operator to ...

Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/168#discussion_r45023930 --- Diff: api/src/main/java/com/datatorrent/api/Context.java --- @@ -301,6 +301,12 @@ */ int getId(); +/**

[GitHub] incubator-apex-malhar pull request: MLHR-1906 #resolve #comment Sn...

Github user brightchen commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/100#discussion_r45023863 --- Diff: library/src/main/java/com/datatorrent/lib/appdata/schemas/SnapshotSchema.java --- @@ -246,6 +247,26 @@ private void initialize()

[GitHub] incubator-apex-core pull request: Providing a way for operator to ...

Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/168#discussion_r45023776 --- Diff: engine/src/main/java/com/datatorrent/stram/engine/Node.java --- @@ -600,6 +605,19 @@ public void activate() CHECKPOINT_

Re: Renaming Idempotent Storage Manager

+1 for 3. On 17 Nov 2015 07:25, "Timothy Farkas" wrote: > +1 for 1 > > On Mon, Nov 16, 2015 at 2:35 PM, Pramod Immaneni > wrote: > > > I like 1 and 3 but prefer 3 because we may not always be logging data but > > saving meta-data. > > > > On Mon, Nov 16, 2015 at 2:30 PM, Chandni Singh > > wrote

[RESULT][VOTE] Apache Apex Malhar Release 3.2.0-incubating (RC2)

The vote passes with 3, +1 binding votes from IPMC members and no -1s: Justin Mclean Hitesh Shah Alan Gates Thanks for voting, we will proceed with the release activities. Thomas On Mon, Nov 16, 2015 at 5:57 PM, Sasha Parfenov wrote: > +1. Carried over from Apache Apex (incubating) dev list

Re: Apex Podling Name Search

What is the next step here? On Mon, Nov 9, 2015 at 2:31 AM, Gaurav Gupta wrote: > I created the JIRA > https://issues.apache.org/jira/browse/PODLINGNAMESEARCH-90 < > https://issues.apache.org/jira/browse/PODLINGNAMESEARCH-90> and updated > it. Amol can you please share trademark search results s

Re: Incubator vote for Malhar release

--> On Mon, Nov 16, 2015 at 7:53 PM, Ted Dunning wrote: > On Tue, Nov 17, 2015 at 9:47 AM, Thomas Weise > wrote: > > > Thanks. We have 3 binding votes so we are good with this release. > > > > Also wanted to know if the voting can be expedited for future releases > (now > > that we have the bas

Re: Incubator vote for Malhar release

On Tue, Nov 17, 2015 at 9:47 AM, Thomas Weise wrote: > Thanks. We have 3 binding votes so we are good with this release. > > Also wanted to know if the voting can be expedited for future releases (now > that we have the basic release kinks worked out). > The issue with this is that expediting t

Re: Incubator vote for Malhar release

On Mon, Nov 16, 2015 at 6:46 PM, Justin Mclean wrote: > > > Thanks. We have 3 binding votes so we are good with this release. > > I can only see two binding votes over on the incubator mailing list. Did I > missing one binding vote? > > We have +1 from Justin, Hitesh, Alan - I'm going to post the

Proposal for Apex and Malhar Docs

Hello Apexers, I'd like to propose a process for creating, storing, updating, and displaying documentation of the apex and malhar projects. *## Goals* The goals for docs that I had in mind are: - Versioned with the code base - Easy to contribute to by anyone - Displayed on apex.incubator.apache

Re: Incubator vote for Malhar release

Hi > Thanks. We have 3 binding votes so we are good with this release. I can only see two binding votes over on the incubator mailing list. Did I missing one binding vote? > Also wanted to know if the voting can be expedited for future releases (now > that we have the basic release kinks worked

[GitHub] incubator-apex-malhar pull request: MLHR-1906 #resolve #comment Sn...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/100#discussion_r45016459 --- Diff: library/src/test/java/com/datatorrent/lib/appdata/snapshot/AppDataSnapshotServerTagsSupportTest.java --- @@ -0,0 +1,67 @@ +pack

[GitHub] incubator-apex-malhar pull request: MLHR-1906 #resolve #comment Sn...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/100#discussion_r45016325 --- Diff: library/src/main/java/com/datatorrent/lib/appdata/schemas/SnapshotSchema.java --- @@ -246,6 +247,26 @@ private void initialize() th

[GitHub] incubator-apex-malhar pull request: MLHR-1906 #resolve #comment Sn...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/100#discussion_r45016300 --- Diff: library/src/main/java/com/datatorrent/lib/appdata/schemas/SnapshotSchema.java --- @@ -246,6 +247,26 @@ private void initialize() th

[GitHub] incubator-apex-malhar pull request: MLHR-1906 #resolve #comment Sn...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/100#discussion_r45016265 --- Diff: library/src/main/java/com/datatorrent/lib/appdata/schemas/SnapshotSchema.java --- @@ -246,6 +247,26 @@ private void initialize() th

[GitHub] incubator-apex-core pull request: APEX-227 #resolve #comment left ...

Github user chandnisingh commented on the pull request: https://github.com/apache/incubator-apex-core/pull/169#issuecomment-157248453 @davidyan74 Please review and merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-apex-core pull request: Providing a way for operator to ...

Github user chandnisingh commented on the pull request: https://github.com/apache/incubator-apex-core/pull/168#issuecomment-157247094 @PramodSSImmaneni Could you please point me to the discussion for this change or any documentation related to this. I am interested in knowing the use

[GitHub] incubator-apex-core pull request: APEX-227 #resolve #comment left ...

GitHub user chandnisingh opened a pull request: https://github.com/apache/incubator-apex-core/pull/169 APEX-227 #resolve #comment left curly brace on next line for anonymou… …s class You can merge this pull request into a Git repository by running: $ git pull https://github

Re: Renaming Idempotent Storage Manager

+1 for 1 On Mon, Nov 16, 2015 at 2:35 PM, Pramod Immaneni wrote: > I like 1 and 3 but prefer 3 because we may not always be logging data but > saving meta-data. > > On Mon, Nov 16, 2015 at 2:30 PM, Chandni Singh > wrote: > > > Currently going by Java code, the IdempotentStorageManager extends >

[GitHub] incubator-apex-malhar pull request: MLHR-1906 #resolve #comment Sn...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/100#discussion_r45012931 --- Diff: library/src/test/resources/satisfactionRatingSnapshotSchema_test.json --- @@ -0,0 +1,8 @@ +{ + "values": [ +{"name"

[GitHub] incubator-apex-malhar pull request: MLHR-1906 #resolve #comment Sn...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/100#discussion_r45012902 --- Diff: library/src/test/java/com/datatorrent/lib/appdata/snapshot/AppDataSnapshotServerTagsSupportTest.java --- @@ -0,0 +1,67 @@ +pack

[GitHub] incubator-apex-core pull request: Providing a way for operator to ...

Github user ilooner commented on the pull request: https://github.com/apache/incubator-apex-core/pull/168#issuecomment-157234462 I also have some concerns for the intended usage of this interface. I think to determine the tuples obtained from the last streaming window before a checkp

[GitHub] incubator-apex-core pull request: Providing a way for operator to ...

Github user ilooner commented on the pull request: https://github.com/apache/incubator-apex-core/pull/168#issuecomment-157227774 Also fault tolerance was not considered. windowsFromCheckpoint must be stored as part of the checkpoint state like applicationWindowCount and restored to t

[GitHub] incubator-apex-core pull request: Providing a way for operator to ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/168#discussion_r45010069 --- Diff: engine/src/main/java/com/datatorrent/stram/engine/Node.java --- @@ -600,6 +605,19 @@ public void activate() CHECKPOINT_WINDOW

[GitHub] incubator-apex-core pull request: Providing a way for operator to ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/168#discussion_r45008466 --- Diff: api/src/main/java/com/datatorrent/api/Context.java --- @@ -301,6 +301,12 @@ */ int getId(); +/** +

Re: Incubator vote for Malhar release

Thanks. We have 3 binding votes so we are good with this release. Also wanted to know if the voting can be expedited for future releases (now that we have the basic release kinks worked out). Is there an option to combine PPMC and IPMC vote and let everyone vote on general@ ? In the end, that's t

Re: Incubator vote for Malhar release

Hi, > For clarification, can the incubator vote be declared passed when 3 IPMC > members have already voted +1 on the PPMC thread? Or do we need a repeat of > at least 3 +1 binding votes? There’s been differing advice given on this. IMO it's best to do a repeat as another IPMC member may find an

[GitHub] incubator-apex-core pull request: Providing a way for operator to ...

Github user davidyan74 commented on the pull request: https://github.com/apache/incubator-apex-core/pull/168#issuecomment-157219514 I think it looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] incubator-apex-malhar pull request: MLHR-1906 #resolve #comment Sn...

GitHub user brightchen opened a pull request: https://github.com/apache/incubator-apex-malhar/pull/100 MLHR-1906 #resolve #comment Snapshot Server support tags You can merge this pull request into a Git repository by running: $ git pull https://github.com/brightchen/incubator-

Re: Incubator vote for Malhar release

For clarification, can the incubator vote be declared passed when 3 IPMC members have already voted +1 on the PPMC thread? Or do we need a repeat of at least 3 +1 binding votes? Thanks, Thomas On Sun, Nov 15, 2015 at 9:02 PM, Justin Mclean wrote: > Hi, > > While I appreciate the enthusiasm if

[GitHub] incubator-apex-site pull request: Added support for multiple indiv...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-apex-site/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] incubator-apex-core pull request: - APEX-129 #resolve #comment Fix...

Github user chandnisingh commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/166#discussion_r44999231 --- Diff: engine/src/main/java/com/datatorrent/stram/engine/InputNode.java --- @@ -145,7 +148,7 @@ else if (PROCESSING_MODE == ProcessingMo

[GitHub] incubator-apex-core pull request: - APEX-129 #resolve #comment Fix...

Github user PramodSSImmaneni commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/166#discussion_r44997624 --- Diff: engine/src/main/java/com/datatorrent/stram/engine/InputNode.java --- @@ -145,7 +148,7 @@ else if (PROCESSING_MODE == Processi

[GitHub] incubator-apex-core pull request: - APEX-129 #resolve #comment Fix...

Github user 243826 commented on the pull request: https://github.com/apache/incubator-apex-core/pull/166#issuecomment-157196138 No, please go ahead. On Nov 16, 2015 2:11 PM, "Pramod Immaneni" wrote: > @243826 do you have any other comments? I w

Re: Renaming Idempotent Storage Manager

I like 1 and 3 but prefer 3 because we may not always be logging data but saving meta-data. On Mon, Nov 16, 2015 at 2:30 PM, Chandni Singh wrote: > Currently going by Java code, the IdempotentStorageManager extends > StorageAgent which is why WindowStorageAgent came up. > It does delete data til

Re: Renaming Idempotent Storage Manager

Currently going by Java code, the IdempotentStorageManager extends StorageAgent which is why WindowStorageAgent came up. It does delete data till window that gets committed. These are some options which I have came across. 1. WindowDataLogger 2. WindowStorageAgent 3. WindowDataManager My vote i

Re: Renaming Idempotent Storage Manager

It would still to manage the log isn't it, like clearing out data corresponding to committed windows. On Mon, Nov 16, 2015 at 2:11 PM, Thomas Weise wrote: > The underlying abstraction is a log. Why shouldn't the name reflect that? > Or is there anything added that makes it a "manager" or "agent"

[GitHub] incubator-apex-core pull request: - APEX-129 #resolve #comment Fix...

Github user PramodSSImmaneni commented on the pull request: https://github.com/apache/incubator-apex-core/pull/166#issuecomment-157187728 @243826 do you have any other comments? I was planning on doing the final review. --- If your project is set up for it, you can reply to this ema

Re: Renaming Idempotent Storage Manager

The underlying abstraction is a log. Why shouldn't the name reflect that? Or is there anything added that makes it a "manager" or "agent"? On Mon, Nov 16, 2015 at 2:01 PM, Chandni Singh wrote: > WindowStorageAgent was another suggestion as IdempotentStorageManager > extends StorageAgent. > If n

[GitHub] incubator-apex-core pull request: - APEX-263 Fixed case where doub...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-apex-core/pull/167 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

Re: Renaming Idempotent Storage Manager

WindowStorageAgent was another suggestion as IdempotentStorageManager extends StorageAgent. If no one has any objection will call it that. Chandni On Sun, Nov 15, 2015 at 8:07 PM, Chandni Singh wrote: > Hi, > > @Sandeep Will deprecate old IdempotentStorageManager. This will be a copy > of the o

[GitHub] incubator-apex-core pull request: Providing a way for operator to ...

Github user PramodSSImmaneni commented on the pull request: https://github.com/apache/incubator-apex-core/pull/168#issuecomment-157156709 @tweise @ilooner @davidyan74 please see --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-apex-core pull request: Introduce Abstract and Forwardin...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/162#discussion_r44970614 --- Diff: engine/src/main/java/com/datatorrent/stram/stream/BufferServerSubscriber.java --- @@ -242,6 +243,21 @@ public long getByteCount(boolean

Re: [VOTE] PPMC change

-0. I think this is a bad idea, as I've tried to make clear. I'm not clear on the rules of this vote and don't want to veto it, so I'm voting -0 rather than -1. Alan. Thomas Weise November 15, 2015 at 16:22 Hi, Please vote on the following Apache Apex (incubating)

[GitHub] incubator-apex-core pull request: - APEX-263 Fixed case where doub...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/167#discussion_r44966554 --- Diff: engine/src/test/java/com/datatorrent/stram/engine/GenericNodeTest.java --- @@ -296,4 +323,67 @@ public void run() Assert.asser

Support new major kafka release 0.9.0

I will be working on rewriting the kafka input operator. Here is the ticket https://malhar.atlassian.net/browse/MLHR-1904 Here is some comments on the ticket The RC2 is out here https://people.apache.org/~junrao/kafka-0.9.0.0-candidate2/ We will keep most features of the old input operator but

Re: [VOTE] PPMC change

+1 (binding) Thanks, Sasha On Monday, November 16, 2015, Jessica Wang wrote: > +1 (binding) > > On Mon, Nov 16, 2015 at 10:16 AM, Isha Arkatkar > > wrote: > > > +1 (binding) > > > > Thanks, > > Isha > > > > On Mon, Nov 16, 2015 at 9:14 AM, David Yan > wrote: > > > > > +1 (binding) > > > > > >

Re: [VOTE] PPMC change

+1 (binding) On Mon, Nov 16, 2015 at 10:16 AM, Isha Arkatkar wrote: > +1 (binding) > > Thanks, > Isha > > On Mon, Nov 16, 2015 at 9:14 AM, David Yan wrote: > > > +1 (binding) > > > > On Mon, Nov 16, 2015 at 8:06 AM, Pramod Immaneni > > > wrote: > > > > > +1 (binding) > > > > > > On Mon, Nov 16

Re: [VOTE] PPMC change

+1 (binding) Thanks, Isha On Mon, Nov 16, 2015 at 9:14 AM, David Yan wrote: > +1 (binding) > > On Mon, Nov 16, 2015 at 8:06 AM, Pramod Immaneni > wrote: > > > +1 (binding) > > > > On Mon, Nov 16, 2015 at 4:51 AM, P. Taylor Goetz > > wrote: > > > > > +1 (binding) > > > > > > -Taylor > > > > >

[GitHub] incubator-apex-core pull request: Introduce Abstract and Forwardin...

Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/162#discussion_r44958755 --- Diff: engine/src/main/java/com/datatorrent/stram/stream/BufferServerSubscriber.java --- @@ -242,6 +243,21 @@ public long getByteCount(

[GitHub] incubator-apex-core pull request: - APEX-263 Fixed case where doub...

Github user PramodSSImmaneni commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/167#discussion_r44957610 --- Diff: engine/src/test/java/com/datatorrent/stram/engine/GenericNodeTest.java --- @@ -296,4 +323,67 @@ public void run() Ass

[GitHub] incubator-apex-core pull request: Introduce Abstract and Forwardin...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/162#discussion_r44956255 --- Diff: engine/src/main/java/com/datatorrent/stram/stream/BufferServerSubscriber.java --- @@ -242,6 +243,21 @@ public long getByteCount(boolean

[GitHub] incubator-apex-malhar pull request: MLHR-1852 #comment temporary i...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-apex-malhar/pull/99 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

Re: [VOTE] PPMC change

+1 (binding) On Mon, Nov 16, 2015 at 8:06 AM, Pramod Immaneni wrote: > +1 (binding) > > On Mon, Nov 16, 2015 at 4:51 AM, P. Taylor Goetz > wrote: > > > +1 (binding) > > > > -Taylor > > > > > On Nov 15, 2015, at 7:22 PM, Thomas Weise wrote: > > > > > > Hi, > > > > > > Please vote on the followi

[GitHub] incubator-apex-core pull request: Introduce Abstract and Forwardin...

Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/162#discussion_r44948463 --- Diff: engine/src/main/java/com/datatorrent/stram/stream/BufferServerSubscriber.java --- @@ -242,6 +243,21 @@ public long getByteCount(

[GitHub] incubator-apex-core pull request: Introduce Abstract and Forwardin...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/162#discussion_r44947533 --- Diff: engine/src/main/java/com/datatorrent/stram/stream/BufferServerSubscriber.java --- @@ -242,6 +243,21 @@ public long getByteCount(boolean

Re: [VOTE] PPMC change

+1 (binding) On Mon, Nov 16, 2015 at 8:34 AM, Siyuan Hua wrote: > +1 (binding) > > On Mon, Nov 16, 2015 at 8:31 AM, Bright Chen > wrote: > > > +1 (binding) > > > > Thanks > > Bright > > > > > On Nov 16, 2015, at 8:06 AM, Pramod Immaneni > > wrote: > > > > > > +1 (binding) > > > > > > On Mon, N

Re: [VOTE] PPMC change

+1 (binding) On Mon, Nov 16, 2015 at 8:31 AM, Bright Chen wrote: > +1 (binding) > > Thanks > Bright > > > On Nov 16, 2015, at 8:06 AM, Pramod Immaneni > wrote: > > > > +1 (binding) > > > > On Mon, Nov 16, 2015 at 4:51 AM, P. Taylor Goetz > wrote: > > > >> +1 (binding) > >> > >> -Taylor > >> >

[GitHub] incubator-apex-core pull request: Introduce Abstract and Forwardin...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/162#discussion_r44946066 --- Diff: engine/src/main/java/com/datatorrent/stram/engine/AbstractReservoir.java --- @@ -0,0 +1,340 @@ +/** + * Licensed to the Apache S

[GitHub] incubator-apex-core pull request: Introduce Abstract and Forwardin...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/162#discussion_r44946039 --- Diff: engine/src/main/java/com/datatorrent/stram/stream/InlineStream.java --- @@ -90,7 +91,7 @@ public void put(Object tuple) @Override

Re: [VOTE] PPMC change

+1 (binding) Thanks Bright > On Nov 16, 2015, at 8:06 AM, Pramod Immaneni wrote: > > +1 (binding) > > On Mon, Nov 16, 2015 at 4:51 AM, P. Taylor Goetz wrote: > >> +1 (binding) >> >> -Taylor >> >>> On Nov 15, 2015, at 7:22 PM, Thomas Weise wrote: >>> >>> Hi, >>> >>> Please vote on the fo

[GitHub] incubator-apex-core pull request: Introduce Abstract and Forwardin...

Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/162#discussion_r44943593 --- Diff: engine/src/main/java/com/datatorrent/stram/engine/Reservoir.java --- @@ -23,20 +23,26 @@ * * @since 0.3.2 */

Re: Using queue for publisher to buffer server communication (APEX-259)

That's a very clear explanation of how the Buffer Server fits into the rest of the system. Thanks Vlad. Ram On Sun, Nov 15, 2015 at 7:18 PM, Vlad Rozov wrote: > Small correction or clarification - two (or more) operators that are > connected by a stream that is neither THREAD_LOCAL or CONTAINER

Re: [VOTE] PPMC change

+1 (binding) On Mon, Nov 16, 2015 at 4:51 AM, P. Taylor Goetz wrote: > +1 (binding) > > -Taylor > > > On Nov 15, 2015, at 7:22 PM, Thomas Weise wrote: > > > > Hi, > > > > Please vote on the following Apache Apex (incubating) PPMC membership > > change. Please refer to discussion at: > > > > > h

[GitHub] incubator-apex-core pull request: Introduce Abstract and Forwardin...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/162#discussion_r44938812 --- Diff: engine/src/main/java/com/datatorrent/stram/engine/Reservoir.java --- @@ -23,20 +23,26 @@ * * @since 0.3.2 */ -publ

Re: [VOTE] PPMC change

+1 (binding) -Taylor > On Nov 15, 2015, at 7:22 PM, Thomas Weise wrote: > > Hi, > > Please vote on the following Apache Apex (incubating) PPMC membership > change. Please refer to discussion at: > > https://mail-archives.apache.org/mod_mbox/incubator-apex-dev/201511.mbox/%3CCAKJfLDOw7on_VLJxA

Re: [VOTE] PPMC change

+1 (binding) Thanks. -Bhupesh On 16-Nov-2015 4:07 pm, "Priyanka Gugale" wrote: > +1 (binding) > > -Priyanka > > On Mon, Nov 16, 2015 at 3:59 PM, Sandeep Deshmukh > > wrote: > > > +1 (binding) > > > > Regards, > > Sandeep > > > > On Mon, Nov 16, 2015 at 3:54 PM, Pradeep A. Dalvi < > apa...@prade

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r44910840 --- Diff: api/src/main/java/com/datatorrent/api/DefaultInputPort.java --- @@ -79,14 +79,15 @@ public void put(T tuple) process(tuple

Re: [VOTE] PPMC change

+1 (binding) -Priyanka On Mon, Nov 16, 2015 at 3:59 PM, Sandeep Deshmukh wrote: > +1 (binding) > > Regards, > Sandeep > > On Mon, Nov 16, 2015 at 3:54 PM, Pradeep A. Dalvi > > wrote: > > > +1 (binding) > > > > On Mon, Nov 16, 2015 at 1:58 PM, Tushar Gosavi > > wrote: > > > > > +1 (binding) >

Re: [VOTE] PPMC change

+1 (binding) Regards, Sandeep On Mon, Nov 16, 2015 at 3:54 PM, Pradeep A. Dalvi wrote: > +1 (binding) > > On Mon, Nov 16, 2015 at 1:58 PM, Tushar Gosavi > wrote: > > > +1 (binding) > > > > - Tushar. > > > > On Mon, Nov 16, 2015 at 12:21 PM, Aniruddha Thombare < > > anirud...@datatorrent.com> w

Re: [VOTE] PPMC change

+1 (binding) On Mon, Nov 16, 2015 at 1:58 PM, Tushar Gosavi wrote: > +1 (binding) > > - Tushar. > > On Mon, Nov 16, 2015 at 12:21 PM, Aniruddha Thombare < > anirud...@datatorrent.com> wrote: > > > +1 (binding) > > > > Thanks, > > > > > > Aniruddha > > > > On Mon, Nov 16, 2015 at 12:03 PM, Atri S

Re: [VOTE] PPMC change

+1 (binding) ~ Chinmay. On Mon, Nov 16, 2015 at 1:58 PM, Tushar Gosavi wrote: > +1 (binding) > > - Tushar. > > On Mon, Nov 16, 2015 at 12:21 PM, Aniruddha Thombare < > anirud...@datatorrent.com> wrote: > > > +1 (binding) > > > > Thanks, > > > > > > Aniruddha > > > > On Mon, Nov 16, 2015 at 12:

Re: [VOTE] PPMC change

+1 (binding) - Tushar. On Mon, Nov 16, 2015 at 12:21 PM, Aniruddha Thombare < anirud...@datatorrent.com> wrote: > +1 (binding) > > Thanks, > > > Aniruddha > > On Mon, Nov 16, 2015 at 12:03 PM, Atri Sharma wrote: > > > +1 (binding) > > On 16 Nov 2015 11:59, "Yogi Devendra" wrote: > > > > > +1 (

[GitHub] incubator-apex-core pull request: Introduce Abstract and Forwardin...

Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/162#discussion_r44896738 --- Diff: engine/src/main/java/com/datatorrent/stram/stream/BufferServerSubscriber.java --- @@ -242,6 +243,21 @@ public long getByteCount(

[GitHub] incubator-apex-core pull request: Introduce Abstract and Forwardin...

Github user tweise commented on the pull request: https://github.com/apache/incubator-apex-core/pull/162#issuecomment-156951850 +1 for abstracting the queue. Did you run the benchmark with this change? As discussed, the extra level of indirection in DefaultReservoir should not add si

[GitHub] incubator-apex-core pull request: Introduce Abstract and Forwardin...

Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/162#discussion_r44896500 --- Diff: engine/src/main/java/com/datatorrent/stram/engine/Reservoir.java --- @@ -23,20 +23,26 @@ * * @since 0.3.2 */

[GitHub] incubator-apex-core pull request: Introduce Abstract and Forwardin...

Github user tweise commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/162#discussion_r44896265 --- Diff: engine/src/main/java/com/datatorrent/stram/stream/BufferServerSubscriber.java --- @@ -242,6 +243,21 @@ public long getByteCount(boolean