Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/187#discussion_r48933859
--- Diff: api/src/main/java/com/datatorrent/api/Operator.java ---
@@ -224,6 +224,7 @@ public String toString()
* Operators must impl
[
https://issues.apache.org/jira/browse/APEXMALHAR-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Siyuan Hua updated APEXMALHAR-1956:
---
Fix Version/s: 3.3.0
> Concrete generic Implementation of Kafka Output Operator with auto
[
https://issues.apache.org/jira/browse/APEXMALHAR-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Siyuan Hua resolved APEXMALHAR-1956.
Resolution: Fixed
> Concrete generic Implementation of Kafka Output Operator with auto
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-malhar/pull/148
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user tweise opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/161
Fix JIRA instructions in README.md
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tweise/incubator-apex-malhar devel-3
Alternati
[
https://issues.apache.org/jira/browse/APEXMALHAR-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085092#comment-15085092
]
ASF GitHub Bot commented on APEXMALHAR-1964:
GitHub user chandnisingh ope
GitHub user chandnisingh opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/160
APEXMALHAR-1964 #resolve #comment reduced the severity of line lengthâ¦
⦠check
You can merge this pull request into a Git repository by running:
$ git pull https://githu
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/187#discussion_r48931757
--- Diff: engine/src/main/java/com/datatorrent/stram/engine/Node.java ---
@@ -485,6 +485,10 @@ protected void deactivateSinks()
Github user chinmaykolhatkar commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/187#discussion_r48931576
--- Diff: engine/src/main/java/com/datatorrent/stram/engine/Node.java ---
@@ -485,6 +485,10 @@ protected void deactivateSinks()
Github user tweise commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/187#issuecomment-169249166
Please squash once remaining comments are addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/187#discussion_r48931445
--- Diff: engine/src/main/java/com/datatorrent/stram/engine/Node.java ---
@@ -485,6 +485,10 @@ protected void deactivateSinks()
void c
Siyuan,
Would pramod's pull request help here? (
https://github.com/apache/incubator-apex-core/pull/187)
This way one gets a chance to decide what should be checkpointed and what
should not be.
Thanks,
Chinmay.
~ Chinmay.
On Wed, Jan 6, 2016 at 2:40 AM, Timothy Farkas wrote:
> A small exten
It's a completely new operator that should probably see some feedback and
go into next release.
On Tue, Jan 5, 2016 at 10:29 PM, Chinmay Kolhatkar
wrote:
> Can this also be considered?
>
> https://issues.apache.org/jira/browse/APEXMALHAR-1963
>
> I've created a pull request for this.
>
>
> ~ Ch
Can this also be considered?
https://issues.apache.org/jira/browse/APEXMALHAR-1963
I've created a pull request for this.
~ Chinmay.
On Wed, Jan 6, 2016 at 11:55 AM, Chandni Singh
wrote:
> Can this go in as well? Will make the change by tonight.
>
> https://issues.apache.org/jira/browse/APEXM
[
https://issues.apache.org/jira/browse/APEXMALHAR-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Weise updated APEXMALHAR-1964:
-
Fix Version/s: 3.3.0
> [Checkstyle] Reduce the severity of line length check
> --
Can this go in as well? Will make the change by tonight.
https://issues.apache.org/jira/browse/APEXMALHAR-1964
On Tue, Jan 5, 2016 at 10:15 PM, Thomas Weise
wrote:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20APEXMALHAR%20AND%20fixVersion%20%3D%203.3.0%20ORDER%20BY%20status%20
Chandni Singh created APEXMALHAR-1964:
-
Summary: [Checkstyle] Reduce the severity of line length check
Key: APEXMALHAR-1964
URL: https://issues.apache.org/jira/browse/APEXMALHAR-1964
Project: Apach
[
https://issues.apache.org/jira/browse/APEXMALHAR-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Weise resolved APEXMALHAR-1945.
--
Resolution: Fixed
> Upgrade the version of japicmp to 0.6.2
> -
[
https://issues.apache.org/jira/browse/APEXMALHAR-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Weise updated APEXMALHAR-1945:
-
Fix Version/s: 3.3.0
> Upgrade the version of japicmp to 0.6.2
>
[
https://issues.apache.org/jira/browse/APEXMALHAR-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085039#comment-15085039
]
ASF GitHub Bot commented on APEXMALHAR-1945:
Github user asfgit closed th
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-malhar/pull/158
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
https://issues.apache.org/jira/issues/?jql=project%20%3D%20APEXMALHAR%20AND%20fixVersion%20%3D%203.3.0%20ORDER%20BY%20status%20ASC
APEXMALHAR-1904 should be done tomorrow
APEXMALHAR-1892 will be looked at during the release process
APEXMALHAR-1948 push to next release?
APEXMALHAR-1950 rebase P
[
https://issues.apache.org/jira/browse/APEXMALHAR-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085034#comment-15085034
]
Thomas Weise commented on APEXMALHAR-1948:
--
Can this be moved out of 3.3.0 ?
Github user chaithu14 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/148#discussion_r48929077
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/kafka/POJOKafkaOutputOperator.java
---
@@ -0,0 +1,266 @@
+/**
+ * Licensed
Github user chaithu14 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/148#discussion_r48929079
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/kafka/POJOKafkaOutputOperator.java
---
@@ -0,0 +1,266 @@
+/**
+ * Licensed
Should the zookeeper setting in kafka consumer be annotated non-null?
Github user sandeshh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/159#discussion_r48920790
--- Diff:
library/src/main/java/com/datatorrent/lib/iteration/nDelayOperator.java ---
@@ -0,0 +1,186 @@
+/**
+ * Licensed to the Apac
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/134#discussion_r48920130
--- Diff:
kafka/src/main/java/org/apache/apex/malhar/kafka/KafkaConsumerWrapper.java ---
@@ -0,0 +1,326 @@
+/**
+ * Licensed to the Apa
Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/159#discussion_r48918818
--- Diff:
library/src/main/java/com/datatorrent/lib/iteration/nDelayOperator.java ---
@@ -0,0 +1,186 @@
+/**
+ * Licensed to
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/159#discussion_r48918635
--- Diff:
library/src/main/java/com/datatorrent/lib/iteration/nDelayOperator.java ---
@@ -0,0 +1,186 @@
+/**
+ * Licensed to the
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/134#discussion_r48918567
--- Diff:
kafka/src/main/java/org/apache/apex/malhar/kafka/AbstractKafkaInputOperator.java
---
@@ -0,0 +1,500 @@
+/**
+ * Licensed to
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/159#discussion_r48918526
--- Diff:
library/src/main/java/com/datatorrent/lib/iteration/nDelayOperator.java ---
@@ -0,0 +1,186 @@
+/**
+ * Licensed to the
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/134#discussion_r48918465
--- Diff:
kafka/src/main/java/org/apache/apex/malhar/kafka/AbstractKafkaInputOperator.java
---
@@ -0,0 +1,500 @@
+/**
+ * Licensed to
GitHub user sandeshh opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/159
*Review only* N-DelayOperator
@davidyan74 please review.
This is the basic implementation of N-DelayOperator using WindowDataManager
for iteration.
You can merge this pull
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/134#discussion_r48918303
--- Diff:
kafka/src/main/java/org/apache/apex/malhar/kafka/AbstractKafkaInputOperator.java
---
@@ -0,0 +1,500 @@
+/**
+ * Licensed to
[
https://issues.apache.org/jira/browse/APEXMALHAR-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15084471#comment-15084471
]
ASF GitHub Bot commented on APEXMALHAR-1945:
GitHub user chandnisingh ope
GitHub user chandnisingh opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/158
APEXMALHAR-1945 #resolve #comment upgraded japi version to 0.6.2 and â¦
â¦added exclusion annotations
You can merge this pull request into a Git repository by running:
$ g
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/134#discussion_r48917236
--- Diff:
kafka/src/main/java/org/apache/apex/malhar/kafka/AbstractKafkaInputOperator.java
---
@@ -0,0 +1,500 @@
+/**
+ * Licensed to
[
https://issues.apache.org/jira/browse/APEXMALHAR-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15084439#comment-15084439
]
Chandni Singh commented on APEXMALHAR-1945:
---
The change we need was release
[
https://issues.apache.org/jira/browse/APEXMALHAR-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chandni Singh updated APEXMALHAR-1945:
--
Summary: Upgrade the version of japicmp to 0.6.2 (was: Upgrade the version
of japi
[
https://issues.apache.org/jira/browse/APEXCORE-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Siyuan Hua updated APEXCORE-288:
Fix Version/s: 3.3.0
> Add group id information to apex app package
>
[
https://issues.apache.org/jira/browse/APEXCORE-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Siyuan Hua resolved APEXCORE-288.
-
Resolution: Fixed
> Add group id information to apex app package
> -
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/188
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
[
https://issues.apache.org/jira/browse/APEXCORE-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15084032#comment-15084032
]
ASF GitHub Bot commented on APEXCORE-288:
-
Github user asfgit closed the pull re
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/156#discussion_r48900856
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/kafka/KafkaTopicOffsetManager.java
---
@@ -0,0 +1,487 @@
+/**
+ * Licen
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/156#discussion_r48900795
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/kafka/KafkaTopicOffsetManager.java
---
@@ -0,0 +1,487 @@
+/**
+ * Licen
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/156#discussion_r48898878
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/kafka/KafkaTopicOffsetManager.java
---
@@ -0,0 +1,487 @@
+/**
+ * Licen
[
https://issues.apache.org/jira/browse/APEXCORE-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083811#comment-15083811
]
ASF GitHub Bot commented on APEXCORE-60:
Github user davidyan74 commented on a di
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/185#discussion_r48897460
--- Diff:
engine/src/main/java/com/datatorrent/stram/engine/GenericNode.java ---
@@ -343,12 +389,15 @@ else if (!doCheckpoint) {
A small extension to the default Kryo field serializer could be made to
ignore fields with a particular annotation, as mentioned in the google
group below:
https://groups.google.com/forum/#!topic/kryo-users/nWSni1JVFKY
On Tue, Jan 5, 2016 at 11:08 AM, Gaurav Gupta
wrote:
> Siyuan,,,
>
> Questi
[
https://issues.apache.org/jira/browse/APEXCORE-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083782#comment-15083782
]
ASF GitHub Bot commented on APEXCORE-60:
Github user davidyan74 commented on a di
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/185#discussion_r48895909
--- Diff:
engine/src/main/java/com/datatorrent/stram/engine/GenericNode.java ---
@@ -364,29 +413,49 @@ else if (!doCheckpoint) {
[
https://issues.apache.org/jira/browse/APEXCORE-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083780#comment-15083780
]
ASF GitHub Bot commented on APEXCORE-60:
Github user davidyan74 commented on a di
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/185#discussion_r48895870
--- Diff:
engine/src/main/java/com/datatorrent/stram/engine/GenericNode.java ---
@@ -212,30 +225,60 @@ public final void run()
long s
[
https://issues.apache.org/jira/browse/APEXCORE-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083765#comment-15083765
]
ASF GitHub Bot commented on APEXCORE-288:
-
Github user tweise commented on the p
Github user tweise commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/188#issuecomment-169130533
Any update here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
No, the JIRA by default gets resolved without changing the assignee,
whether that is done via smart commit or manually.
On Tue, Jan 5, 2016 at 10:27 AM, Pramod Immaneni
wrote:
> Wouldn't that mark the JIRA as resolved by the committer as opposed to the
> contributor. It might be better to have t
Github user sandeshh closed the pull request at:
https://github.com/apache/incubator-apex-malhar/pull/136
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Siyuan,,,
Questions inline
Thanks
- Gaurav
> On Jan 5, 2016, at 11:02 AM, Siyuan Hua wrote:
>
> I can think of 3 use case:
> 1. I want to expose some runtime property through REST API (isAlive,
> isWaiting etc)
When you say runtime properties, do they not automatically qualify for being
tran
[
https://issues.apache.org/jira/browse/APEXCORE-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083565#comment-15083565
]
ASF GitHub Bot commented on APEXCORE-201:
-
Github user sandeshh commented on the
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/136#discussion_r48882086
--- Diff: demos/iteration/src/test/resources/log4j.properties ---
@@ -0,0 +1,40 @@
+#
+# Licensed to the Apache Software Foundati
Github user sandeshh commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/194#issuecomment-169098606
There are no new unit test cases. Is it not required ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
I can think of 3 use case:
1. I want to expose some runtime property through REST API (isAlive,
isWaiting etc)
2. Some properties need to be set only once at the beginning of the
application based on some condition (we don't need checkpoint such kind of
properties)
3. Some properties are calculated
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/131#discussion_r48880946
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/geode/GeodeStore.java ---
@@ -0,0 +1,308 @@
+/**
+ * Licensed to the Apa
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/131#discussion_r48880841
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/geode/GeodeStore.java ---
@@ -0,0 +1,308 @@
+/**
+ * Licensed to the Apa
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/131#discussion_r48881482
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/geode/GeodeStore.java ---
@@ -0,0 +1,308 @@
+/**
+ * Licensed to the Apa
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/131#discussion_r48881384
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/geode/GeodeStore.java ---
@@ -0,0 +1,308 @@
+/**
+ * Licensed to the Apa
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/131#discussion_r48881232
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/geode/GeodeStore.java ---
@@ -0,0 +1,308 @@
+/**
+ * Licensed to the Apa
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/131#discussion_r48881103
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/geode/GeodeStore.java ---
@@ -0,0 +1,308 @@
+/**
+ * Licensed to the Apa
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/131#discussion_r48881047
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/geode/GeodeStore.java ---
@@ -0,0 +1,308 @@
+/**
+ * Licensed to the Apa
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/131#discussion_r48880930
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/geode/GeodeStore.java ---
@@ -0,0 +1,308 @@
+/**
+ * Licensed to the Apa
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/131#discussion_r48880762
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/geode/GeodeStore.java ---
@@ -0,0 +1,308 @@
+/**
+ * Licensed to the Apa
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/131#discussion_r48880616
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/geode/GeodeStore.java ---
@@ -0,0 +1,308 @@
+/**
+ * Licensed to the Apa
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/131#discussion_r48880540
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/geode/GeodeStore.java ---
@@ -0,0 +1,308 @@
+/**
+ * Licensed to the Apa
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/131#discussion_r48879266
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/geode/GeodeStore.java ---
@@ -0,0 +1,308 @@
+/**
+ * Licensed to the Apa
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/154#discussion_r48877848
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/parser/CsvParser.java ---
@@ -62,247 +69,178 @@
* @since 3.2.0
*/
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/131#discussion_r48879075
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/geode/GeodeStore.java ---
@@ -0,0 +1,308 @@
+/**
+ * Licensed to the Apa
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/131#discussion_r48878896
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/geode/GeodeStore.java ---
@@ -0,0 +1,308 @@
+/**
+ * Licensed to the Apa
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/131#discussion_r48878685
--- Diff: contrib/pom.xml ---
@@ -623,5 +629,10 @@
super-csv-joda
2.3.1
+
+ com.gemston
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/154#discussion_r48877866
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/parser/CsvParser.java ---
@@ -62,247 +69,178 @@
* @since 3.2.0
*/
Wouldn't that mark the JIRA as resolved by the committer as opposed to the
contributor. It might be better to have the contributor mark it resolved
after the pull request is merged or after final confirmation from committer
after the reviews are done that everything is good to go.
On Tue, Jan 5, 2
Github user siyuanh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/134#discussion_r48877262
--- Diff:
kafka/src/main/java/org/apache/apex/malhar/kafka/AbstractKafkaInputOperator.java
---
@@ -0,0 +1,512 @@
+/**
+ * Licensed to
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/154#discussion_r48877003
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/parser/CsvParser.java ---
@@ -62,247 +69,178 @@
* @since 3.2.0
*/
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/154#discussion_r48877026
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/parser/CsvParser.java ---
@@ -62,247 +69,178 @@
* @since 3.2.0
*/
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/154#discussion_r48875936
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/parser/CsvParser.java ---
@@ -62,247 +69,178 @@
* @since 3.2.0
*/
Yes. Earlier that could be done with #resolve, now whoever does the git
push needs to go into JIRA and also push the button there.
On Tue, Jan 5, 2016 at 10:12 AM, Pramod Immaneni
wrote:
> Shouldn't the issue be marked resolved when the change is actually merged.
>
> On Tue, Jan 5, 2016 at 9:59
Github user siyuanh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/148#discussion_r48875875
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/kafka/POJOKafkaOutputOperator.java
---
@@ -0,0 +1,266 @@
+/**
+ * Licensed to
Github user siyuanh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/148#discussion_r48875794
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/kafka/POJOKafkaOutputOperator.java
---
@@ -0,0 +1,266 @@
+/**
+ * Licensed to
Shouldn't the issue be marked resolved when the change is actually merged.
On Tue, Jan 5, 2016 at 9:59 AM, Thomas Weise wrote:
> Friendly reminder, part of pushing pull requests is to take care of the
> associated JIRAs. The ASF system does not support the smart commits, so the
> person pushing
Github user siyuanh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/148#discussion_r48875491
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/kafka/POJOKafkaOutputOperator.java
---
@@ -0,0 +1,266 @@
+/**
+ * Licensed to
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/154#discussion_r48875507
--- Diff:
contrib/src/test/java/com/datatorrent/contrib/parser/CsvPOJOParserTest.java ---
@@ -20,169 +20,425 @@
import java.u
Github user siyuanh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/148#discussion_r48875436
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/kafka/POJOKafkaOutputOperator.java
---
@@ -0,0 +1,266 @@
+/**
+ * Licensed to
Github user siyuanh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/148#discussion_r48875311
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/kafka/POJOKafkaOutputOperator.java
---
@@ -0,0 +1,266 @@
+/**
+ * Licensed to
[
https://issues.apache.org/jira/browse/APEXMALHAR-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
gaurav gupta resolved APEXMALHAR-1958.
--
Resolution: Fixed
> Provide access to doneTuple field in AbstractReconciler for der
[
https://issues.apache.org/jira/browse/APEXMALHAR-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
gaurav gupta updated APEXMALHAR-1958:
-
Fix Version/s: 3.3.0
> Provide access to doneTuple field in AbstractReconciler for de
Friendly reminder, part of pushing pull requests is to take care of the
associated JIRAs. The ASF system does not support the smart commits, so the
person pushing the change will need to resolve the issue. Fix version needs
to be set.
http://apex.incubator.apache.org/contributing.html#merging-a-pu
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-malhar/pull/149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
[
https://issues.apache.org/jira/browse/APEXMALHAR-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083461#comment-15083461
]
ASF GitHub Bot commented on APEXMALHAR-1958:
Github user asfgit closed th
There was a discussion a while ago on why we don't want to add dependencies
to malhar-library unless they are broadly applicable to many operators.
Please review that discussion.
As for adding dependencies in general, please analyze the situation
carefully before moving ahead.. You will want to lo
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/156#discussion_r48872277
--- Diff: contrib/pom.xml ---
@@ -228,7 +228,7 @@
org.apache.kafka
kafka_2.10
- 0.8.1.1
--- End dif
1 - 100 of 114 matches
Mail list logo
