Github user 243826 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/173#issuecomment-159751791
It's not a good idea. It's micro optimization (of not a critical path) at
the cost of complicated implementation for developers and complicated us
Github user 243826 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/173#issuecomment-159417794
Vlad,
512k is undesirable and will cause other problems when exercised (I
discussed those in the email). The kind of code surgery needed with this
Github user 243826 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/173#issuecomment-159369549
-1 to this pull request due to the direction in which this is going
(discussed in the emails).
---
If your project is set up for it, you can reply to this
Github user 243826 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/175#issuecomment-158282682
when did the voting happen on this issue?
On Thu, Nov 19, 2015 at 3:55 PM, Vlad Rozov
wrote:
> This option lost in the community v
Github user 243826 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/166#issuecomment-157196138
No, please go ahead.
On Nov 16, 2015 2:11 PM, "Pramod Immaneni" wrote:
> @243826 <https://github.com/243826> do you have an
Github user 243826 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/166#discussion_r44608578
--- Diff: engine/src/main/java/com/datatorrent/stram/engine/InputNode.java
---
@@ -69,24 +69,27 @@ public final void run()
long
Github user 243826 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/166#issuecomment-155958018
can you add a unit test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user 243826 opened a pull request:
https://github.com/apache/incubator-apex-core/pull/164
clean the test app also during clean target
Cleanup the test app package compiled files during the clean phase.
You can merge this pull request into a Git repository by running
Github user 243826 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/164#issuecomment-155946700
@davidyan74 please review and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user 243826 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/162#issuecomment-155927418
Vlad, I have a bunch of questions and comments. Let's sync offline.
---
If your project is set up for it, you can reply to this email and have your
Github user 243826 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/160#issuecomment-155894028
There is one against master and one against devel-3.
On Nov 11, 2015 11:50 AM, "Chandni Singh" wrote:
> @243826 <https://g
Github user 243826 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/156#discussion_r44502992
--- Diff: apex_checks.xml ---
@@ -97,6 +97,10 @@
+
+
--- End diff --
Thanks and sorry
Github user 243826 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/153#discussion_r44502346
--- Diff: engine/src/main/scripts/dtcli ---
@@ -67,7 +67,7 @@ fi
if [ -f "$MVN_GENERATED_PATH" ]; then
# development l
Github user 243826 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/156#discussion_r44502182
--- Diff: apex_checks.xml ---
@@ -97,6 +97,10 @@
+
+
--- End diff --
what's the s
Github user 243826 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/156#discussion_r44502174
--- Diff: .idea/codeStyleSettings.xml ---
@@ -102,5 +104,4 @@
-
-
+
--- End diff --
end the
Github user 243826 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/162#issuecomment-155655936
not able to get infer the cause to do this, where are the details?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user 243826 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/94#discussion_r44461078
--- Diff:
contrib/src/test/java/com/datatorrent/contrib/romesyndication/RomeSyndicationOperatorTest.java
---
@@ -18,25 +18,18
GitHub user 243826 opened a pull request:
https://github.com/apache/incubator-apex-core/pull/161
let the checkstyle run during the default verify phase
@chandnisingh please review and merge.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user 243826 opened a pull request:
https://github.com/apache/incubator-apex-core/pull/160
let the checkstyle run during the default verify phase
@chandnisingh please review and merge.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user 243826 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/129#issuecomment-152325895
@ilganeli the coding guidelines are there to leave no room for different
interpretation of what commonly agreed best practice is. So before introducing
Github user 243826 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/129#issuecomment-152109331
Ilya, is splitting a method declaration part of our coding guidelines?
---
If your project is set up for it, you can reply to this email and have your
Github user 243826 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/145#issuecomment-152109783
Vlad, I thought the verbosity of the build was reduced to info? Travis log
is huge.
---
If your project is set up for it, you can reply to this email
Github user 243826 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/92#issuecomment-144575089
The discussion here applies to archetype log4j.properties and not to this
pull request. I'll give it until Friday morning PST before pulling it in.
P
Github user 243826 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/92#issuecomment-144088138
@tweise, I am not sure which misunderstanding you are referring to.
Regardless, I know your opinion. Thanks for sharing it. I am also looking for
more
24 matches
Mail list logo
