GitHub user ashishtadose opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/238
APEXMALHAR-2051 #comment removed redundant StorageAgent interface
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user ashishtadose commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/125#discussion_r48814740
--- Diff:
library/src/main/java/com/datatorrent/lib/util/AbstractKeyValueStorageAgent.java
---
@@ -0,0 +1,236
Github user ashishtadose commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/125#discussion_r48813010
--- Diff: pom.xml ---
@@ -184,7 +184,6 @@
org.apache.apex
apex-engine
${apex.core.version
Github user ashishtadose commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/125#discussion_r48620604
--- Diff: contrib/pom.xml ---
@@ -53,6 +53,11 @@
daily
+
--- End diff --
No
Github user ashishtadose commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/125#discussion_r48620383
--- Diff: pom.xml ---
@@ -184,7 +184,6 @@
org.apache.apex
apex-engine
${apex.core.version
Github user ashishtadose commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/125#discussion_r48563172
--- Diff: contrib/pom.xml ---
@@ -623,5 +628,12 @@
super-csv-joda
2.3.1
Github user ashishtadose commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/125#discussion_r48274840
--- Diff:
library/src/main/java/com/datatorrent/lib/util/StorageAgentKeyValueStore.java
---
@@ -0,0 +1,88 @@
+/**
+ * Licensed
Github user ashishtadose commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/184#issuecomment-166670922
All changes have been incorporated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user ashishtadose commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/125#discussion_r47956815
--- Diff:
library/src/main/java/com/datatorrent/lib/util/AbstractKeyValueStorageAgent.java
---
@@ -0,0 +1,234
Github user ashishtadose commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/125#discussion_r47956750
--- Diff:
library/src/main/java/com/datatorrent/lib/util/AbstractKeyValueStorageAgent.java
---
@@ -0,0 +1,234
Github user ashishtadose commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/125#discussion_r47956411
--- Diff:
library/src/main/java/com/datatorrent/lib/util/AbstractKeyValueStorageAgent.java
---
@@ -0,0 +1,234
Github user ashishtadose commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/125#discussion_r47956060
--- Diff:
library/src/main/java/com/datatorrent/lib/util/StorageAgentKeyValueStore.java
---
@@ -0,0 +1,88 @@
+/**
+ * Licensed
Github user ashishtadose commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/125#discussion_r47955679
--- Diff:
library/src/main/java/com/datatorrent/lib/util/StorageAgentKeyValueStore.java
---
@@ -0,0 +1,88 @@
+/**
+ * Licensed
Github user ashishtadose commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/125#discussion_r47955341
--- Diff:
library/src/main/java/com/datatorrent/lib/util/AppIdAwareStorageAgent.java ---
@@ -0,0 +1,37 @@
+/**
+ * Licensed to
Github user ashishtadose commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/184#issuecomment-165569141
@tweise @gauravgopi123 commits are squashed with appropriate changes.
Thanks for reviewing.
---
If your project is set up for it, you can reply
Github user ashishtadose commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/184#issuecomment-164523414
@tweise suggested changes are incorporated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ashishtadose commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/184#issuecomment-164027438
@tweise @tushargosavi
All storage agent abstract and concrete implementations have been moved to
malhar
MLHR-1938 - https://github.com
GitHub user ashishtadose opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/125
MLHR-1938 - Operator checkpointing in distributed in-memory store
Depends on https://issues.apache.org/jira/browse/APEXCORE-283
@tushargosavi kindly review.
You can
Github user ashishtadose commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/184#issuecomment-163366276
Hi @tweise @tushargosavi
All review comments have been incorporated.
Kindly suggest on core movement to Malhar.
---
If your project is set
Github user ashishtadose commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/184#discussion_r47129946
--- Diff:
common/src/main/java/com/datatorrent/common/util/FSStorageAgent.java ---
@@ -71,12 +71,10 @@ public FSStorageAgent(String path
Github user ashishtadose commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/184#issuecomment-163348597
@tweise agree its better that ways. will keep AppId support & Abstract
storage implementation in core and will move rest concrete implementation
GitHub user ashishtadose opened a pull request:
https://github.com/apache/incubator-apex-core/pull/184
APEXCORE-283 - checkpointing in distributed in-memory store
@tushargosavi
Can you please review the changes.
You can merge this pull request into a Git repository
22 matches
Mail list logo
