[GitHub] incubator-apex-malhar pull request: SPOI-7087 #resolve #comment Ad...

2016-04-21 Thread brightchen
Github user brightchen closed the pull request at: https://github.com/apache/incubator-apex-malhar/pull/194 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-apex-malhar pull request: SPOI-7818 #resolve #comment Re...

2016-04-14 Thread brightchen
Github user brightchen commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/240#discussion_r59813115 --- Diff: library/src/test/java/com/datatorrent/lib/io/fs/FileSplitterBaseTest.java --- @@ -97,7 +97,13 @@ protected void starting

[GitHub] incubator-apex-malhar pull request: SPOI-7818 #resolve #comment Re...

2016-04-14 Thread brightchen
Github user brightchen commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/240#discussion_r59810546 --- Diff: library/src/test/java/com/datatorrent/lib/io/fs/FileSplitterBaseTest.java --- @@ -97,7 +97,13 @@ protected void starting

[GitHub] incubator-apex-malhar pull request: SPOI-7818 #resolve #comment Re...

2016-04-14 Thread brightchen
GitHub user brightchen reopened a pull request: https://github.com/apache/incubator-apex-malhar/pull/240 SPOI-7818 #resolve #comment Remove dimensions code duplication betwee… …n megh and malhar You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-apex-malhar pull request: SPOI-7818 #resolve #comment Re...

2016-04-14 Thread brightchen
Github user brightchen closed the pull request at: https://github.com/apache/incubator-apex-malhar/pull/240 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-apex-malhar pull request: SPOI-7818 #resolve #comment Re...

2016-04-14 Thread brightchen
GitHub user brightchen reopened a pull request: https://github.com/apache/incubator-apex-malhar/pull/240 SPOI-7818 #resolve #comment Remove dimensions code duplication betwee… …n megh and malhar You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-apex-malhar pull request: SPOI-7818 #resolve #comment Re...

2016-04-14 Thread brightchen
Github user brightchen closed the pull request at: https://github.com/apache/incubator-apex-malhar/pull/240 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-apex-malhar pull request: SPOI-7818 #resolve #comment Re...

2016-04-14 Thread brightchen
GitHub user brightchen opened a pull request: https://github.com/apache/incubator-apex-malhar/pull/240 SPOI-7818 #resolve #comment Remove dimensions code duplication betwee… …n megh and malhar You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-1991 #resolve #comm...

2016-04-13 Thread brightchen
Github user brightchen closed the pull request at: https://github.com/apache/incubator-apex-malhar/pull/221 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-1991 #resolve #comm...

2016-03-28 Thread brightchen
GitHub user brightchen opened a pull request: https://github.com/apache/incubator-apex-malhar/pull/221 APEXMALHAR-1991 #resolve #comment Move Dimensions Computation Classes… … to org.apache.apex.malhar package You can merge this pull request into a Git repository by running

[GitHub] incubator-apex-malhar pull request: SPOI-7087 #resolve #comment Ad...

2016-02-29 Thread brightchen
GitHub user brightchen reopened a pull request: https://github.com/apache/incubator-apex-malhar/pull/194 SPOI-7087 #resolve #comment Add JDBC dimension output operator to Malhar You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-apex-malhar pull request: SPOI-7087 #resolve #comment Ad...

2016-02-29 Thread brightchen
Github user brightchen closed the pull request at: https://github.com/apache/incubator-apex-malhar/pull/194 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-apex-malhar pull request: SPOI-7087 #resolve #comment Ad...

2016-02-29 Thread brightchen
Github user brightchen closed the pull request at: https://github.com/apache/incubator-apex-malhar/pull/194 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-apex-malhar pull request: SPOI-7087 #resolve #comment Ad...

2016-02-29 Thread brightchen
GitHub user brightchen reopened a pull request: https://github.com/apache/incubator-apex-malhar/pull/194 SPOI-7087 #resolve #comment Add JDBC dimension output operator to Malhar You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-apex-malhar pull request: SPOI-7087 #resolve #comment Ad...

2016-02-25 Thread brightchen
GitHub user brightchen reopened a pull request: https://github.com/apache/incubator-apex-malhar/pull/194 SPOI-7087 #resolve #comment Add JDBC dimension output operator to Malhar You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-apex-malhar pull request: SPOI-7087 #resolve #comment Ad...

2016-02-25 Thread brightchen
Github user brightchen closed the pull request at: https://github.com/apache/incubator-apex-malhar/pull/194 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-apex-malhar pull request: SPOI-7087 #resolve #comment Ad...

2016-02-22 Thread brightchen
GitHub user brightchen opened a pull request: https://github.com/apache/incubator-apex-malhar/pull/194 SPOI-7087 #resolve #comment Add JDBC dimension output operator to Malhar You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-apex-malhar pull request: SPOI-7087 #resolve #comment Ad...

2016-02-22 Thread brightchen
Github user brightchen closed the pull request at: https://github.com/apache/incubator-apex-malhar/pull/192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-apex-malhar pull request: SPOI-7087 #resolve #comment Ad...

2016-02-22 Thread brightchen
GitHub user brightchen opened a pull request: https://github.com/apache/incubator-apex-malhar/pull/192 SPOI-7087 #resolve #comment Add JDBC dimension output operator to Malhar You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-apex-malhar pull request: MLHR-1919 #resolve #comment ad...

2016-01-27 Thread brightchen
GitHub user brightchen opened a pull request: https://github.com/apache/incubator-apex-malhar/pull/180 MLHR-1919 #resolve #comment add dimension schema to malhar You can merge this pull request into a Git repository by running: $ git pull https://github.com/brightchen

[GitHub] incubator-apex-malhar pull request: MLHR-1919 #resolve #comment ad...

2016-01-27 Thread brightchen
Github user brightchen closed the pull request at: https://github.com/apache/incubator-apex-malhar/pull/179 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-apex-malhar pull request: MLHR-1919 #resolve #comment ad...

2016-01-27 Thread brightchen
GitHub user brightchen opened a pull request: https://github.com/apache/incubator-apex-malhar/pull/179 MLHR-1919 #resolve #comment add dimension schema to malhar You can merge this pull request into a Git repository by running: $ git pull https://github.com/brightchen

[GitHub] incubator-apex-malhar pull request: MLHR-1919 move files to malhar

2015-12-18 Thread brightchen
Github user brightchen closed the pull request at: https://github.com/apache/incubator-apex-malhar/pull/143 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-apex-malhar pull request: MLHR-1919 move files to malhar

2015-12-18 Thread brightchen
GitHub user brightchen opened a pull request: https://github.com/apache/incubator-apex-malhar/pull/143 MLHR-1919 move files to malhar You can merge this pull request into a Git repository by running: $ git pull https://github.com/brightchen/incubator-apex-malhar MLHR-1919-1

[GitHub] incubator-apex-malhar pull request: MLHR-1944 #comment Added from ...

2015-12-15 Thread brightchen
GitHub user brightchen opened a pull request: https://github.com/apache/incubator-apex-malhar/pull/135 MLHR-1944 #comment Added from previous release @ilooner @chandnisingh please review and merge You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-apex-malhar pull request: MLHR-1943 #resolve #comment co...

2015-12-14 Thread brightchen
Github user brightchen commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/129#discussion_r47580926 --- Diff: library/src/main/java/com/datatorrent/lib/dimensions/aggregator/Aggregator.java --- @@ -0,0 +1,14 @@ +package

[GitHub] incubator-apex-malhar pull request: MLHR-1943 #resolve #comment co...

2015-12-14 Thread brightchen
GitHub user brightchen opened a pull request: https://github.com/apache/incubator-apex-malhar/pull/129 MLHR-1943 #resolve #comment copied from Megh @ilooner Could you please review and merge? You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-apex-malhar pull request: - MLHR-1908 Added helper metho...

2015-11-17 Thread brightchen
Github user brightchen commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/103#discussion_r45141784 --- Diff: library/src/main/java/com/datatorrent/lib/appdata/gpo/GPOUtils.java --- @@ -178,33 +227,40 @@ public static void

[GitHub] incubator-apex-malhar pull request: - MLHR-1908 Added helper metho...

2015-11-17 Thread brightchen
Github user brightchen commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/103#discussion_r45140443 --- Diff: library/src/main/java/com/datatorrent/lib/appdata/gpo/GPOUtils.java --- @@ -178,33 +227,40 @@ public static void

[GitHub] incubator-apex-malhar pull request: - MLHR-1896 #resolve #comment ...

2015-11-17 Thread brightchen
Github user brightchen commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/91#discussion_r45138364 --- Diff: library/src/main/java/com/datatorrent/lib/appdata/schemas/SchemaUtils.java --- @@ -490,5 +493,37 @@ public static JSONObject

[GitHub] incubator-apex-malhar pull request: MLHR-1906 #resolve #comment Sn...

2015-11-17 Thread brightchen
Github user brightchen commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/100#discussion_r45097101 --- Diff: library/src/main/java/com/datatorrent/lib/appdata/schemas/SnapshotSchema.java --- @@ -246,6 +247,26 @@ private void initialize

[GitHub] incubator-apex-malhar pull request: MLHR-1906 #resolve #comment Sn...

2015-11-16 Thread brightchen
Github user brightchen commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/100#discussion_r45023991 --- Diff: library/src/test/java/com/datatorrent/lib/appdata/snapshot/AppDataSnapshotServerTagsSupportTest.java --- @@ -0,0 +1,67

[GitHub] incubator-apex-malhar pull request: MLHR-1906 #resolve #comment Sn...

2015-11-16 Thread brightchen
Github user brightchen commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/100#discussion_r45023863 --- Diff: library/src/main/java/com/datatorrent/lib/appdata/schemas/SnapshotSchema.java --- @@ -246,6 +247,26 @@ private void initialize

[GitHub] incubator-apex-malhar pull request: MLHR-1906 #resolve #comment Sn...

2015-11-16 Thread brightchen
GitHub user brightchen opened a pull request: https://github.com/apache/incubator-apex-malhar/pull/100 MLHR-1906 #resolve #comment Snapshot Server support tags You can merge this pull request into a Git repository by running: $ git pull https://github.com/brightchen/incubator

[GitHub] incubator-apex-malhar pull request: MLHR-1874 #resolve #comment Im...

2015-11-13 Thread brightchen
Github user brightchen commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/82#discussion_r44825680 --- Diff: contrib/src/main/java/com/datatorrent/contrib/hive/AbstractFSRollingOutputOperator.java --- @@ -183,12 +184,7 @@ protected void

[GitHub] incubator-apex-malhar pull request: refactor AbstractAppDataSnapsh...

2015-11-11 Thread brightchen
GitHub user brightchen opened a pull request: https://github.com/apache/incubator-apex-malhar/pull/97 refactor AbstractAppDataSnapshotServer refactor AbstractAppDataSnapshotServer to support override or provide QueryExecutor You can merge this pull request into a Git repository by

[GitHub] incubator-apex-malhar pull request: Mlhr 1895: refactor AbstractAp...

2015-11-11 Thread brightchen
Github user brightchen closed the pull request at: https://github.com/apache/incubator-apex-malhar/pull/96 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-apex-malhar pull request: Mlhr 1895: refactor AbstractAp...

2015-11-11 Thread brightchen
GitHub user brightchen opened a pull request: https://github.com/apache/incubator-apex-malhar/pull/96 Mlhr 1895: refactor AbstractAppDataSnapshotServer to support override QueryExecutor This tags are case by case and hard to have generic query executor. refactor