Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/156#issuecomment-155908016
Sigh - I don't understand what I've done, it looks like something got
messed up in the last change when I merged in the latest devel-3. Any th
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/156#issuecomment-155896108
@chandnisingh Fixed all issues except for APEX-239
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ilganeli commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/156#discussion_r44502353
--- Diff: apex_checks.xml ---
@@ -97,6 +97,10 @@
+
+
--- End diff --
This was agreed
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/156#issuecomment-154558436
@vrozov Where do I configure the allowed number of violations? I did update
checkstyle and confirmed that it works with the latest version.
---
If your
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/156#issuecomment-154077920
@vrozov @tweise I've made the suggested updates and updated the comment for
this PR accordingly.
---
If your project is set up for it, you can rep
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/156#issuecomment-153908056
@tweise What would you recommend as the best path forward for this patch?
Remove the additional changes and leave the changes only limited to the
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/156#issuecomment-153907123
@tweise The only reason I submitted the additional changes is that
otherwise the number of CheckStyle violation exceeded the allowed limit causing
it to
GitHub user ilganeli opened a pull request:
https://github.com/apache/incubator-apex-core/pull/156
[APEX-230] Set line length to 120
* Set line length to 120 in CheckStyle.
* Removed COMMA from NoWhitespaceBefore check since this was also throwing
an error. This was broken
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/130#issuecomment-153100749
@tweise Beautiful! Great trick, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/130#issuecomment-152847590
@tweise Trying ```git push origin StyleFixesStreamingContainer``` from the
new branch after the merge just says "Everything up to date". Is the
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/130#issuecomment-152653280
Not sure why GitHub is still showing all these separate commits but the
commits above should now be squashed
---
If your project is set up for it, you
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/130#issuecomment-152650181
@tweise Oh boy, what have I done. I think I messed up the rebase :-/
---
If your project is set up for it, you can reply to this email and have your
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/129#issuecomment-152338508
@ilooner @243826 I think maintaining provenance of the code is definitely
important, how would you recommend submitting a patch that maintains this
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/130#issuecomment-152262373
@vrozov @chandnisingh I can make these updates once the appropriate code
style settings are checked in.
---
If your project is set up for it, you can
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/129#issuecomment-152261033
@243826 - this wasn't done explicitly based on the coding guidelines but
was done in an effort to appeal to common best practices for coding.
Github user ilganeli commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/130#discussion_r42711984
--- Diff:
engine/src/main/java/com/datatorrent/stram/engine/StreamingContainer.java ---
@@ -920,8 +927,8 @@ private void deployNodes(List
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/125#issuecomment-150107202
@tweise @chandnisingh This looks good to merge, for future I agree with
@tweise that we should try to avoid solving multiple issues with one PR where
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/125#issuecomment-150056437
Vlad - I am concerned that if all check styles are a single commit it will
be overwhelmingly large. I think one commit per small batch of files is more
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/125#issuecomment-149982896
Sorry, to be clear, in IntelliJ the apex-style format sets the following
code:
``` static
{
...
...
}
```
As
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/125#issuecomment-149980756
@chandnisingh Understood, either way, code style should be updated to
reflect this.
---
If your project is set up for it, you can reply to this email
GitHub user ilganeli opened a pull request:
https://github.com/apache/incubator-apex-core/pull/130
[APEX-208] Fixed style violations in StreamingContainer.java
Fixed code style issues in StreamingContainer.java
You can merge this pull request into a Git repository by running
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/125#issuecomment-149935494
@chandnisingh
I've identified another error:
Braces placement for other should be (next-line) to be consistent with
braces placement for o
GitHub user ilganeli opened a pull request:
https://github.com/apache/incubator-apex-core/pull/129
[APEX-209] Refactored monolithic deployInputStream function.
In an effort to better understand the flow of data within Apex, I have
refactored the monolithic (200+ line long
Github user ilganeli closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/117
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/117#issuecomment-149923113
I'll submit a second PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/117#issuecomment-149917735
Pramod, do you want all the commits to be a single commit or do you just
want the style fixes as a single commit?
---
If your project is set up for it
Github user ilganeli commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/98#discussion_r42306708
--- Diff:
engine/src/main/java/com/datatorrent/stram/StreamingAppMasterService.java ---
@@ -102,8 +102,6 @@
private static final long
Github user ilganeli commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/98#discussion_r42306706
--- Diff:
engine/src/main/java/com/datatorrent/stram/StreamingAppMasterService.java ---
@@ -102,8 +102,6 @@
private static final long
Github user ilganeli commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/98#discussion_r42306698
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -80,6 +80,8 @@
public static final String
Github user ilganeli commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/98#discussion_r42306700
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -107,6 +109,9 @@
public static Attribute
Github user ilganeli commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/98#discussion_r42306679
--- Diff:
engine/src/main/java/com/datatorrent/stram/StreamingAppMasterService.java ---
@@ -972,6 +943,52 @@ else if
Github user ilganeli commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/76#discussion_r42306656
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/physical/StreamMapping.java ---
@@ -188,6 +192,69 @@ private void addSlidingUnifiers
Github user ilganeli commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/76#discussion_r42306644
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/physical/StreamMapping.java ---
@@ -222,6 +289,12 @@ private void redoMapping
Github user ilganeli commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/76#discussion_r42306635
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/physical/StreamMapping.java ---
@@ -188,6 +192,69 @@ private void addSlidingUnifiers
Github user ilganeli commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/76#discussion_r42306624
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/physical/StreamMapping.java ---
@@ -188,6 +192,69 @@ private void addSlidingUnifiers
Github user ilganeli commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/76#discussion_r42306617
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/physical/StreamMapping.java ---
@@ -188,6 +192,69 @@ private void addSlidingUnifiers
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/102#issuecomment-148890609
@chandnisingh Makes sense! I see the jar now, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/102#issuecomment-14192
If I may offer an alternative suggestion for IntelliJ - I think the
cleanest approach here is to export the the user settings for IntelliJ as a Jar
Github user ilganeli commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/116#discussion_r42166013
--- Diff:
engine/src/main/java/com/datatorrent/stram/webapp/asm/CompactUtil.java ---
@@ -153,12 +153,14 @@ private static void
GitHub user ilganeli opened a pull request:
https://github.com/apache/incubator-apex-core/pull/117
Refactored monolithic deployInputStream function
In an effort to better understand the flow of data within Apex, I have
refactored the monolithic (200+ line long) deployInputStreams
40 matches
Mail list logo
