[GitHub] incubator-apex-core pull request: APEXCORE-451 : get-app-package-o...

2016-05-05 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/326#discussion_r62244008 --- Diff: engine/src/main/java/com/datatorrent/stram/cli/ApexCli.java --- @@ -2963,7 +2964,7 @@ public void execute(String[] args

[GitHub] incubator-apex-core pull request: APEXCORE-107 Support for adding ...

2016-05-04 Thread tushargosavi
Github user tushargosavi commented on the pull request: https://github.com/apache/incubator-apex-core/pull/313#issuecomment-217016767 Merged GenericOperatorMeta with OperatorMeta. ModuleMeta extends from OpeartorMeta. We can merge ModuleMeta and keep a single OperatorMeta but that

[GitHub] incubator-apex-core pull request: APEXCORE-107 Support for adding ...

2016-05-03 Thread tushargosavi
Github user tushargosavi commented on the pull request: https://github.com/apache/incubator-apex-core/pull/313#issuecomment-216571779 changed the name of Vertex to GenericOperator --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-apex-core pull request: APEXCORE-107 Support for adding ...

2016-05-02 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/313#discussion_r61794711 --- Diff: api/src/main/java/com/datatorrent/api/Component.java --- @@ -116,4 +116,13 @@ public boolean equals(Object obj

[GitHub] incubator-apex-core pull request: APEXCORE-107 Support for adding ...

2016-05-02 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/313#discussion_r61794671 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlanConfiguration.java --- @@ -2187,6 +2190,27 @@ public void

[GitHub] incubator-apex-core pull request: APEXCORE-107 Support for adding ...

2016-05-02 Thread tushargosavi
Github user tushargosavi commented on the pull request: https://github.com/apache/incubator-apex-core/pull/313#issuecomment-216165307 Putting Vertex inside Component , to avoid it being as top level interface. As all node component of the graph inherits from Vertex. --- If your

[GitHub] incubator-apex-core pull request: APEXCORE-107 Support for adding ...

2016-05-02 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/313#discussion_r61717221 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -239,7 +239,7 @@ public void sendMetrics

[GitHub] incubator-apex-core pull request: APEXCORE-107 Support for adding ...

2016-05-02 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/313#discussion_r61716868 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -778,32 +799,162 @@ public void

[GitHub] incubator-apex-core pull request: APEXCORE-107 Support for adding ...

2016-04-29 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/313#discussion_r61630974 --- Diff: api/src/main/java/com/datatorrent/api/DagNode.java --- @@ -0,0 +1,24 @@ +/** + * Licensed to the Apache Software

[GitHub] incubator-apex-core pull request: APEXCORE-107 Support for adding ...

2016-04-29 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/313#discussion_r61630938 --- Diff: engine/src/test/java/com/datatorrent/stram/plan/logical/module/TestModuleExpansion.java --- @@ -184,7 +190,7 @@ public void

[GitHub] incubator-apex-core pull request: APEXCORE-107 Support for adding ...

2016-04-29 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/313#discussion_r61630963 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlanConfiguration.java --- @@ -2187,6 +2190,27 @@ public void

[GitHub] incubator-apex-core pull request: APEXCORE-107 Support for adding ...

2016-04-26 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/313#discussion_r61153475 --- Diff: api/src/main/java/com/datatorrent/api/Module.java --- @@ -36,7 +36,7 @@ * @since 3.3.0

[GitHub] incubator-apex-core pull request: APEXCORE-107 Support for adding ...

2016-04-25 Thread tushargosavi
Github user tushargosavi commented on the pull request: https://github.com/apache/incubator-apex-core/pull/313#issuecomment-214263317 @PramodSSImmaneni @sandeepdeshmukh can you review this pull request? --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-apex-core pull request: APEXCORE-107 Support for adding ...

2016-04-22 Thread tushargosavi
GitHub user tushargosavi reopened a pull request: https://github.com/apache/incubator-apex-core/pull/313 APEXCORE-107 Support for adding modules in the DAG through property and json file Support for adding modules in the DAG property file and json file. Also changed module API

[GitHub] incubator-apex-core pull request: APEXCORE-107 Support for adding ...

2016-04-22 Thread tushargosavi
Github user tushargosavi closed the pull request at: https://github.com/apache/incubator-apex-core/pull/313 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-apex-core pull request: APEXCORE-107 Support for adding ...

2016-04-22 Thread tushargosavi
GitHub user tushargosavi opened a pull request: https://github.com/apache/incubator-apex-core/pull/313 APEXCORE-107 Support for adding modules in the DAG through property and json file Support for adding modules in the DAG property file and json file. Also changed module API to

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-1965 Utility classe...

2016-04-21 Thread tushargosavi
Github user tushargosavi closed the pull request at: https://github.com/apache/incubator-apex-malhar/pull/204 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] incubator-apex-malhar pull request: MLHR-1861 Write demo applicati...

2016-03-31 Thread tushargosavi
Github user tushargosavi closed the pull request at: https://github.com/apache/incubator-apex-malhar/pull/42 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2010 Add Tranform o...

2016-03-21 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/209#discussion_r56794158 --- Diff: library/src/main/java/com/datatorrent/lib/transform/TransformOperator.java --- @@ -0,0 +1,172 @@ +/** + * Licensed to

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2010 Add Tranform o...

2016-03-21 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/209#discussion_r56794171 --- Diff: library/src/main/java/com/datatorrent/lib/expression/JavaExpressionParser.java --- @@ -0,0 +1,179

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2010 Add Tranform o...

2016-03-21 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/209#discussion_r56792263 --- Diff: library/src/main/java/com/datatorrent/lib/expression/JavaExpressionParser.java --- @@ -0,0 +1,179

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2010 Add Tranform o...

2016-03-21 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/209#discussion_r56787178 --- Diff: library/src/main/java/com/datatorrent/lib/expression/JavaExpressionParser.java --- @@ -0,0 +1,179

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2011-2012 Avro to P...

2016-03-15 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/211#discussion_r56287547 --- Diff: contrib/src/main/java/com/datatorrent/contrib/avro/PojoToAvro.java --- @@ -0,0 +1,296 @@ +/** + * Licensed to the

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2011-2012 Avro to P...

2016-03-15 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/211#discussion_r56287526 --- Diff: contrib/src/main/java/com/datatorrent/contrib/avro/AvroToPojo.java --- @@ -0,0 +1,428 @@ +/** + * Licensed to the

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2011-2012 Avro to P...

2016-03-15 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/211#discussion_r56287519 --- Diff: contrib/src/main/java/com/datatorrent/contrib/avro/AvroToPojo.java --- @@ -0,0 +1,428 @@ +/** + * Licensed to the

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2011-2012 Avro to P...

2016-03-15 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/211#discussion_r56287510 --- Diff: contrib/src/main/java/com/datatorrent/contrib/avro/AvroToPojo.java --- @@ -0,0 +1,428 @@ +/** + * Licensed to the

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2011-2012 Avro to P...

2016-03-15 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/211#discussion_r56287505 --- Diff: contrib/src/main/java/com/datatorrent/contrib/avro/AvroToPojo.java --- @@ -0,0 +1,428 @@ +/** + * Licensed to the

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2011-2012 Avro to P...

2016-03-15 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/211#discussion_r56287492 --- Diff: contrib/src/test/java/com/datatorrent/contrib/avro/SimpleOrder.java --- @@ -0,0 +1,93 @@ +/** --- End diff

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2011-2012 Avro to P...

2016-03-15 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/211#discussion_r56287478 --- Diff: contrib/src/test/java/com/datatorrent/contrib/avro/AvroReaderWriterTest.java --- @@ -0,0 +1,219 @@ +/** + * Licensed

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2004: Add file's mo...

2016-03-11 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/203#discussion_r55806762 --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java --- @@ -439,12 +439,12 @@ protected ScannedFileInfo

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-1965 Utility classe...

2016-02-27 Thread tushargosavi
GitHub user tushargosavi opened a pull request: https://github.com/apache/incubator-apex-malhar/pull/204 APEXMALHAR-1965 Utility classes for Write Ahead Log support You can merge this pull request into a Git repository by running: $ git pull https://github.com/tushargosavi

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2004: Add file's mo...

2016-02-27 Thread tushargosavi
GitHub user tushargosavi opened a pull request: https://github.com/apache/incubator-apex-malhar/pull/203 APEXMALHAR-2004: Add file's modification time in referenceTimes map instead of parent's You can merge this pull request into a Git repository by running: $ git

[GitHub] incubator-apex-malhar pull request: MLHR-1962 json parser enhancem...

2016-02-04 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/163#discussion_r51879732 --- Diff: contrib/src/main/java/com/datatorrent/contrib/parser/JsonParser.java --- @@ -0,0 +1,241 @@ +/** + * Licensed to the

[GitHub] incubator-apex-malhar pull request: MLHR-1962 json parser enhancem...

2016-02-03 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/163#discussion_r51700413 --- Diff: contrib/src/main/java/com/datatorrent/contrib/parser/JsonParser.java --- @@ -0,0 +1,241 @@ +/** + * Licensed to the

[GitHub] incubator-apex-malhar pull request: MLHR-1962 json parser enhancem...

2016-02-03 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/163#discussion_r51699476 --- Diff: contrib/src/main/java/com/datatorrent/contrib/parser/JsonParser.java --- @@ -0,0 +1,241 @@ +/** + * Licensed to the

[GitHub] incubator-apex-malhar pull request: MLHR-1962 json parser enhancem...

2016-02-03 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/163#discussion_r51699399 --- Diff: contrib/src/main/java/com/datatorrent/contrib/parser/JsonParser.java --- @@ -0,0 +1,241 @@ +/** + * Licensed to the

[GitHub] incubator-apex-core pull request: APEXCORE-107 Allow adding module...

2016-01-20 Thread tushargosavi
Github user tushargosavi commented on the pull request: https://github.com/apache/incubator-apex-core/pull/206#issuecomment-173263982 I have added description in jira. The discussion about this did happen in December. https://mail-archives.apache.org/mod_mbox/incubator-apex-dev

[GitHub] incubator-apex-core pull request: APEXCORE-107 Allow adding module...

2016-01-18 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/206#discussion_r50076928 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -2059,4 +2106,64 @@ public int hashCode

[GitHub] incubator-apex-core pull request: APEXCORE-107 Allow adding module...

2016-01-18 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/206#discussion_r50076931 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -2059,4 +2106,64 @@ public int hashCode

[GitHub] incubator-apex-core pull request: APEXCORE-107 Allow adding module...

2016-01-18 Thread tushargosavi
Github user tushargosavi commented on the pull request: https://github.com/apache/incubator-apex-core/pull/206#issuecomment-172750435 @bhupeshchawda can you please take lookup proxy port handling logic. @gauravgopi123 can you please review this pull request --- If your project

[GitHub] incubator-apex-core pull request: APEXCORE-107 Allow adding module...

2016-01-13 Thread tushargosavi
GitHub user tushargosavi opened a pull request: https://github.com/apache/incubator-apex-core/pull/206 APEXCORE-107 Allow adding module in DAG specified by property file and json Changes in this pull request - setSource, addSink were not handling module proxy port, made

[GitHub] incubator-apex-malhar pull request: [Review only] MLHR 1957 hbase ...

2015-12-31 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/155#discussion_r48653269 --- Diff: contrib/src/main/java/com/datatorrent/contrib/hbase/HBaseGetOperator.java --- @@ -47,7 +47,7 @@ public void emitTuples

[GitHub] incubator-apex-malhar pull request: [Review only] MLHR 1957 hbase ...

2015-12-31 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/155#discussion_r48653237 --- Diff: contrib/src/main/java/com/datatorrent/contrib/hbase/HBaseFieldValueGenerator.java --- @@ -0,0 +1,46 @@ +package

[GitHub] incubator-apex-core pull request: APEXCORE-272 copy operator and p...

2015-12-30 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/191#discussion_r48648830 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -1359,7 +1409,8 @@ private void

[GitHub] incubator-apex-core pull request: APEXCORE-272 copy operator and p...

2015-12-30 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/191#discussion_r48647943 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -907,6 +912,51 @@ else if (field.getType

[GitHub] incubator-apex-core pull request: APEXCORE-272 copy operator and p...

2015-12-30 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/191#discussion_r48647941 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -907,6 +912,51 @@ else if (field.getType

[GitHub] incubator-apex-core pull request: APEXCORE-272 copy operator and p...

2015-12-30 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/191#discussion_r48647938 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -907,6 +912,51 @@ else if (field.getType

[GitHub] incubator-apex-core pull request: APEXCORE-272 copy operator and p...

2015-12-30 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/191#discussion_r48647933 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -1359,7 +1409,8 @@ private void

[GitHub] incubator-apex-core pull request: APEXCORE-272 copy operator and p...

2015-12-30 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/191#discussion_r48647937 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -907,6 +912,51 @@ else if (field.getType

[GitHub] incubator-apex-core pull request: APEXCORE-272 copy operator and p...

2015-12-30 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/191#discussion_r48647935 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -1374,7 +1425,8 @@ private void

[GitHub] incubator-apex-core pull request: APEXCORE-272 copy operator and p...

2015-12-30 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/191#discussion_r48647940 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -907,6 +912,51 @@ else if (field.getType

[GitHub] incubator-apex-core pull request: APEXCORE-272 copy operator and p...

2015-12-30 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/191#discussion_r48647480 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -719,6 +719,11 @@ public void

[GitHub] incubator-apex-core pull request: APEXCORE-272 copy operator and p...

2015-12-28 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/191#discussion_r48522048 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -1359,7 +1409,8 @@ private void

[GitHub] incubator-apex-core pull request: APEXCORE-272 copy operator and p...

2015-12-28 Thread tushargosavi
Github user tushargosavi commented on the pull request: https://github.com/apache/incubator-apex-core/pull/191#issuecomment-167599384 @gauravgopi123 @tweise can you take a look at this pull request? --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-apex-malhar pull request: Files for the twitter demos an...

2015-12-24 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/146#discussion_r48410026 --- Diff: demos/twitter/src/main/java/com/datatorrent/demos/twitter/TwitterStatusMediaTypeExtractor.java --- @@ -0,0 +1,40

[GitHub] incubator-apex-malhar pull request: Files for the twitter demos an...

2015-12-24 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/146#discussion_r48410028 --- Diff: demos/twitter/src/main/java/com/datatorrent/demos/twitter/TwitterStatusUserExtractor.java --- @@ -0,0 +1,48

[GitHub] incubator-apex-core pull request: APEXCORE-272 copy operator and p...

2015-12-23 Thread tushargosavi
GitHub user tushargosavi opened a pull request: https://github.com/apache/incubator-apex-core/pull/191 APEXCORE-272 copy operator and port attributes from module dag to parent dag. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-apex-core pull request: APEXCORE-3 Module Support REBASE...

2015-12-21 Thread tushargosavi
Github user tushargosavi commented on the pull request: https://github.com/apache/incubator-apex-core/pull/189#issuecomment-166531364 @tweise I have pushed changes to your branch. waiting for travis to finish. --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-apex-core pull request: APEXCORE-3 Module Support REBASE...

2015-12-21 Thread tushargosavi
Github user tushargosavi commented on the pull request: https://github.com/apache/incubator-apex-core/pull/189#issuecomment-166447656 I have made changes in my https://github.com/tushargosavi/incubator-apex-core/tree/pull189 branch. I will have to do force push in your branch

[GitHub] incubator-apex-core pull request: APEXCORE-3 Module Support REBASE...

2015-12-21 Thread tushargosavi
Github user tushargosavi commented on the pull request: https://github.com/apache/incubator-apex-core/pull/189#issuecomment-166366057 I am re-writing the commits on top of latest devel-3 with above changes, will push once done. --- If your project is set up for it, you can reply to

[GitHub] incubator-apex-core pull request: APEXCORE-3 Module Support REBASE...

2015-12-21 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/189#discussion_r48168838 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -1116,13 +1320,78 @@ public StreamMeta addStream

[GitHub] incubator-apex-core pull request: APEXCORE-3 Module Support REBASE...

2015-12-21 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/189#discussion_r48167960 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -405,6 +413,7 @@ public void sendMetrics

[GitHub] incubator-apex-core pull request: APEXCORE-3 Module Support REBASE...

2015-12-21 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/189#discussion_r48167974 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -1116,13 +1320,78 @@ public StreamMeta addStream

[GitHub] incubator-apex-core pull request: APEXCORE-3 Module Support REBASE...

2015-12-21 Thread tushargosavi
Github user tushargosavi commented on the pull request: https://github.com/apache/incubator-apex-core/pull/189#issuecomment-166283164 @tweise following commits fixes checkstyle violations. https://github.com/tushargosavi/incubator-apex-core/commit

[GitHub] incubator-apex-core pull request: APEXCORE-3 Module Support REBASE...

2015-12-21 Thread tushargosavi
Github user tushargosavi commented on the pull request: https://github.com/apache/incubator-apex-core/pull/189#issuecomment-166231568 I am working on removing these warnings. will send updated patch. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-17 Thread tushargosavi
Github user tushargosavi commented on the pull request: https://github.com/apache/incubator-apex-core/pull/148#issuecomment-165697558 Changed commits messages with APEXCORE jiras. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-17 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47999408 --- Diff: engine/src/main/java/com/datatorrent/stram/codec/LogicalPlanSerializer.java --- @@ -116,91 +172,110 @@ public boolean useForType

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-17 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47998956 --- Diff: engine/src/main/java/com/datatorrent/stram/webapp/StramWebServices.java --- @@ -527,6 +558,19 @@ public JSONObject

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-17 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47998921 --- Diff: engine/src/main/java/com/datatorrent/stram/codec/LogicalPlanSerializer.java --- @@ -116,91 +172,110 @@ public boolean useForType

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-16 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47873050 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -1067,28 +1096,186 @@ public int hashCode

[GitHub] incubator-apex-malhar pull request: *For Review Only* Apex 247 - I...

2015-12-15 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/136#discussion_r47742770 --- Diff: library/src/test/java/com/datatorrent/lib/iteration/DelayOperatorTest.java --- @@ -0,0 +1,174 @@ +package

[GitHub] incubator-apex-malhar pull request: *For Review Only* Apex 247 - I...

2015-12-15 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/136#discussion_r47740384 --- Diff: demos/iteration/src/test/java/com/datatorrent/demos/iteration/ApplicationTest.java --- @@ -0,0 +1,43

[GitHub] incubator-apex-malhar pull request: *For Review Only* Apex 247 - I...

2015-12-15 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/136#discussion_r47740376 --- Diff: library/src/main/java/com/datatorrent/lib/iteration/DelayOperator.java --- @@ -0,0 +1,130 @@ +package

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-15 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47674225 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -1067,28 +1096,186 @@ public int hashCode

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-15 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47671806 --- Diff: engine/src/main/java/com/datatorrent/stram/webapp/StramWebServices.java --- @@ -765,10 +856,10 @@ public JSONObject

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-14 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47596699 --- Diff: engine/src/main/java/com/datatorrent/stram/StreamingContainerManager.java --- @@ -2246,6 +2306,50 @@ public LogicalOperatorInfo

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-13 Thread tushargosavi
Github user tushargosavi commented on the pull request: https://github.com/apache/incubator-apex-core/pull/148#issuecomment-164285392 squashed commits and updated pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-11 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47358637 --- Diff: engine/src/main/java/com/datatorrent/stram/StreamingContainerManager.java --- @@ -2246,6 +2306,50 @@ public LogicalOperatorInfo

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-10 Thread tushargosavi
Github user tushargosavi commented on the pull request: https://github.com/apache/incubator-apex-core/pull/148#issuecomment-163723074 updated the pull request with suggestion from @davidyan74 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-10 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47219665 --- Diff: engine/src/main/java/com/datatorrent/stram/codec/LogicalPlanSerializer.java --- @@ -116,91 +165,144 @@ public boolean useForType

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-10 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47215121 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlanConfiguration.java --- @@ -2092,6 +2068,35 @@ public void

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-10 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47203259 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlanConfiguration.java --- @@ -2092,6 +2068,35 @@ public void

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-10 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47202183 --- Diff: engine/src/main/java/com/datatorrent/stram/codec/LogicalPlanSerializer.java --- @@ -116,91 +165,144 @@ public boolean useForType

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-10 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47201918 --- Diff: engine/src/test/java/com/datatorrent/stram/plan/logical/module/TestModuleExpansion.java --- @@ -0,0 +1,542

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-10 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47201866 --- Diff: engine/src/main/java/com/datatorrent/stram/codec/LogicalPlanSerializer.java --- @@ -116,91 +165,144 @@ public boolean useForType

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-10 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47201811 --- Diff: engine/src/main/java/com/datatorrent/stram/codec/LogicalPlanSerializer.java --- @@ -116,91 +165,144 @@ public boolean useForType

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-10 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47200985 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlanConfiguration.java --- @@ -2153,17 +2172,17 @@ public static

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-10 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47199969 --- Diff: engine/src/main/java/com/datatorrent/stram/StreamingContainerManager.java --- @@ -2246,6 +2306,50 @@ public LogicalOperatorInfo

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-10 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47198502 --- Diff: engine/src/main/java/com/datatorrent/stram/webapp/StramWebServices.java --- @@ -511,6 +532,16 @@ public JSONObject

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-09 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47191251 --- Diff: engine/src/main/java/com/datatorrent/stram/webapp/StramWebServices.java --- @@ -660,6 +729,37 @@ public JSONObject getPorts

[GitHub] incubator-apex-malhar pull request: MLHR-1901 #resolve

2015-12-09 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/121#discussion_r47189655 --- Diff: library/src/test/java/org/apache/hadoop/io/file/tfile/DTFileTest.java --- @@ -70,7 +73,7 @@ public void setUp() throws

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-09 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47189450 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -1128,13 +1321,75 @@ public StreamMeta addStream

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-09 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47189120 --- Diff: engine/src/main/java/com/datatorrent/stram/webapp/StramWebServices.java --- @@ -660,6 +729,37 @@ public JSONObject getPorts

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-09 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47188927 --- Diff: engine/src/main/java/com/datatorrent/stram/webapp/StramWebServices.java --- @@ -739,6 +871,35 @@ else if (propertyName.equals

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-09 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47188105 --- Diff: engine/src/main/java/com/datatorrent/stram/webapp/StramWebServices.java --- @@ -511,6 +532,16 @@ public JSONObject

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-09 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47188057 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -776,7 +795,7 @@ public String getName

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-09 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47188066 --- Diff: engine/src/main/java/com/datatorrent/stram/webapp/StramWebServices.java --- @@ -668,25 +752,29 @@ public JSONObject getPort

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-09 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47188062 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlanConfiguration.java --- @@ -2014,32 +2013,9 @@ public void

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-09 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47188047 --- Diff: engine/src/main/java/com/datatorrent/stram/codec/LogicalPlanSerializer.java --- @@ -116,91 +165,142 @@ public boolean useForType

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

2015-12-09 Thread tushargosavi
Github user tushargosavi commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/148#discussion_r47188051 --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java --- @@ -146,10 +151,12 @@ private final Map

  1   2   >