Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/313
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user tushargosavi commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/313#issuecomment-217016767
Merged GenericOperatorMeta with OperatorMeta. ModuleMeta extends from
OpeartorMeta. We can merge ModuleMeta and keep a single OperatorMeta but that
w
Github user tushargosavi commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/313#issuecomment-216571779
changed the name of Vertex to GenericOperator
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user PramodSSImmaneni commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/313#issuecomment-216393279
I also support changing the name to GenericOperator
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user davidyan74 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/313#issuecomment-216389226
I think in the field of streaming technology, all of these different nodes
in the DAG share the same concept of an operator. So, instead of introducing a
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61794711
--- Diff: api/src/main/java/com/datatorrent/api/Component.java ---
@@ -116,4 +116,13 @@ public boolean equals(Object obj)
}
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61794671
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlanConfiguration.java
---
@@ -2187,6 +2190,27 @@ public void popu
Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61790619
--- Diff: api/src/main/java/com/datatorrent/api/Component.java ---
@@ -116,4 +116,13 @@ public boolean equals(Object obj)
}
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61787475
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlanConfiguration.java
---
@@ -2187,6 +2190,27 @@ public void popula
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61778110
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlanConfiguration.java
---
@@ -2187,6 +2190,27 @@ public void populateDA
Github user tushargosavi commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/313#issuecomment-216165307
Putting Vertex inside Component , to avoid it being as top level interface.
As all node component of the graph inherits from Vertex.
---
If your proj
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61717221
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -239,7 +239,7 @@ public void sendMetrics(Collectio
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61716868
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -778,32 +799,162 @@ public void
resetStreamPersis
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61673044
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -778,32 +799,162 @@ public void
resetStreamPersistanceO
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61673039
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -778,32 +799,162 @@ public void
resetStreamPersistanceO
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61672989
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -239,7 +239,7 @@ public void sendMetrics(Collection metr
Github user tweise commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/313#issuecomment-215984811
The common interface that we introduce for a vertex in the logical DAG, it
could probably need some broader review and discussion. As for the naming,
other
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61630974
--- Diff: api/src/main/java/com/datatorrent/api/DagNode.java ---
@@ -0,0 +1,24 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61630938
--- Diff:
engine/src/test/java/com/datatorrent/stram/plan/logical/module/TestModuleExpansion.java
---
@@ -184,7 +190,7 @@ public void setPo
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61630963
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlanConfiguration.java
---
@@ -2187,6 +2190,27 @@ public void popu
Github user sandeshh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61617386
--- Diff: api/src/main/java/com/datatorrent/api/DagNode.java ---
@@ -0,0 +1,24 @@
+/**
+ * Licensed to the Apache Software Foundation (AS
Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61617019
--- Diff: api/src/main/java/com/datatorrent/api/DagNode.java ---
@@ -0,0 +1,24 @@
+/**
+ * Licensed to the Apache Software Founda
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61536916
--- Diff: api/src/main/java/com/datatorrent/api/DagNode.java ---
@@ -0,0 +1,24 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61536670
--- Diff:
engine/src/test/java/com/datatorrent/stram/plan/logical/module/TestModuleExpansion.java
---
@@ -184,7 +190,7 @@ public void setPortMemo
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61536617
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlanConfiguration.java
---
@@ -2187,6 +2190,27 @@ public void populateDA
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61536347
--- Diff: api/src/main/java/com/datatorrent/api/DagNode.java ---
@@ -0,0 +1,24 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61153475
--- Diff: api/src/main/java/com/datatorrent/api/Module.java ---
@@ -36,7 +36,7 @@
* @since 3.3.0
*/
@InterfaceStability.Evol
Github user PramodSSImmaneni commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/313#issuecomment-214563277
In the current form, where module gets materialized in the logical plan and
does not have a runtime aspect to itself directly, it would be difficul
Github user tweise commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/313#issuecomment-214561638
Looks like this already came up during previous discussion and there wasn't
any conclusion. Need to go back to that.
---
If your project is set up for it,
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61006802
--- Diff: api/src/main/java/com/datatorrent/api/Module.java ---
@@ -36,7 +36,7 @@
* @since 3.3.0
*/
@InterfaceStability.Evolving
Github user tushargosavi commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/313#issuecomment-214263317
@PramodSSImmaneni @sandeepdeshmukh can you review this pull request?
---
If your project is set up for it, you can reply to this email and have your
r
GitHub user tushargosavi reopened a pull request:
https://github.com/apache/incubator-apex-core/pull/313
APEXCORE-107 Support for adding modules in the DAG through property and
json file
Support for adding modules in the DAG property file and json file.
Also changed module API t
Github user tushargosavi closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/313
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user tushargosavi opened a pull request:
https://github.com/apache/incubator-apex-core/pull/313
APEXCORE-107 Support for adding modules in the DAG through property and
json file
Support for adding modules in the DAG property file and json file.
Also changed module API to
34 matches
Mail list logo
