Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/191
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48648830
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -1359,7 +1409,8 @@ private void addDAGToCurrentDAG
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48647943
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -907,6 +912,51 @@ else if (field.getType() == floa
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48647941
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -907,6 +912,51 @@ else if (field.getType() == floa
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48647938
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -907,6 +912,51 @@ else if (field.getType() == floa
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48647933
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -1359,7 +1409,8 @@ private void addDAGToCurrentDAG
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48647937
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -907,6 +912,51 @@ else if (field.getType() == floa
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48647935
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -1374,7 +1425,8 @@ private void addDAGToCurrentDAG
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48647940
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -907,6 +912,51 @@ else if (field.getType() == floa
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48647480
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -719,6 +719,11 @@ public void
resetStreamPersista
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48646622
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -1359,7 +1409,8 @@ private void addDAGToCurrentDAG(Modul
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48589935
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -1359,7 +1409,8 @@ private void addDAGToCurrentDAG(Modul
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48589840
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -907,6 +912,51 @@ else if (field.getType() == float.clas
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48571279
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -1359,7 +1409,8 @@ private void addDAGToCurrentDA
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48570005
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -1374,7 +1425,8 @@ private void addDAGToCurrentDA
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48569555
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -907,6 +912,51 @@ else if (field.getType() == flo
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48569051
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -907,6 +912,51 @@ else if (field.getType() == flo
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48569034
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -907,6 +912,51 @@ else if (field.getType() == flo
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48568967
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -907,6 +912,51 @@ else if (field.getType() == flo
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48568829
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -719,6 +719,11 @@ public void
resetStreamPersist
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48554311
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -1359,7 +1409,8 @@ private void addDAGToCurrentDAG(Modul
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48522048
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -1359,7 +1409,8 @@ private void addDAGToCurrentDAG
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48492262
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -1359,7 +1409,8 @@ private void addDAGToCurrentDAG(Modul
Github user tushargosavi commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/191#issuecomment-167599384
@gauravgopi123 @tweise can you take a look at this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user tushargosavi opened a pull request:
https://github.com/apache/incubator-apex-core/pull/191
APEXCORE-272 copy operator and port attributes from module dag to parent
dag.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
25 matches
Mail list logo