[GitHub] incubator-apex-core pull request: APEXCORE-393 #resolve Adding Dag...

2016-03-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-apex-core/pull/274 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-apex-core pull request: APEXCORE-393 #resolve Adding Dag...

2016-03-22 Thread ishark
Github user ishark commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/274#discussion_r57090295 --- Diff: engine/src/main/java/com/datatorrent/stram/StreamingAppMasterService.java --- @@ -950,7 +977,11 @@ private void execute() throws YarnExc

[GitHub] incubator-apex-core pull request: APEXCORE-393 #resolve Adding Dag...

2016-03-22 Thread tweise
Github user tweise commented on the pull request: https://github.com/apache/incubator-apex-core/pull/274#issuecomment-200081121 @ishark this looks good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] incubator-apex-core pull request: APEXCORE-393 #resolve Adding Dag...

2016-03-22 Thread tweise
Github user tweise commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/274#discussion_r57088465 --- Diff: engine/src/main/java/com/datatorrent/stram/StreamingAppMasterService.java --- @@ -950,7 +977,11 @@ private void execute() throws YarnExc

[GitHub] incubator-apex-core pull request: APEXCORE-393 #resolve Adding Dag...

2016-03-22 Thread tweise
Github user tweise commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/274#discussion_r57087518 --- Diff: engine/src/main/java/com/datatorrent/stram/StreamingAppMasterService.java --- @@ -781,18 +794,19 @@ private void execute() throws YarnEx

[GitHub] incubator-apex-core pull request: APEXCORE-393 #resolve Adding Dag...

2016-03-19 Thread tweise
Github user tweise commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/274#discussion_r56537836 --- Diff: api/src/main/java/com/datatorrent/api/Context.java --- @@ -475,6 +475,21 @@ * Only supports string codecs that have a construct

[GitHub] incubator-apex-core pull request: APEXCORE-393 #resolve Adding Dag...

2016-03-19 Thread tweise
Github user tweise commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/274#discussion_r56538000 --- Diff: api/src/main/java/com/datatorrent/api/Context.java --- @@ -475,6 +475,21 @@ * Only supports string codecs that have a construct

[GitHub] incubator-apex-core pull request: APEXCORE-393 #resolve Adding Dag...

2016-03-19 Thread tweise
Github user tweise commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/274#discussion_r56538171 --- Diff: api/src/main/java/com/datatorrent/api/Context.java --- @@ -475,6 +475,21 @@ * Only supports string codecs that have a construct

[GitHub] incubator-apex-core pull request: APEXCORE-393 #resolve Adding Dag...

2016-03-19 Thread ishark
GitHub user ishark opened a pull request: https://github.com/apache/incubator-apex-core/pull/274 APEXCORE-393 #resolve Adding Dag context attributes with increased de… …fault value for blacklisting of failed nodes Added resetting of failure count for nodes after blacklis

[GitHub] incubator-apex-core pull request: APEXCORE-393 #resolve Adding Dag...

2016-03-18 Thread ishark
Github user ishark commented on the pull request: https://github.com/apache/incubator-apex-core/pull/274#issuecomment-198587733 Addressed review comments. @tweise please review. Have tested following things: 1. Checked that properties set for Blacklist removal time and