[GitHub] [incubator-apisix] membphis commented on a change in pull request #758: doc: added a new speech link and dropped `node-status` api doc.

2019-10-29 Thread GitBox
membphis commented on a change in pull request #758: doc: added a new speech link and dropped `node-status` api doc. URL: https://github.com/apache/incubator-apisix/pull/758#discussion_r340450814 ## File path: README_CN.md ## @@ -177,9 +177,10 @@ Dashboard 默认允许任何 IP 访问。你可以

[GitHub] [incubator-apisix-dashboard] moonming merged pull request #51: change the style of html license.

2019-10-29 Thread GitBox
moonming merged pull request #51: change the style of html license. URL: https://github.com/apache/incubator-apisix-dashboard/pull/51 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-apisix] membphis commented on a change in pull request #758: doc: added a new speech link and dropped `node-status` api doc.

2019-10-29 Thread GitBox
membphis commented on a change in pull request #758: doc: added a new speech link and dropped `node-status` api doc. URL: https://github.com/apache/incubator-apisix/pull/758#discussion_r340448902 ## File path: README_CN.md ## @@ -177,9 +177,10 @@ Dashboard 默认允许任何 IP 访问。你可以

[GitHub] [incubator-apisix] moonming commented on a change in pull request #758: doc: added a new speech link and dropped `node-status` api doc.

2019-10-29 Thread GitBox
moonming commented on a change in pull request #758: doc: added a new speech link and dropped `node-status` api doc. URL: https://github.com/apache/incubator-apisix/pull/758#discussion_r340447159 ## File path: doc/admin-api-cn.md ## @@ -3,7 +3,6 @@ === * [Route](#route

[GitHub] [incubator-apisix] toruneko opened a new issue #760: bug: wildcard certificates cannot match multi-level subdomains.

2019-10-29 Thread GitBox
toruneko opened a new issue #760: bug: wildcard certificates cannot match multi-level subdomains. URL: https://github.com/apache/incubator-apisix/issues/760 ### Issue description *.test.com certificate cannot match a.b.test.com domain, because the wildcard only covers one level of sub

[GitHub] [incubator-apisix] moonming commented on a change in pull request #758: doc: added a new speech link and dropped `node-status` api doc.

2019-10-29 Thread GitBox
moonming commented on a change in pull request #758: doc: added a new speech link and dropped `node-status` api doc. URL: https://github.com/apache/incubator-apisix/pull/758#discussion_r340447631 ## File path: README_CN.md ## @@ -177,9 +177,10 @@ Dashboard 默认允许任何 IP 访问。你可以

[GitHub] [incubator-apisix-dashboard] moonming opened a new pull request #51: change the style of html license.

2019-10-29 Thread GitBox
moonming opened a new pull request #51: change the style of html license. URL: https://github.com/apache/incubator-apisix-dashboard/pull/51 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-apisix] moonming edited a comment on issue #743: license: add ASF header.

2019-10-29 Thread GitBox
moonming edited a comment on issue #743: license: add ASF header. URL: https://github.com/apache/incubator-apisix/pull/743#issuecomment-547719058 > > index.html > > So this file is using an incorrect ASF header? > https://github.com/iresty/apisix_dashboard_built/blob/fde8c24f53665

[GitHub] [incubator-apisix] membphis opened a new issue #759: doc: typo

2019-10-29 Thread GitBox
membphis opened a new issue #759: doc: typo URL: https://github.com/apache/incubator-apisix/issues/759 ![image](https://user-images.githubusercontent.com/6814606/67833580-fe44f200-fb1f-11e9-9faf-5df509627de7.png) This is

[GitHub] [incubator-apisix] membphis opened a new pull request #758: doc: added a new speech link and dropped `node-status` api doc.

2019-10-29 Thread GitBox
membphis opened a new pull request #758: doc: added a new speech link and dropped `node-status` api doc. URL: https://github.com/apache/incubator-apisix/pull/758 This is an automated message from the Apache Git Service. To r

Re: [GitHub] [incubator-apisix] membphis commented on issue #679: bug: apisix/dashboard don't support array type for the schema in plugins

2019-10-29 Thread Zhiyuan Ju
Good catch, I will add that button. GitBox 于 2019年10月30日周三 13:05写道: > membphis commented on issue #679: bug: apisix/dashboard don't support > array type for the schema in plugins > URL: > https://github.com/apache/incubator-apisix/issues/679#issuecomment-547740306 > > >> It will be like this

[GitHub] [incubator-apisix] membphis commented on issue #679: bug: apisix/dashboard don't support array type for the schema in plugins

2019-10-29 Thread GitBox
membphis commented on issue #679: bug: apisix/dashboard don't support array type for the schema in plugins URL: https://github.com/apache/incubator-apisix/issues/679#issuecomment-547740306 > It will be like this. > How to add new ones? We need an 'add' button. -

[GitHub] [incubator-apisix] juzhiyuan commented on issue #679: bug: apisix/dashboard don't support array type for the schema in plugins

2019-10-29 Thread GitBox
juzhiyuan commented on issue #679: bug: apisix/dashboard don't support array type for the schema in plugins URL: https://github.com/apache/incubator-apisix/issues/679#issuecomment-547739110 It will be like this. ![image](https://user-images.githubusercontent.com/2106987/67830251-e4

[GitHub] [incubator-apisix-website] juzhiyuan commented on issue #9: update repo settings

2019-10-29 Thread GitBox
juzhiyuan commented on issue #9: update repo settings URL: https://github.com/apache/incubator-apisix-website/issues/9#issuecomment-547729863 Ticket created here https://issues.apache.org/jira/browse/INFRA-19356 , I will close this issues once the settings have been updated. -

[GitHub] [incubator-apisix-website] moonming commented on issue #9: update repo settings

2019-10-29 Thread GitBox
moonming commented on issue #9: update repo settings URL: https://github.com/apache/incubator-apisix-website/issues/9#issuecomment-547727284 my permissions are the same as you, so if you want to do this, you need to create a ticket for the infra team. -

[GitHub] [incubator-apisix] membphis commented on issue #732: feature: supported `redirect` plugin.

2019-10-29 Thread GitBox
membphis commented on issue #732: feature: supported `redirect` plugin. URL: https://github.com/apache/incubator-apisix/pull/732#issuecomment-547726770 Rebased this branch and added new comments, please take a look. This is an

[GitHub] [incubator-apisix] membphis commented on a change in pull request #732: feature: supported `redirect` plugin.

2019-10-29 Thread GitBox
membphis commented on a change in pull request #732: feature: supported `redirect` plugin. URL: https://github.com/apache/incubator-apisix/pull/732#discussion_r340420182 ## File path: lua/apisix/plugins/redirect.lua ## @@ -0,0 +1,121 @@ +local core = require("apisix.core")

[GitHub] [incubator-apisix-website] juzhiyuan opened a new issue #9: update repo settings

2019-10-29 Thread GitBox
juzhiyuan opened a new issue #9: update repo settings URL: https://github.com/apache/incubator-apisix-website/issues/9 @moonming Please help set `asf-site` branch under-protected, and remove `dev` branch. This is an automated

[GitHub] [incubator-apisix-website] moonming closed issue #8: wrong link in README.md

2019-10-29 Thread GitBox
moonming closed issue #8: wrong link in README.md URL: https://github.com/apache/incubator-apisix-website/issues/8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [incubator-apisix-website] moonming commented on issue #8: wrong link in README.md

2019-10-29 Thread GitBox
moonming commented on issue #8: wrong link in README.md URL: https://github.com/apache/incubator-apisix-website/issues/8#issuecomment-547722599 ok This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-apisix-website] juzhiyuan edited a comment on issue #8: wrong link in README.md

2019-10-29 Thread GitBox
juzhiyuan edited a comment on issue #8: wrong link in README.md URL: https://github.com/apache/incubator-apisix-website/issues/8#issuecomment-547721186 @membphis Please see `dev` or `asf-site` branch. @moonming I think we may set master branch as Dev branch to reduce confusion. --

[GitHub] [incubator-apisix-website] juzhiyuan edited a comment on issue #8: wrong link in README.md

2019-10-29 Thread GitBox
juzhiyuan edited a comment on issue #8: wrong link in README.md URL: https://github.com/apache/incubator-apisix-website/issues/8#issuecomment-547721186 Please see `dev` or `asf-site` branch. @moonming I think we may set master branch as Dev branch to reduce confusion.

[GitHub] [incubator-apisix-website] juzhiyuan commented on issue #8: wrong link in README.md

2019-10-29 Thread GitBox
juzhiyuan commented on issue #8: wrong link in README.md URL: https://github.com/apache/incubator-apisix-website/issues/8#issuecomment-547721186 Please see `dev` or `asf-site` branch. @moonming I think we may set master branch as Dev branch to reduce confustion. --

[GitHub] [incubator-apisix-website] membphis opened a new issue #8: wrong link in README.md

2019-10-29 Thread GitBox
membphis opened a new issue #8: wrong link in README.md URL: https://github.com/apache/incubator-apisix-website/issues/8 ![image](https://user-images.githubusercontent.com/6814606/67826009-1c055d80-fb06-11e9-9ada-8e383ed6d6b9.png) ---

Re: [Task] deploy Apache APISIX's website

2019-10-29 Thread Zhiyuan Ju
Hi, Our website[1] just updated, please check. [1] https://apisix.incubator.apache.org/ Best Regards! @ Zhiyuan Ju Ming Wen 于2019年10月30日周三 上午9:40写道: > hi, Justin, > Thank you for your reminder. > I removed the APISIX logo from github.com/iresty, > and I will use

[GitHub] [incubator-apisix-website] juzhiyuan commented on issue #7: wrong ico, we need to use the logo of Apache APISIX

2019-10-29 Thread GitBox
juzhiyuan commented on issue #7: wrong ico, we need to use the logo of Apache APISIX URL: https://github.com/apache/incubator-apisix-website/issues/7#issuecomment-547719801 fixed This is an automated message from the Apache

[GitHub] [incubator-apisix-website] juzhiyuan closed issue #7: wrong ico, we need to use the logo of Apache APISIX

2019-10-29 Thread GitBox
juzhiyuan closed issue #7: wrong ico, we need to use the logo of Apache APISIX URL: https://github.com/apache/incubator-apisix-website/issues/7 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-apisix-website] juzhiyuan closed issue #6: bug: wrong link

2019-10-29 Thread GitBox
juzhiyuan closed issue #6: bug: wrong link URL: https://github.com/apache/incubator-apisix-website/issues/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-apisix] moonming commented on issue #707: doc: fix 404 link when link to install-dependencies

2019-10-29 Thread GitBox
moonming commented on issue #707: doc: fix 404 link when link to install-dependencies URL: https://github.com/apache/incubator-apisix/pull/707#issuecomment-547717029 fixed by https://github.com/apache/incubator-apisix/pull/754 ---

[GitHub] [incubator-apisix-website] juzhiyuan commented on issue #6: bug: wrong link

2019-10-29 Thread GitBox
juzhiyuan commented on issue #6: bug: wrong link URL: https://github.com/apache/incubator-apisix-website/issues/6#issuecomment-547716975 fixed This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-apisix] moonming closed pull request #707: doc: fix 404 link when link to install-dependencies

2019-10-29 Thread GitBox
moonming closed pull request #707: doc: fix 404 link when link to install-dependencies URL: https://github.com/apache/incubator-apisix/pull/707 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-apisix] moonming closed issue #744: todo: will merge this PR manually after `apisix` -> `apache apisix`

2019-10-29 Thread GitBox
moonming closed issue #744: todo: will merge this PR manually after `apisix` -> `apache apisix` URL: https://github.com/apache/incubator-apisix/issues/744 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-apisix] moonming closed issue #753: apisix和openresty对比几大优势。欢迎补充!

2019-10-29 Thread GitBox
moonming closed issue #753: apisix和openresty对比几大优势。欢迎补充! URL: https://github.com/apache/incubator-apisix/issues/753 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-apisix] moonming merged pull request #754: doc: change all ` iresty/apisix` link in documents into `apache/incubator-apisix`

2019-10-29 Thread GitBox
moonming merged pull request #754: doc: change all ` iresty/apisix` link in documents into `apache/incubator-apisix` URL: https://github.com/apache/incubator-apisix/pull/754 This is an automated message from the Apache Git S

[GitHub] [incubator-apisix] moonming merged pull request #755: Doc update

2019-10-29 Thread GitBox
moonming merged pull request #755: Doc update URL: https://github.com/apache/incubator-apisix/pull/755 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [incubator-apisix] moonming merged pull request #752: bugfix: fix issue #750

2019-10-29 Thread GitBox
moonming merged pull request #752: bugfix: fix issue #750 URL: https://github.com/apache/incubator-apisix/pull/752 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [incubator-apisix] moonming closed issue #750: bug: plugin's method definition is invalid

2019-10-29 Thread GitBox
moonming closed issue #750: bug: plugin's method definition is invalid URL: https://github.com/apache/incubator-apisix/issues/750 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-apisix] moonming merged pull request #740: Update README.md - Add AWS deployment tutorial link

2019-10-29 Thread GitBox
moonming merged pull request #740: Update README.md - Add AWS deployment tutorial link URL: https://github.com/apache/incubator-apisix/pull/740 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-apisix] moonming merged pull request #742: Added Authing into Idp(CN)

2019-10-29 Thread GitBox
moonming merged pull request #742: Added Authing into Idp(CN) URL: https://github.com/apache/incubator-apisix/pull/742 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-apisix] moonming merged pull request #715: bugfix:zipkin plugin not set tracing data to request header.

2019-10-29 Thread GitBox
moonming merged pull request #715: bugfix:zipkin plugin not set tracing data to request header. URL: https://github.com/apache/incubator-apisix/pull/715 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-apisix-website] juzhiyuan merged pull request #5: Update README.md

2019-10-29 Thread GitBox
juzhiyuan merged pull request #5: Update README.md URL: https://github.com/apache/incubator-apisix-website/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [incubator-apisix] moonming merged pull request #704: doc: Update jwt-auth.md

2019-10-29 Thread GitBox
moonming merged pull request #704: doc: Update jwt-auth.md URL: https://github.com/apache/incubator-apisix/pull/704 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #739: doc: redirect-cn.md

2019-10-29 Thread GitBox
juzhiyuan commented on a change in pull request #739: doc: redirect-cn.md URL: https://github.com/apache/incubator-apisix/pull/739#discussion_r340406196 ## File path: doc/plugins/redirect-cn.md ## @@ -0,0 +1,96 @@ +[English](plugins/redirect.md) Review comment: Suffic

[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #739: doc: redirect-cn.md

2019-10-29 Thread GitBox
juzhiyuan commented on a change in pull request #739: doc: redirect-cn.md URL: https://github.com/apache/incubator-apisix/pull/739#discussion_r340405696 ## File path: doc/plugins/redirect-cn.md ## @@ -0,0 +1,96 @@ +[English](plugins/redirect.md) Review comment: Sorry

[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #739: doc: redirect-cn.md

2019-10-29 Thread GitBox
juzhiyuan commented on a change in pull request #739: doc: redirect-cn.md URL: https://github.com/apache/incubator-apisix/pull/739#discussion_r340405454 ## File path: doc/plugins/redirect-cn.md ## @@ -0,0 +1,96 @@ +[English](plugins/redirect.md) Review comment: It's c

[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #739: doc: redirect-cn.md

2019-10-29 Thread GitBox
juzhiyuan commented on a change in pull request #739: doc: redirect-cn.md URL: https://github.com/apache/incubator-apisix/pull/739#discussion_r340405454 ## File path: doc/plugins/redirect-cn.md ## @@ -0,0 +1,96 @@ +[English](plugins/redirect.md) Review comment: The li

Re: [Suggestion] move the GitHub notifications to Project notifications mail list

2019-10-29 Thread JinChao Shuai
good job. hui li 于2019年10月30日周三 上午1:35写道: > good job! > > 发自我的 iPhone > > > 在 2019年10月30日,上午12:13,YuanSheng Wang 写道: > > > > nice job! > > > >> On Tue, Oct 29, 2019 at 9:08 PM Zhiyuan Ju > wrote: > >> > >> Good Job ! > >> > >> Best Regards! > >> @ Zhiyuan Ju > >> >

[GitHub] [incubator-apisix] moonming commented on a change in pull request #757: add restart apisix server command

2019-10-29 Thread GitBox
moonming commented on a change in pull request #757: add restart apisix server command URL: https://github.com/apache/incubator-apisix/pull/757#discussion_r340405133 ## File path: bin/apisix ## @@ -450,6 +450,7 @@ init: initialize the local nginx.conf init_etcd: in

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #37: UI improvement: When the upstream load balancing algorithm is chash, the choice of key can be made into a drop-down list.

2019-10-29 Thread GitBox
juzhiyuan commented on issue #37: UI improvement: When the upstream load balancing algorithm is chash, the choice of key can be made into a drop-down list. URL: https://github.com/apache/incubator-apisix-dashboard/issues/37#issuecomment-547707912 @lilien1010 Not implemented yet, welcome

[GitHub] [incubator-apisix] membphis commented on a change in pull request #755: Doc update

2019-10-29 Thread GitBox
membphis commented on a change in pull request #755: Doc update URL: https://github.com/apache/incubator-apisix/pull/755#discussion_r340402297 ## File path: doc/dev-manual-cn.md ## @@ -98,4 +98,6 @@ Makefile rules: 1. 先安装 perl 的包管理器 cpanminus 2. 然后通过 cpanm 来安装 test-gninx:

[GitHub] [incubator-apisix] wziww commented on a change in pull request #755: Doc update

2019-10-29 Thread GitBox
wziww commented on a change in pull request #755: Doc update URL: https://github.com/apache/incubator-apisix/pull/755#discussion_r340399289 ## File path: doc/dev-manual-cn.md ## @@ -98,4 +98,5 @@ Makefile rules: 1. 先安装 perl 的包管理器 cpanminus 2. 然后通过 cpanm 来安装 test-gninx:`su

[GitHub] [incubator-apisix-dashboard] lilien1010 commented on issue #37: UI improvement: When the upstream load balancing algorithm is chash, the choice of key can be made into a drop-down list.

2019-10-29 Thread GitBox
lilien1010 commented on issue #37: UI improvement: When the upstream load balancing algorithm is chash, the choice of key can be made into a drop-down list. URL: https://github.com/apache/incubator-apisix-dashboard/issues/37#issuecomment-547702086 @juzhiyuan https://github.com/apache

Re: [Task] deploy Apache APISIX's website

2019-10-29 Thread Ming Wen
hi, Justin, Thank you for your reminder. I removed the APISIX logo from github.com/iresty, and I will use `http://apisix.incubator.apache.org/` instead of ` https://www.iresty.com` when I get the committer permission. `https://www.iresty.com` is the homepage before APISIX donate to Apache. Thanks,

[GitHub] [incubator-apisix-dashboard] lilien1010 commented on issue #37: UI improvement: When the upstream load balancing algorithm is chash, the choice of key can be made into a drop-down list.

2019-10-29 Thread GitBox
lilien1010 commented on issue #37: UI improvement: When the upstream load balancing algorithm is chash, the choice of key can be made into a drop-down list. URL: https://github.com/apache/incubator-apisix-dashboard/issues/37#issuecomment-547700534 @juzhiyuan how is the work about this

Re: [Task] deploy Apache APISIX's website

2019-10-29 Thread Zhiyuan Ju
Hi, Thank you for your reminder, the current website's contents are generated before the transfer of this repo, and Ming has requested some changes yesterday. Also, I have one confusion: I can push changes to the repo yesterday afternoon directly by SSH authentication, but couldn't do that at yes

Re: [Task] deploy Apache APISIX's website

2019-10-29 Thread Justin Mclean
Hi, I can see that the website prominatly links to GitHub. You really only want to direct developers to GitHub, users should not be directed to unreleased code. I can see that the Apache Github states "Cloud-Native Microservices API Gateway https://www.iresty.com”. Can someone explain the relat

[GitHub] [incubator-apisix] Miss-you commented on a change in pull request #739: doc: redirect-cn.md

2019-10-29 Thread GitBox
Miss-you commented on a change in pull request #739: doc: redirect-cn.md URL: https://github.com/apache/incubator-apisix/pull/739#discussion_r340240178 ## File path: doc/plugins/redirect-cn.md ## @@ -0,0 +1,96 @@ +[English](plugins/redirect.md) Review comment: https:

Re: [Suggestion] move the GitHub notifications to Project notifications mail list

2019-10-29 Thread hui li
good job! 发自我的 iPhone > 在 2019年10月30日,上午12:13,YuanSheng Wang 写道: > > nice job! > >> On Tue, Oct 29, 2019 at 9:08 PM Zhiyuan Ju wrote: >> >> Good Job ! >> >> Best Regards! >> @ Zhiyuan Ju >> >> >> Ming Wen 于2019年10月29日周二 下午8:31写道: >> >>> I created one ticket[

[GitHub] [incubator-apisix-website] membphis commented on issue #6: bug: wrong link

2019-10-29 Thread GitBox
membphis commented on issue #6: bug: wrong link URL: https://github.com/apache/incubator-apisix-website/issues/6#issuecomment-547517315 ![image](https://user-images.githubusercontent.com/6814606/67788861-02382c00-faae-11e9-8690-cba7df123196.png) ditto --

[GitHub] [incubator-apisix-website] membphis opened a new issue #7: wrong ico, we need to use the logo of Apache APISIX

2019-10-29 Thread GitBox
membphis opened a new issue #7: wrong ico, we need to use the logo of Apache APISIX URL: https://github.com/apache/incubator-apisix-website/issues/7 ![image](https://user-images.githubusercontent.com/6814606/67788072-986b5280-faac-11e9-9a23-ae50760e95cf.png) --

Re: [Task] deploy Apache APISIX's website

2019-10-29 Thread YuanSheng Wang
reported one bug at github [1] [1] https://github.com/apache/incubator-apisix-website/issues/6 On Wed, Oct 30, 2019 at 12:03 AM Zhiyuan Ju wrote: > Hi Ming, > > I found that I lost the correct permission for those repositories just n

[GitHub] [incubator-apisix-website] membphis opened a new issue #6: bug: wrong link

2019-10-29 Thread GitBox
membphis opened a new issue #6: bug: wrong link URL: https://github.com/apache/incubator-apisix-website/issues/6 change to new apache link. ![image](https://user-images.githubusercontent.com/6814606/67786809-75d83a00-faaa-11e9-8ee5-129447b64681.png) -

Re: [Suggestion] move the GitHub notifications to Project notifications mail list

2019-10-29 Thread YuanSheng Wang
nice job! On Tue, Oct 29, 2019 at 9:08 PM Zhiyuan Ju wrote: > Good Job ! > > Best Regards! > @ Zhiyuan Ju > > > Ming Wen 于2019年10月29日周二 下午8:31写道: > > > I created one ticket[1] for infra team. > > > > [1] https://issues.apache.org/jira/browse/INFRA-19355 > > > > Than

[GitHub] [incubator-apisix] membphis commented on a change in pull request #755: Doc update

2019-10-29 Thread GitBox
membphis commented on a change in pull request #755: Doc update URL: https://github.com/apache/incubator-apisix/pull/755#discussion_r340174432 ## File path: doc/dev-manual-cn.md ## @@ -98,4 +98,5 @@ Makefile rules: 1. 先安装 perl 的包管理器 cpanminus 2. 然后通过 cpanm 来安装 test-gninx:

Re: [Task] deploy Apache APISIX's website

2019-10-29 Thread Zhiyuan Ju
Hi Ming, I found that I lost the correct permission for those repositories just now :( and a PR is created here[1]. If we can't have push access, the *asf-site* branch has to be updated only by Travis CI. [1] https://github.com/apache/incubator-apisix-website/pull/5

[GitHub] [incubator-apisix-website] juzhiyuan opened a new pull request #5: Update README.md

2019-10-29 Thread GitBox
juzhiyuan opened a new pull request #5: Update README.md URL: https://github.com/apache/incubator-apisix-website/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-apisix-docker] Tinywan opened a new pull request #29: Simplify the docker run documentation and run quickly with docker-compose

2019-10-29 Thread GitBox
Tinywan opened a new pull request #29: Simplify the docker run documentation and run quickly with docker-compose URL: https://github.com/apache/incubator-apisix-docker/pull/29 This is an automated message from the Apache Git

[GitHub] [incubator-apisix] idevz commented on issue #753: apisix和openresty对比几大优势。欢迎补充!

2019-10-29 Thread GitBox
idevz commented on issue #753: apisix和openresty对比几大优势。欢迎补充! URL: https://github.com/apache/incubator-apisix/issues/753#issuecomment-547419102 APISIX is not only implement dynamic configuration changes; I think The most import things which APISIX have done are: 1. Provider a high

Re: [Suggestion] move the GitHub notifications to Project notifications mail list

2019-10-29 Thread Zhiyuan Ju
Good Job ! Best Regards! @ Zhiyuan Ju Ming Wen 于2019年10月29日周二 下午8:31写道: > I created one ticket[1] for infra team. > > [1] https://issues.apache.org/jira/browse/INFRA-19355 > > Thanks, > Ming Wen, Apache APISIX > Twitter: _WenMing > > > Ming Wen 于2019年10月29日周二 上午11

Re: [Suggestion] move the GitHub notifications to Project notifications mail list

2019-10-29 Thread Ming Wen
I created one ticket[1] for infra team. [1] https://issues.apache.org/jira/browse/INFRA-19355 Thanks, Ming Wen, Apache APISIX Twitter: _WenMing Ming Wen 于2019年10月29日周二 上午11:11写道: > hello, PPMC, > We have received some mails in the dev mail list from GitHub. > We should move it to the notifica

Re: [Task] deploy Apache APISIX's website

2019-10-29 Thread Ming Wen
zhiyuan, good job! it looks good to me about the branch. It's better to change 'APISIX' to 'Apache APISIX' in `README.md` and description, if you have the write permission. Thanks, Ming Wen, Apache APISIX Twitter: _WenMing Zhiyuan Ju 于2019年10月29日周二 下午6:40写道: > It[1] works now :)

[GitHub] [incubator-apisix] YazaiHu opened a new pull request #757: add restart apisix server command

2019-10-29 Thread GitBox
YazaiHu opened a new pull request #757: add restart apisix server command URL: https://github.com/apache/incubator-apisix/pull/757 NOTE: Please read the Contributing.md guidelines before submitting your patch: https://github.com/iresty/apisix/blob/master/Contributing.md#how-to-add-a

[GitHub] [incubator-apisix] YazaiHu closed pull request #756: add restart apisix server command

2019-10-29 Thread GitBox
YazaiHu closed pull request #756: add restart apisix server command URL: https://github.com/apache/incubator-apisix/pull/756 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-apisix] wziww commented on a change in pull request #755: Doc update

2019-10-29 Thread GitBox
wziww commented on a change in pull request #755: Doc update URL: https://github.com/apache/incubator-apisix/pull/755#discussion_r340009105 ## File path: doc/dev-manual-cn.md ## @@ -99,3 +99,4 @@ Makefile rules: 2. 然后通过 cpanm 来安装 test-gninx:`sudo cpanm --notest Test::Nginx

[GitHub] [incubator-apisix] YazaiHu commented on a change in pull request #756: add restart apisix server command

2019-10-29 Thread GitBox
YazaiHu commented on a change in pull request #756: add restart apisix server command URL: https://github.com/apache/incubator-apisix/pull/756#discussion_r340008024 ## File path: bin/apisix ## @@ -450,6 +450,7 @@ init: initialize the local nginx.conf init_etcd: ini

[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #755: Doc update

2019-10-29 Thread GitBox
juzhiyuan commented on a change in pull request #755: Doc update URL: https://github.com/apache/incubator-apisix/pull/755#discussion_r340006968 ## File path: doc/dev-manual-cn.md ## @@ -99,3 +99,4 @@ Makefile rules: 2. 然后通过 cpanm 来安装 test-gninx:`sudo cpanm --notest Test::N

[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #755: Doc update

2019-10-29 Thread GitBox
juzhiyuan commented on a change in pull request #755: Doc update URL: https://github.com/apache/incubator-apisix/pull/755#discussion_r340006968 ## File path: doc/dev-manual-cn.md ## @@ -99,3 +99,4 @@ Makefile rules: 2. 然后通过 cpanm 来安装 test-gninx:`sudo cpanm --notest Test::N

[GitHub] [incubator-apisix] wziww commented on a change in pull request #755: Doc update

2019-10-29 Thread GitBox
wziww commented on a change in pull request #755: Doc update URL: https://github.com/apache/incubator-apisix/pull/755#discussion_r340006462 ## File path: doc/dev-manual-cn.md ## @@ -99,3 +99,4 @@ Makefile rules: 2. 然后通过 cpanm 来安装 test-gninx:`sudo cpanm --notest Test::Nginx

[GitHub] [incubator-apisix] wziww commented on a change in pull request #755: Doc update

2019-10-29 Thread GitBox
wziww commented on a change in pull request #755: Doc update URL: https://github.com/apache/incubator-apisix/pull/755#discussion_r340006282 ## File path: doc/dev-manual.md ## @@ -99,4 +99,5 @@ Makefile rules: 2. Then install `test-gninx` via `cpanm`::`sudo cpanm --notest T

[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #755: Doc update

2019-10-29 Thread GitBox
juzhiyuan commented on a change in pull request #755: Doc update URL: https://github.com/apache/incubator-apisix/pull/755#discussion_r340003619 ## File path: doc/dev-manual.md ## @@ -99,4 +99,5 @@ Makefile rules: 2. Then install `test-gninx` via `cpanm`::`sudo cpanm --note

[GitHub] [incubator-apisix] juzhiyuan commented on issue #755: Doc update

2019-10-29 Thread GitBox
juzhiyuan commented on issue #755: Doc update URL: https://github.com/apache/incubator-apisix/pull/755#issuecomment-547361159 Thanks for your contribution! This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #755: Doc update

2019-10-29 Thread GitBox
juzhiyuan commented on a change in pull request #755: Doc update URL: https://github.com/apache/incubator-apisix/pull/755#discussion_r340003132 ## File path: doc/dev-manual-cn.md ## @@ -99,3 +99,4 @@ Makefile rules: 2. 然后通过 cpanm 来安装 test-gninx:`sudo cpanm --notest Test::N

[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #756: add restart apisix server command

2019-10-29 Thread GitBox
juzhiyuan commented on a change in pull request #756: add restart apisix server command URL: https://github.com/apache/incubator-apisix/pull/756#discussion_r340002152 ## File path: bin/apisix ## @@ -450,6 +450,7 @@ init: initialize the local nginx.conf init_etcd: i

Re: [Task] deploy Apache APISIX's website

2019-10-29 Thread Zhiyuan Ju
It[1] works now :) Just to make sure, if we need to keep the current *master* branch? If not, I will set the master branch as Dev branch. [1] https://apisix.incubator.apache.org/ Best Regards! @ Zhiyuan Ju Zhiyuan Ju 于2019年

[GitHub] [incubator-apisix] YazaiHu opened a new pull request #756: add restart apisix server command

2019-10-29 Thread GitBox
YazaiHu opened a new pull request #756: add restart apisix server command URL: https://github.com/apache/incubator-apisix/pull/756 NOTE: Please read the Contributing.md guidelines before submitting your patch: https://github.com/iresty/apisix/blob/master/Contributing.md#how-to-add-a

Re: [DISCUSS] Call for volunteer of PPMCs for quarterly report

2019-10-29 Thread hui li
ok, I'll try. I can do this after 10 o'clock in the evening. Ming Wen 于2019年10月29日周二 下午3:02写道: > hui, do you want be the volunteer to completing the first quarterly report? > > Thanks, > Ming Wen, Apache APISIX > Twitter: _WenMing > > > hui li 于2019年10月29日周二 下午2:58写道: > > > understood. > > > >

[GitHub] [incubator-apisix] wziww opened a new pull request #755: Doc update

2019-10-29 Thread GitBox
wziww opened a new pull request #755: Doc update URL: https://github.com/apache/incubator-apisix/pull/755 ### Summary Add `TEST_NGINX_BINARY` environment variables description for dev-manual doc ### Full changelog ### Issues resolved ---

[GitHub] [incubator-apisix] lilien1010 opened a new pull request #754: doc: change all ` iresty/apisix` link in documents into `apache/incubator-apisix`

2019-10-29 Thread GitBox
lilien1010 opened a new pull request #754: doc: change all ` iresty/apisix` link in documents into `apache/incubator-apisix` URL: https://github.com/apache/incubator-apisix/pull/754 ### Summary change all ` iresty/apisix` link in documents into `apache/incubator-apisix` #

Re: [Task] deploy Apache APISIX's website

2019-10-29 Thread Zhiyuan Ju
I'm glad to do that today. Best Regards! @ Zhiyuan Ju Ming Wen 于2019年10月29日周二 下午6:12写道: > hello, PPMCs, > > The repo of APISIX website has moved to Apache [1], > so we need to deploy it to http://apisix.incubator.apache.org/. > > The web site deployment service is

[Task] deploy Apache APISIX's website

2019-10-29 Thread Ming Wen
hello, PPMCs, The repo of APISIX website has moved to Apache [1], so we need to deploy it to http://apisix.incubator.apache.org/. The web site deployment service is managed through the staging and publish feature of the .asf.yaml file in git repositories.[2] Does someone want to deploy the websi

Re: [DISCUSS] I want to change the concept "service" in Apisix to "router-set"

2019-10-29 Thread zhoujingk_49
So what about the “route” itself? Its also have upstream, plugins, etc. What’s a really service should be? It’s must provider some businesses or abilities rather than a group of route rules alright? | | idevz | | zhoujing_...@163.com | Idevz.org github.com/idevz On 10/29/2019 17:18,Zhiyuan

回复:[GitHub] [incubator-apisix] ygm521 commented on issue #753: apisix和openresty对比几大优势。欢迎补充!

2019-10-29 Thread zhoujingk_49
APISIX is not only implement dynamic configuration changes; I think The most import things which APISIX have done are: 1. Provider a high performance route to mange your business traffic. 2. Provider a flexible mechanism(plugins) to add your custom logic about your own business. 3. Based on the

Re: [DISCUSS] I want to change the concept "service" in Apisix to "router-set"

2019-10-29 Thread Zhiyuan Ju
According to the description of Service[1] here, I would prefer *keeping the current Name*. Because one service of APISIX here not only includes a group of routes but also has upstream, plugins, etc. [image: image.png] [1] https://github.com/apache/incubator-apisix/blob/master/doc/architecture-de

[GitHub] [incubator-apisix] ygm521 commented on issue #753: apisix和openresty对比几大优势。欢迎补充!

2019-10-29 Thread GitBox
ygm521 commented on issue #753: apisix和openresty对比几大优势。欢迎补充! URL: https://github.com/apache/incubator-apisix/issues/753#issuecomment-547313192 I am based on nginx to write related c language modules. As far as I know, 1, apisix is nothing more than using the etcd storage configuration t

Re: [DISCUSS] I want to change the concept "service" in Apisix to "router-set"

2019-10-29 Thread zhoujingk_49
I couldn’t concept your reason as “there is also `service` in Kong”, we’re ApiSix not Kong. We should not forgot that the “service” in APISix is just a truly “route set". We should face the truth. | | idevz | | zhoujing_...@163.com | Idevz.org github.com/idevz On 10/29/2019 16:32,YuanSheng

Re: [QUESTION] How to add label for an issue?

2019-10-29 Thread YuanSheng Wang
I really need this permission, how to apply for it? Does anyone know this? On Tue, Oct 29, 2019 at 4:31 PM zhoujingk_49 wrote: > You should check if you have the right permissions. > > > | | > idevz > | > | > zhoujing_...@163.com > | > > Idevz.org > > github.com/idevz > > > > On 10/29/2019 16:

Re: [DISCUSS] I want to change the concept "service" in Apisix to "router-set"

2019-10-29 Thread YuanSheng Wang
Hi: I thought about it, there is also `service` in Kong, and here we are almost the same. So I prefer to continue using `service`. On Tue, Oct 29, 2019 at 10:45 AM zhoujingk_49 wrote: > Hi folks! > > > As we know Apisix is one of an Cloud Native APIGateway, and one of the > most important abou

Re:[QUESTION] How to add label for an issue?

2019-10-29 Thread zhoujingk_49
You should check if you have the right permissions. | | idevz | | zhoujing_...@163.com | Idevz.org github.com/idevz On 10/29/2019 16:17,YuanSheng Wang wrote: Hi: After the project is handed over to apache, how to add label for an exist issue?

[GitHub] [incubator-apisix] idevz edited a comment on issue #753: apisix和openresty对比几大优势。欢迎补充!

2019-10-29 Thread GitBox
idevz edited a comment on issue #753: apisix和openresty对比几大优势。欢迎补充! URL: https://github.com/apache/incubator-apisix/issues/753#issuecomment-547309765 @ygm521 we'd better using English here, on account of we're in the apache-incubator now. For your question, apisix is a Cloud Native A

[GitHub] [incubator-apisix] idevz commented on issue #753: apisix和openresty对比几大优势。欢迎补充!

2019-10-29 Thread GitBox
idevz commented on issue #753: apisix和openresty对比几大优势。欢迎补充! URL: https://github.com/apache/incubator-apisix/issues/753#issuecomment-547309765 @ygm521 we'd better using English here, on account of we're in the apache-incubator now. For your question, apisix is a Cloud Native Api Gate

  1   2   >