Re: [VOTE] Release Apache APISIX (Incubating) 1.1-RC1

2020-02-15 Thread Justin Mclean
Hi, +1 (binding) I checked: - incubating in name - signatures and hashes are fine - disclaimer exits - license and notice are fine - no unexpected binary files - all files have ASF headers - didn’t try to compile from source Git tags are changeable, btw some releases, for variously reasons e.g.

Re: [VOTE] Release Apache APISIX Dashboard (Incubating) 1.0-RC2

2020-02-15 Thread Justin Mclean
Hi, +1 (binding) I checked: - incubating in name - signatures and hashes are fine - disclaimer exits - no unexpected binary files - all ASF files have ASF headers - can compile from source Thanks, Justin

Re: [VOTE] Release Apache APISIX (Incubating) 1.1-RC1

2020-02-15 Thread junxu chen
yes, files in tar file is good. I ran the `check version` tool and modified the version, but fail to push it to github.com. I have pushed it again. Thanks for reminding ! On Sun, Feb 16, 2020 at 10:28 AM agile6v wrote: > The lua/apisix/core/version.lua file in the master and 1.1 branch of > git

Re: [VOTE] Release Apache APISIX (Incubating) 1.1-RC1

2020-02-15 Thread Ming Wen
agreed. The tar file is not the same as git tag[1]. junxu, please take a look. [1] https://github.com/apache/incubator-apisix/tree/v1.1 Thanks, Ming Wen, Apache APISIX Twitter: _WenMing agile6v 于2020年2月16日周日 上午10:28写道: > The lua/apisix/core/version.lua file in the master and 1.1 branch of > g

Re: [VOTE] Release Apache APISIX (Incubating) 1.1-RC1

2020-02-15 Thread YuanSheng Wang
On Sun, Feb 16, 2020 at 10:28 AM agile6v wrote: > The lua/apisix/core/version.lua file in the master and 1.1 branch of > github doesn't seem to be modified. But it has been modified in tar file. > Please confirm that it is as expected. > it seems that the apache-apisix-1.1-rc1-incubating-src.tar

Re: [VOTE] Release Apache APISIX (Incubating) 1.1-RC1

2020-02-15 Thread YuanSheng Wang
+1 I checked these points and they are fine. - Download links are valid. - Checksums and PGP signatures are valid. - DISCLAIMER is included. - LICENSE and NOTICE files are good. - No binary file. - All files have license headers if necessary. - build and run apisix by source

Re: [VOTE] Release Apache APISIX (Incubating) 1.1-RC1

2020-02-15 Thread agile6v
The lua/apisix/core/version.lua file in the master and 1.1 branch of github doesn't seem to be modified. But it has been modified in tar file. Please confirm that it is as expected. Thanks, agile6v On 2020/02/15 13:47:32, junxu chen wrote: > Hello, Community, > > This is a call for the vot

Re: [VOTE] Release Apache APISIX Dashboard (Incubating) 1.0-RC2

2020-02-15 Thread agile6v
+1 I checked: - Download links are valid - incubating in name - DISCLAIMER file is included - Checksums and PGP signature are valid - LICENSE and NOTICE file are good - All files have valid License header if necessary - can compile from source Thanks, agile6v On 2020/02/15 03:10:41, Zhiyuan Ju

Re: [VOTE] Release Apache APISIX Dashboard (Incubating) 1.0-RC2

2020-02-15 Thread YuanSheng Wang
+1 I checked this list right now: [X] Download links are valid. [X] Checksums and PGP signature are valid. [X] DISCLAIMER file is included. [X] Both LICENSE and NOTICE files are good. [X] No binary file. [X] All files have valid License header if necessary. On Sat, Feb 15, 2020 at 11:11 AM Zhiy

[VOTE] Release Apache APISIX (Incubating) 1.1-RC1

2020-02-15 Thread junxu chen
Hello, Community, This is a call for the vote to release Apache APISIX (Incubating) version 1.1-RC1. Release notes: https://github.com/apache/incubator-apisix/blob/v1.1/CHANGELOG.md#110 The release candidates: https://dist.apache.org/repos/dist/dev/incubator/apisix/1.1-rc1/ Git tag for the

Re: [VOTE] Release Apache APISIX Dashboard (Incubating) 1.0-RC2

2020-02-15 Thread Li Ling(Lien)
+1 I checked: - Download links are valid - incubating in name - Checksums and PGP signature are valid - LICENSE and NOTICE file are good - All files have valid License header if necessary - can compile from source Thanks, Liling Ming Wen 于2020年2月15日周六 下午4:13写道: > > +1 > > I checked: > - Downloa

Re: [VOTE] Release Apache APISIX Dashboard (Incubating) 1.0-RC2

2020-02-15 Thread Ming Wen
+1 I checked: - Download links are valid - incubating in name - Checksums and PGP signature are valid - DISCLAIMER file is included - LICENSE and NOTICE file are good - No binary files - All files have valid License header if necessary - can compile from source Thanks, Ming Wen, Apache APISIX Twi