Re: Re: the error happend when use the healthcheck to get the status of upstrems.

2020-04-22 Thread 88786...@qq.com
@MembPhis, The timer delays adding targets, so it will get an error if use the get_target_status function to get the status of a node before the targets assigned. It's the best to use the get_target_status function by pcall, and use the default is_healthy status as result. 88786...@qq.com

On the abstraction of vars

2020-04-22 Thread 15717900
hi,      There are multiple routes, using the same vars, such as [["cookie_user", "==", "1"]], which take effect on both "/user" and "/pages" routes. If you abstract out vars and manage them separately, you don't need to modify their vars one by one, just one place.

Re: Shouldn't apisix provide a unified function to format the response body?

2020-04-22 Thread YuanSheng Wang
{error_msg: 'error message'} I think this style should be enough. The `code` is meaningless, I do not like it. The `code` is meaningless too. most of case: {ok = true} {ok = false, error_msg = ""} so we can drop `ok`, it is meaningless. On Thu, Apr 23, 2020 at 12:11 PM jie12310

Shouldn't apisix provide a unified function to format the response body?

2020-04-22 Thread jie123108
For different API business systems, the format of the returned json may be different, for example, in one system, the structure of the returned message is this: {ok: true|false, code: 'error code', data: {}} Or it could be: {status: 0, errmsg: 'error message', result: {} On

Re: Could we add CD for dashboard?

2020-04-22 Thread Zhiyuan Ju
Ok, I will get in touch with ZEIT more. Best Regards! @ Zhiyuan Ju Ming Wen 于2020年4月23日周四 上午11:06写道: > Hi,zhiyuan, > I think add a small banner in README is ok, > but add banner in every page is too much, which will modifies the source > code. > > Thanks, > Ming We

Re: Could we add CD for dashboard?

2020-04-22 Thread Ming Wen
Hi,zhiyuan, I think add a small banner in README is ok, but add banner in every page is too much, which will modifies the source code. Thanks, Ming Wen, Apache APISIX & Apache SkyWalking Twitter: _WenMing Zhiyuan Ju 于2020年4月20日周一 下午4:30写道: > Hi, > > I sent a mail to ZEIT support days ago and j

Re: [DISCUSS] bi-weekly online video meeting

2020-04-22 Thread hui li
We can upload the conference video to BILIBILI BILIBILI's upload speed is very fast, and it also respect the original creator YuanSheng Wang 于2020年4月21日周二 下午10:46写道: > Hi: > > Should we do video recording? > > Where will we upload these video content later? > > > On Tue, Apr 21, 2020 at 4:59 PM

Re: [DISCUSS] Apache APISIX version 1.3

2020-04-22 Thread hui li
More importantly, the current main users of apisix are based on the docker or kubernetes platform (of course, cloud native is also the future), so we should spend more time optimizing for the container platform, including kubernetes high availability deployment, helm configuration, Optimize docker

Re: APACHE APISIX access log format optimization

2020-04-22 Thread YuanSheng Wang
> It would be great if we can configure what optional parameter we need as well, instead of logging > everything. This method is more flexible, agrees +1. On Mon, Apr 20, 2020 at 6:54 PM Nirojan Selvanathan wrote: > +1, It's very useful to have such granular info. It would be great if we > can