[GitHub] [apisix-control-plane] gxthrj commented on a change in pull request #5: doc: add yaml design doc

2020-08-01 Thread GitBox
gxthrj commented on a change in pull request #5: URL: https://github.com/apache/apisix-control-plane/pull/5#discussion_r464040748 ## File path: doc/yaml_struct.md ## @@ -0,0 +1,223 @@ +## Currently, 4 types are defined, namely +1.Gateway +2.Traffic distribution rules +3.Define

Re: [DISCUSS] How about we disable the plugins `proxy-cache` and `proxy-mirror` by default?

2020-08-01 Thread Linsir Wu
+1, they will not be enabled by default if the user changes it by config.yaml or admin api agile6v 于2020年8月1日周六 下午8:01写道: > > Hi YuanSheng > > AFAIK, If these plugins are not configured through the admin api, they will > not be enabled by default. Also How is the 10% performance loss verified? >

Re: [DISCUSS] How about we disable the plugins `proxy-cache` and `proxy-mirror` by default?

2020-08-01 Thread YuanSheng Wang
I make a test right now, here is the result: https://github.com/apache/apisix/pull/1968#issue-461617117 On Sun, Aug 2, 2020 at 9:33 AM YuanSheng Wang wrote: > The Apache APISIX just disabled the plugin proxy-cache and proxy-mirror > in `conf/config.yaml` by default. > > And the user can enable

Re: [DISCUSS] How about we disable the plugins `proxy-cache` and `proxy-mirror` by default?

2020-08-01 Thread YuanSheng Wang
The Apache APISIX just disabled the plugin proxy-cache and proxy-mirror in `conf/config.yaml` by default. And the user can enable them by update the conf/config.yaml in an easy way. On Sun, Aug 2, 2020 at 8:57 AM YuanSheng Wang wrote: > Hi: > > If the user did not enable those plugin, we do no

Re: [VOTE] Release Apache APISIX 1.5-RC1

2020-08-01 Thread YuanSheng Wang
+1 binding * Download links are valid. * Checksums and PGP signatures are valid. * LICENSE and NOTICE files are good. * No binary file. * All files have license headers if necessary. * Run this package at my Ubuntu 20, and it works fine. - $ make init ./bin

Re: [DISCUSS] How about we disable the plugins `proxy-cache` and `proxy-mirror` by default?

2020-08-01 Thread YuanSheng Wang
Hi: If the user did not enable those plugin, we do not generate the conf/nginx.conf content required by these plugins in bin/apisix. I make a test if we can remove the related nginx.conf for plugin proxy-cache and proxy-mirror, the apisix will better performance. I think we can disable them in t

Re: [VOTE] Release Apache APISIX 1.5-RC1

2020-08-01 Thread Ming Wen
+1 binding I checked: - Download links are valid. - Checksums and PGP signatures are valid. - LICENSE and NOTICE files are good. - No binary file. - All files have license headers if necessary. - `make deps` & `./bin/apisix version` works well in macos. Thanks, Ming Wen, Apache APISIX & Apache Sky

Re: [DISCUSS] How about we disable the plugins `proxy-cache` and `proxy-mirror` by default?

2020-08-01 Thread agile6v
Hi YuanSheng AFAIK, If these plugins are not configured through the admin api, they will not be enabled by default. Also How is the 10% performance loss verified? Thanks. On 2020/08/01 05:53:01, YuanSheng Wang wrote: > Hi: > > if we disable plugin `proxy-cache` and `proxy-mirror` and remove