[GitHub] [apisix-control-plane] membphis commented on a change in pull request #14: feat: add mem object group & apisix model

2020-08-19 Thread GitBox
membphis commented on a change in pull request #14: URL: https://github.com/apache/apisix-control-plane/pull/14#discussion_r473583774 ## File path: pkg/dp/apisix/upstream.go ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

Re: [DISCUSS]Modify the manager-api DB from mysql to sqllite

2020-08-19 Thread YuanSheng Wang
On Thu, Aug 20, 2020 at 11:42 AM vincixu wrote: > > support search and paging, etcd cannot support such features. > back-end search and paging is unnecessary, we can implement it in the > front-end, because users will not have too many configurations. > > because users will not have too many co

Re: [DISCUSS]Modify the manager-api DB from mysql to sqllite

2020-08-19 Thread Ming Wen
etcd is used for the configuration of Apache APISIX. If the management data (such as search, tag, status, etc.) is mixed, it will affect the stability of the gateway. Thanks, Ming Wen, Apache APISIX & Apache SkyWalking Twitter: _WenMing vincixu 于2020年8月20日周四 上午11:42写道: > > support search and

Re: [DISCUSS]Modify the manager-api DB from mysql to sqllite

2020-08-19 Thread Ming Wen
sqlite is Public Domain[1], which is may be included within Apache products[2]. So it's better choose a DB which is Apache 2.0 license or a compatible license. [1] https://www.sqlite.org/copyright.html [2] https://www.apache.org/legal/resolved.html#handling-public-domain-licensed-works Thanks, Mi

Re: [DISCUSS]Modify the manager-api DB from mysql to sqllite

2020-08-19 Thread Sheng Wu
There are a lot of DB could be chosen, if you like. Many of them are Apache 2.0 or a compatible license. Sheng Wu 吴晟 Twitter, wusheng1108 vincixu 于2020年8月20日周四 上午11:42写道: > > support search and paging, etcd cannot support such features. > back-end search and paging is unnecessary, we can impl

Re: [DISCUSS]Modify the manager-api DB from mysql to sqllite

2020-08-19 Thread vincixu
> support search and paging, etcd cannot support such features. back-end search and paging is unnecessary, we can implement it in the front-end, because users will not have too many configurations. YuanSheng Wang 于2020年8月20日周四 上午11:29写道: > On Thu, Aug 20, 2020 at 10:57 AM vincixu wrote: > > >

Re: [DISCUSS]Modify the manager-api DB from mysql to sqllite

2020-08-19 Thread Sheng Wu
You can't depend on MySQL, because of the license. MySQL could be optional storage only. Sheng Wu 吴晟 Twitter, wusheng1108 YuanSheng Wang 于2020年8月20日周四 上午11:29写道: > On Thu, Aug 20, 2020 at 10:57 AM vincixu wrote: > > > I haven't followed APISIX Dashboard until I saw this email. > > In my opini

Re: [DISCUSS]Modify the manager-api DB from mysql to sqllite

2020-08-19 Thread YuanSheng Wang
On Thu, Aug 20, 2020 at 10:57 AM vincixu wrote: > I haven't followed APISIX Dashboard until I saw this email. > In my opinion, APISIX Dashboard should not rely on storage other than ETCD > or even ManagerAPI, which will increase the overall complexity. > `manager api` relies on relational databa

Re: [DISCUSS]Modify the manager-api DB from mysql to sqllite

2020-08-19 Thread vincixu
I haven't followed APISIX Dashboard until I saw this email. In my opinion, APISIX Dashboard should not rely on storage other than ETCD or even ManagerAPI, which will increase the overall complexity. This is really not a good idea. Dashboard should be kept simple and easy to deploy, not another huge

[GitHub] [apisix-control-plane] gxthrj opened a new pull request #14: feat: add mem object group & apisix model

2020-08-19 Thread GitBox
gxthrj opened a new pull request #14: URL: https://github.com/apache/apisix-control-plane/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [DISCUSS]Modify the manager-api DB from mysql to sqllite

2020-08-19 Thread Justin Mclean
HI, Last I looked mysql was also GPL which is not compatible with the Apache License. I assume this is an optional dependancy? Thanks, Justin

[DISCUSS]Modify the manager-api DB from mysql to sqllite

2020-08-19 Thread wei jin
hi, community Many users have reported that the current apisix-dashboard is a little troublesome during deployment. One of the problems is that we rely on mysql. Users need to maintain additional database instances. I propose to modify mysql to an embedded database such as sqllite. considerations f

Re: Re: [DISCUSS]Need a way to support running APISIX in github actions

2020-08-19 Thread dabue
+1, it's friendly to use. 88786...@qq.com From: Ming Wen Date: 2020-08-19 21:22 To: dev Subject: Re: [DISCUSS]Need a way to support running APISIX in github actions looks good to me Thanks, Ming Wen, Apache APISIX & Apache SkyWalking Twitter: _WenMing vincixu 于2020年8月19日周三 下午7:56写道: >

Re: [DISCUSS]Need a way to support running APISIX in github actions

2020-08-19 Thread Ming Wen
looks good to me Thanks, Ming Wen, Apache APISIX & Apache SkyWalking Twitter: _WenMing vincixu 于2020年8月19日周三 下午7:56写道: > We change to: > ``` > etcd: > host: ${ENV_ETCD_URLS} > ``` > " ENV_ETCD_URLS " is a comma separated string. > When users configured it, we can split and set it to host. >

Re: [DISCUSS]Need a way to support running APISIX in github actions

2020-08-19 Thread vincixu
We change to: ``` etcd: host: ${ENV_ETCD_URLS} ``` " ENV_ETCD_URLS " is a comma separated string. When users configured it, we can split and set it to host. If not existing the environment var, just keep original hosts in config.yaml. Ming Wen 于2020年8月19日周三 下午6:20写道: > what about etcd cluster

Re: [DISCUSS]Need a way to support running APISIX in github actions

2020-08-19 Thread Ming Wen
what about etcd cluster? vincixu 于 2020年8月19日周三 下午12:39写道: > Great, I like this way! > > YuanSheng Wang 于2020年8月18日周二 下午8:29写道: > > > > 1. APISIX supports specifying etcd host through environment variables > > > > Support to use ENV variable as `etcd` address, I think it is a simple > way. >