Re: [DISCUSS] Support include other Nginx config

2020-11-01 Thread Zexuan Luo
We need to require user to provide their snippets, just like their other configurations. Ming Wen 于2020年10月31日周六 下午3:24写道: > I have a concern: if these nginx snippets conflict with Apache APISIX > plugins, how can we find it out or debug? > others looks good to me. > > Thanks, > Ming Wen, Apache

Re: [DISCUSS] Support include other Nginx config

2020-11-01 Thread YuanSheng Wang
On Sat, Oct 31, 2020 at 3:24 PM Ming Wen wrote: > I have a concern: if these nginx snippets conflict with Apache APISIX > plugins, how can we find it out or debug? > others looks good to me. > I also have this concern. It will make troubleshooting more difficult. > > Thanks, > Ming Wen, Apach

Re: [DISCUSS] Support include other Nginx config

2020-10-31 Thread Ming Wen
I have a concern: if these nginx snippets conflict with Apache APISIX plugins, how can we find it out or debug? others looks good to me. Thanks, Ming Wen, Apache APISIX & Apache SkyWalking Twitter: _WenMing Zhang Chao 于2020年10月31日周六 下午2:16写道: > Nice idea, it can meet more complicated users sc

Re: [DISCUSS] Support include other Nginx config

2020-10-30 Thread Zhang Chao
Nice idea, it can meet more complicated users scenarios. On October 31, 2020 at 12:39:34 PM, Zexuan Luo (spacewan...@apache.org) wrote: GH issue: https://github.com/apache/apisix/issues/2565 I think we can introduce several conf snippets in the config.yaml file. Just like ingress-nginx's snippe

[DISCUSS] Support include other Nginx config

2020-10-30 Thread Zexuan Luo
GH issue: https://github.com/apache/apisix/issues/2565 I think we can introduce several conf snippets in the config.yaml file. Just like ingress-nginx's snippet feature: https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations/#configuration-snippet The kind of snippe