Re: [DISCUSS] add golangci-linter to Go projects

+1 On Sun, Aug 30, 2020 at 1:45 PM Ming Wen wrote: > great job! > > Zhiyuan Ju 于 2020年8月30日周日 下午1:39写道： > > > Looks good to me > > > > Best Regards! > > @ Zhiyuan Ju > > > > > > bzp2010 于2020年8月30日周日 下午12:27写道： > > > > > I think it will help improve code quality. >

Re: [DISCUSS] add golangci-linter to Go projects

great job! Zhiyuan Ju 于 2020年8月30日周日 下午1:39写道： > Looks good to me > > Best Regards! > @ Zhiyuan Ju > > > bzp2010 于2020年8月30日周日 下午12:27写道： > > > I think it will help improve code quality. > > > > jinwei 于2020年8月30日周日 上午11:10写道： > > > > > Great，I think itis useful >

Re: [DISCUSS] add golangci-linter to Go projects

Looks good to me Best Regards! @ Zhiyuan Ju bzp2010 于2020年8月30日周日 下午12:27写道： > I think it will help improve code quality. > > jinwei 于2020年8月30日周日 上午11:10写道： > > > Great，I think itis useful > > > > > > > > > > On 08/30/2020 10:53, Zexuan Luo wrote: > > Currently w

Re: [DISCUSS] add golangci-linter to Go projects

I think it will help improve code quality. jinwei 于2020年8月30日周日 上午11:10写道： > Great，I think itis useful > > > > > On 08/30/2020 10:53, Zexuan Luo wrote: > Currently we have two projects written in Go: > https://github.com/apache/apisix-control-plane > https://github.com/apache/apisix-dashboard >

Re: [DISCUSS] add golangci-linter to Go projects

Great，I think itis useful On 08/30/2020 10:53, Zexuan Luo wrote: Currently we have two projects written in Go: https://github.com/apache/apisix-control-plane https://github.com/apache/apisix-dashboard These two projects don't have linter to check the code quality. It is common practice to use

[DISCUSS] add golangci-linter to Go projects

Currently we have two projects written in Go: https://github.com/apache/apisix-control-plane https://github.com/apache/apisix-dashboard These two projects don't have linter to check the code quality. It is common practice to use golangci-linter to lint the Go code. I have run it under these proje