Re: cvs commit: apr-util/misc apr_rmm.c

2002-03-15 Thread Doug MacEachern
just noticed another problem, rv never gets set here: apr_status_t rv; ... if ((this = apr_rmm_malloc(rmm, reqsize)) 0) { return rv; } thinking it should be APR_EINVAL, but the return type of apr_rmm_realloc is apr_rmm_off_t. then again, both apr_rmm_{calloc,malloc}

RE: cvs commit: apr-util/misc apr_rmm.c

2002-03-15 Thread MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1)
Oops.. Sorry. I wanted to rewrite the piece of code before submitting it. Here's a quickfix, incorporating Aaron's and Doug's comments. However, at a later part, I was thinking of having the realloc logic something like : if (requested_size current_size) { split the current block free the

Re: cvs commit: apr/include apr_compat.h

2002-03-15 Thread Cliff Woolley
On 15 Mar 2002 [EMAIL PROTECTED] wrote: ianh02/03/14 16:33:59 Modified:include apr_compat.h Log: add a #define for apr_exploded_time_t in here as well this will stop people's current work from breaking +/** @deprecated @see apr_time_exp_t */ +#define

Re: cvs commit: apr/include apr_compat.h

2002-03-15 Thread Justin Erenkrantz
On Fri, Mar 15, 2002 at 12:33:59AM -, [EMAIL PROTECTED] wrote: ianh02/03/14 16:33:59 Modified:include apr_compat.h Log: add a #define for apr_exploded_time_t in here as well this will stop people's current work from breaking -1. Please revert. apr_compat.h is

Re: [PATCH] mod_mem_cache using apr_atomic_dec()

2002-03-15 Thread Greg Ames
Bill Stoddard wrote: (moved from [EMAIL PROTECTED] to [EMAIL PROTECTED]) I hesitate to commit the because I am not sure if apr_atomic_dec will be portable and usable on enough OS/hardware combinations. as we discussed offline, you're right. The return value for apr_atomic_dec isn't