Re: [PATCH] fixes for apr_vformatter and apr_snprintf

2002-07-10 Thread Nuutti Kotivuori
Jim Jagielski wrote: > Nuutti Kotivuori wrote: >> >> * apr_snprintf behaved incorrectly when the output was >> * truncated. It returned the length that was passed in, but that is >> * including the null-terminator. >> > > From the man page for snprintf(): > if the return value is greater than

Re: cvs commit: apr renames_pending

2002-07-10 Thread Cliff Woolley
On Wed, 10 Jul 2002, Thom May wrote: > Hrm, think I prefer apr_(u|g)id_ Likewise. --Cliff

Re: cvs commit: apr renames_pending

2002-07-10 Thread Thom May
* William A. Rowe, Jr. ([EMAIL PROTECTED]) wrote : > At 01:39 PM 7/10/2002, you wrote: > >wrowe 2002/07/10 11:39:54 > > > > Modified:.renames_pending > > Log: > >Reorder alpha, and clarify apr_group_id_/apr_user_id_ [still some > >discussion on those.] > > > > +apr_grou

Re: [PATCH] fixes for apr_vformatter and apr_snprintf

2002-07-10 Thread Jim Jagielski
Nuutti Kotivuori wrote: > > * apr_snprintf behaved incorrectly when the output was truncated. It > returned the length that was passed in, but that is including the > null-terminator. > >From the man page for snprintf(): if the return value is greater than or equal to the size argument, the

[PATCH] fixes for apr_vformatter and apr_snprintf

2002-07-10 Thread Nuutti Kotivuori
I went through apr_snprintf trying to find whether the value returne was including or not including a null-terminator. On the way, I stumbled upon some nastyness. This is what you get when you don't just write a test program and see how it behaves. There are a few fixes I made, outlined below. *

RE: Apache 2 instruction count profile (head as of ~15:00 EDT July 10)

2002-07-10 Thread Ryan Bloom
This is about the apr_poll implementation. The new implementation seems to have an impact on performance. Ryan -- Ryan Bloom [EMAIL PROTECTED] 645 Howard St. [EMAIL PROTECTED] San Francisco, CA > -Original Message-

Re: cvs commit: apr renames_pending

2002-07-10 Thread William A. Rowe, Jr.
At 01:39 PM 7/10/2002, you wrote: wrowe 2002/07/10 11:39:54 Modified:.renames_pending Log: Reorder alpha, and clarify apr_group_id_/apr_user_id_ [still some discussion on those.] +apr_group_id_get from apr_get_groupid +apr_group_id_compare

[PATCH] example BUSEC patch for benchmarking only

2002-07-10 Thread William A. Rowe, Jr.
At 01:14 PM 7/9/2002, you wrote: Bill Stoddard wrote: Where and when was the post that described this proposal? I'd like to take a look. Is there a patch? There's no patch that I know of, but here's the thread with wrowe's original proposal for the binary microseconds design: http://marc.theaimsg

apr_connect()[/network_io/win32/sockets.c] patch

2002-07-10 Thread INOUE Seiichiro
Hi, I have a fix for non-blocking apr_connect() on Windows. Though sock->timeout is millisecond, it is treated as microsecond. Please see the attached patch. The credit goes to TANAKA Koichi <[EMAIL PROTECTED]>, who found and fixed it. Thanks. - INOUE Seiichiro <[EMAIL PROTECTED]> http://www.

[PATCH] apr_poll, take 2

2002-07-10 Thread rbb
FirstBill found a bug in my poll implementation today. It was working for sockets most of the time, but it always failed with pipes. It also wasn't correctly returning APR_TIMEUP. This new patch should fix the problems. Same as last time, apply the patch, then in srclib/apr, untar the tarball.

RE: New Test Suite

2002-07-10 Thread Ryan Bloom
I'll look at this tonight. Ryan -- Ryan Bloom [EMAIL PROTECTED] 645 Howard St. [EMAIL PROTECTED] San Francisco, CA > -Original Message- > From: Sander Striker [mailto:[EMAIL PROTECTED] > Sent: Tuesday, July 09, 20

RE: New apr_poll() implementation

2002-07-10 Thread Ryan Bloom
> From: Sander Striker [mailto:[EMAIL PROTECTED] > > > From: Ryan Bloom [mailto:[EMAIL PROTECTED] > > Sent: 09 July 2002 15:46 > > >> From: Ryan Bloom [mailto:[EMAIL PROTECTED] > >>> From: Justin Erenkrantz [mailto:[EMAIL PROTECTED] > >>> On Sat, Jul 06, 2002 at 12:11:59PM -0700, Ryan Bloom wrote