Re: apr_mmap_t

2002-11-20 Thread rbb
BTW, I want to be 100% clear. We don't use incomplete types for binary compatibility. The only reason that we use incomplete types is for portability reasons. In APR 2.0, I fully expect most of the incomplete types to shrink, and for a good portion of APR to use complete types. Ryan On Wed, 2

Re: apr_mmap_t

2002-11-20 Thread rbb
On Wed, 20 Nov 2002, Cliff Woolley wrote: > Does anybody have any idea at all why apr_mmap_t is not an incomplete > type? I have to change its size and that's a bit of a PITA because, while > it SHOULD not, it COULD break binary compat for stupid modules who use > sizeof(apr_mmap_t) for somethi

apr_mmap_t

2002-11-20 Thread Cliff Woolley
Does anybody have any idea at all why apr_mmap_t is not an incomplete type? I have to change its size and that's a bit of a PITA because, while it SHOULD not, it COULD break binary compat for stupid modules who use sizeof(apr_mmap_t) for something. --Cliff

Re: cvs commit: apr/network_io/os2 sendrecv_udp.c

2002-11-20 Thread Thom May
* [EMAIL PROTECTED] ([EMAIL PROTECTED]) wrote : > bjh 2002/11/20 13:56:21 > > Modified:network_io/os2 sendrecv_udp.c > Log: > Rename apr_recvfrom -> apr_socket_recvfrom > Missed in last round of renames. > Nice catch, thanks! :-) -Thom

Re: Renames (Gee, it's a mail from thom, it must be renames)

2002-11-20 Thread Jim Jagielski
At 4:59 PM -0800 11/19/02, Thom May wrote: >So what is the consensus with the renames? The patch is available from >http://cvs.apache.org/~thommay/full-rename-diff and seems good - it builds >and passes tests on (at least) BeOS and OS X. >Also, httpd and svn don't need any changes to still work - t

Re: apr_proc_create

2002-11-20 Thread Ich Selbst
> IIRC... if you do this, you lose stdin/out/err, which are set up > by the cmd engine. I believe this is the reason that flag wasn't > used. No. If the app uses stdin and normal out, then the flag will have no effect (according to the docs). And if you want to start an app invisible then you don

Re: apr_get_groupname()

2002-11-20 Thread Thom May
* Sebastian Bergmann ([EMAIL PROTECTED]) wrote : > apr_get_groupname() is declared twice in apr/user/win32/groupinfo.c: Thanks, fixed. -Thom

Re: apr_proc_create

2002-11-20 Thread William A. Rowe, Jr.
IIRC... if you do this, you lose stdin/out/err, which are set up by the cmd engine. I believe this is the reason that flag wasn't used. Bill At 01:38 PM 11/19/2002, Ich Selbst wrote: >Hi, > >in file apr/threadproc/win32/proc.c on line 337 >I think there should be added another line: > >dwCreati

RE: [PATCH] Fix Win32 build

2002-11-20 Thread Bill Stoddard
Committed. Thanks for the patch. Bill > > The following patch fugbixes two typos: > > Index: network_io/win32/sendrecv.c > === > RCS file: /home/cvspublic/apr/network_io/win32/sendrecv.c,v > retrieving revision 1.60 > diff -u -u

Who is using APR????

2002-11-20 Thread rbb
Hi everybody. I noticed that there are a lot of bugs being reported right now, which is awesome! But, I don't recognize a lot of the names of people reporting the bugs. The only reason I care, is that I really want to flush out the list of projects that are using APR at http://apr.apache.org/pr

RE: apr_sockaddr_info_get: Posible bug

2002-11-20 Thread Dagfinn Aarvaag
Hi, I am using an old version of APR and was not able to set the flag APR_IPV4_ADDR_OK Should upgrade !! but is waiting for your next (pre)release. I tried different possbilities calling apr_sockaddr_info_get as shown below // Given address is an externally valid IP address else {

apr_get_groupname()

2002-11-20 Thread Sebastian Bergmann
apr_get_groupname() is declared twice in apr/user/win32/groupinfo.c: /* Deprecated */ APR_DECLARE(apr_status_t) apr_get_groupname(char **groupname, apr_gid_t groupid, apr_pool_t *p) { return apr_gid_name_get(groupname, groupid, p); }

[PATCH] Fix Win32 build

2002-11-20 Thread Sebastian Bergmann
The following patch fugbixes two typos: Index: network_io/win32/sendrecv.c === RCS file: /home/cvspublic/apr/network_io/win32/sendrecv.c,v retrieving revision 1.60 diff -u -u -r1.60 sendrecv.c --- network_io/win32/sendrecv.c 20 Nov

Re: apr_sockaddr_info_get: Posible bug

2002-11-20 Thread Jeff Trawick
"Dagfinn Aarvaag" <[EMAIL PROTECTED]> writes: > Hi, > > I see the same problem on Solaris 8 and Win32. > apr_sockaddr_info_get return apr code APR_SUCCESS, > but returned IP address and hostname in the struct apr_sockaddr_t are > "0.0.0.0" and "". not the same problem... he got APR_EINVAL becau

RE: apr_sockaddr_info_get: Posible bug

2002-11-20 Thread Dagfinn Aarvaag
Hi, I see the same problem on Solaris 8 and Win32. apr_sockaddr_info_get return apr code APR_SUCCESS, but returned IP address and hostname in the struct apr_sockaddr_t are "0.0.0.0" and "". ..but my apr version is old. Regards Dagfinn -Original Message- From: [EMAIL PROTECTED] [mailto:

Re: apr_sockaddr_info_get: Posible bug

2002-11-20 Thread Jeff Trawick
Damir Dezeljin <[EMAIL PROTECTED]> writes: > Hi. > > > In other words, apr_sockaddr_info_get() failed (which probably means > > your resolver failed). What is the return code from > > apr_sockaddr_info_get()? > > > > What version of Linux is this, by the way? > On WinXP / MS VS.NET > Return code

Re: [PATCH] Re: apr_proc_mutex is broken

2002-11-20 Thread rbb
On Tue, 19 Nov 2002, Aaron Bannert wrote: > On Tuesday, November 19, 2002, at 09:49 PM, <[EMAIL PROTECTED]> wrote: > > By allocating the mutex in the pool they have already stated that the > > pool > > should control the mutex's scope. That is the meaning of allocating a > > varibale inside a p

Re: apr_sockaddr_info_get: Posible bug

2002-11-20 Thread Damir Dezeljin
Hi. > In other words, apr_sockaddr_info_get() failed (which probably means > your resolver failed). What is the return code from > apr_sockaddr_info_get()? > > What version of Linux is this, by the way? On WinXP / MS VS.NET Return code: 22 APR err: Invalid argument On Linux Debian 3.0 (Woody) Re

Re: apr_sockaddr_info_get: Posible bug

2002-11-20 Thread Jeff Trawick
Damir Dezeljin <[EMAIL PROTECTED]> writes: > It look like that this function is used to initialize and construct > apr_sockaddr_t variable. So I use: > --- > apr_sockaddr_t *sa=NULL; > ... > apr_sockaddr_info_get( > &sa, > APR_ANYADDR, > APR_INET, > 2, > APR_IPV4_ADDR

Re: Renames (Gee, it's a mail from thom, it must be renames)

2002-11-20 Thread Jeff Trawick
Thom May <[EMAIL PROTECTED]> writes: > So what is the consensus with the renames? The patch is available from > http://cvs.apache.org/~thommay/full-rename-diff and seems good - it builds > and passes tests on (at least) BeOS and OS X. > Also, httpd and svn don't need any changes to still work - th

apr_sockaddr_info_get: Posible bug

2002-11-20 Thread Damir Dezeljin
Hi. I'm trying to bind a socket to a certain port on all my local interfaces, so I check which function can I use to construct apr_sockaddr_t address to which bind my socket. >From the manual I found: --- apr_status_t apr_sockaddr_info_get ( apr_sockaddr_t **sa, const char *

Re: [PATCH] Re: apr_proc_mutex is broken

2002-11-20 Thread Aaron Bannert
On Tuesday, November 19, 2002, at 09:49 PM, <[EMAIL PROTECTED]> wrote: By allocating the mutex in the pool they have already stated that the pool should control the mutex's scope. That is the meaning of allocating a varibale inside a pool. This is why pools are passed to ALL functions. BTW, yo

Re: [PATCH] Re: apr_proc_mutex is broken

2002-11-20 Thread rbb
On Tue, 19 Nov 2002, Aaron Bannert wrote: > On Tuesday, November 19, 2002, at 12:34 PM, <[EMAIL PROTECTED]> wrote: > > > > > On 19 Nov 2002, Philip Martin wrote: > > > >> <[EMAIL PROTECTED]> writes: > >> > >>> If you don't want the child process to destroy the mutex, then you > >>> should > >>>

Re: Renames (Gee, it's a mail from thom, it must be renames)

2002-11-20 Thread Aaron Bannert
+1, it built fine for me on Darwin. -aaron On Tuesday, November 19, 2002, at 04:59 PM, Thom May wrote: So what is the consensus with the renames? The patch is available from http://cvs.apache.org/~thommay/full-rename-diff and seems good - it builds and passes tests on (at least) BeOS and OS X. Al

Re: [PATCH] Re: apr_proc_mutex is broken

2002-11-20 Thread Aaron Bannert
On Tuesday, November 19, 2002, at 01:51 PM, <[EMAIL PROTECTED]> wrote: apr_proc_mutex_child_init() Depending on mutex type, the cleanup should be killed or not. In general, file-based mutex will be killed, but semaphores will not. I don't understand this, why does the app trea

Re: [PATCH] Re: apr_proc_mutex is broken

2002-11-20 Thread Aaron Bannert
On Tuesday, November 19, 2002, at 12:34 PM, <[EMAIL PROTECTED]> wrote: On 19 Nov 2002, Philip Martin wrote: <[EMAIL PROTECTED]> writes: If you don't want the child process to destroy the mutex, then you should kill that cleanup in the child process. That is why we have the apr_pool_cleanup_kill

Re: [PATCH] Re: apr_proc_mutex is broken

2002-11-20 Thread Aaron Bannert
On Tuesday, November 19, 2002, at 12:02 PM, Philip Martin wrote: I think the current pool cleanup handler is a mistake. The handler should cleanup only those resources local to the process, leaving the proc_mutex in a working state. This is how it is now, only that when we use fork(), all the cle

Re: [PATCH] Re: apr_proc_mutex is broken

2002-11-20 Thread Aaron Bannert
On Tuesday, November 19, 2002, at 10:46 AM, <[EMAIL PROTECTED]> wrote: If you don't want the child process to destroy the mutex, then you should kill that cleanup in the child process. That is why we have the apr_pool_cleanup_kill API. Naw, we just shouldn't automatically destroy locks in a cle

Re: [PATCH] Re: apr_proc_mutex is broken

2002-11-20 Thread Aaron Bannert
So are you saying that we should not ever automatically destroy locks in cleanups? -aaron On Tuesday, November 19, 2002, at 08:59 AM, <[EMAIL PROTECTED]> wrote: This would be a bad design change IMNSHO. The library has no business deciding when a mutex is destroyed, that is the role of the applic

Renames (Gee, it's a mail from thom, it must be renames)

2002-11-20 Thread Thom May
So what is the consensus with the renames? The patch is available from http://cvs.apache.org/~thommay/full-rename-diff and seems good - it builds and passes tests on (at least) BeOS and OS X. Also, httpd and svn don't need any changes to still work - the functions are all wrapped by the old names.

Re: [PATCH] Re: apr_proc_mutex is broken

2002-11-20 Thread rbb
On Tue, 19 Nov 2002 [EMAIL PROTECTED] wrote: > On Tue, 19 Nov 2002, Justin Erenkrantz wrote: > > > --On Tuesday, November 19, 2002 8:39 AM -0500 Jeff Trawick > > <[EMAIL PROTECTED]> wrote: > > > > > I contemplated relatively-complex exit sequences so that children > > > didn't exit until the test

Re: [PATCH] Re: apr_proc_mutex is broken

2002-11-20 Thread rbb
On Tue, 19 Nov 2002, Justin Erenkrantz wrote: > --On Tuesday, November 19, 2002 8:39 AM -0500 Jeff Trawick > <[EMAIL PROTECTED]> wrote: > > > I contemplated relatively-complex exit sequences so that children > > didn't exit until the test was over, but life is short, and these > > test programs

Re: [PATCH] Re: apr_proc_mutex is broken

2002-11-20 Thread Justin Erenkrantz
--On Tuesday, November 19, 2002 8:39 AM -0500 Jeff Trawick <[EMAIL PROTECTED]> wrote: I contemplated relatively-complex exit sequences so that children didn't exit until the test was over, but life is short, and these test programs should be short too. Okay, here are the problems that we identifi