Re: stable branches created for apr and apr-util, time to get api tweaks in prior to 1.0

2003-09-03 Thread Cliff Woolley
On Wed, 3 Sep 2003, Jeff Trawick wrote: > I'm through grepping for "deprecated" for the time being, so somebody > else feel free to jump in ;) Thanks Jeff!!

[PATCH] apr_reslist - allow Soft/Hard Max to Equal the Minimum

2003-09-03 Thread Paul Querna
apr_reslist_create() does not allow the Soft Max or the Hard Max to equal the Minimum number of resources. Shouldn't it be possible to create an apr_reslist where the Minimum is also the Soft Max? I have done minimal testing with this patch with my mod_authn_dbi (the only apache module that i k

[PATCH] apr_reslist - allow Soft/Hard Max to Equal the Minimum

2003-09-03 Thread Paul Querna
apr_reslist_create() does not allow the Soft Max or the Hard Max to equal the Minimum number of resources. Shouldn't it be possible to create an apr_reslist where the Minimum is also the Soft Max? I have done minimal testing with this patch with my mod_authn_dbi (the only apache module that i k

Re: [PATCH] apr_reslist - allow Soft/Hard Max to Equal the Minimum

2003-09-03 Thread Aaron Bannert
This looks good to me. Nice catch. +1 (I'm swamped with other things right now, but if someone hasn't committed this by today or tomorrow I can do it.) -aaron On Wednesday, September 3, 2003, at 11:45 AM, Paul Querna wrote: apr_reslist_create() does not allow the Soft Max or the Hard Max to equal

Re: stable branches created for apr and apr-util, time to get api tweaks in prior to 1.0

2003-09-03 Thread Jeff Trawick
Many brain-dead changes to remove deprecated functions, fields, arguments, symbols, and other have been made to the apr tree. apr-util HEAD and httpd-2.0 HEAD have been modified to deal with this and are alleged to actually compile. I'm through grepping for "deprecated" for the time being, so

Re: remaining issues prior to 1.0?

2003-09-03 Thread Joe Orton
On Tue, Sep 02, 2003 at 10:04:52PM -0700, Stas Bekman wrote: > Justin Erenkrantz wrote: > >--On Tuesday, September 2, 2003 2:30 PM -0700 Stas Bekman > ><[EMAIL PROTECTED]> wrote: > > > >>Other outstanding issues that IMHO can/should be fixed in 1.0. > >> > >>Configure issues: > >> > >>1) dealing w

Re: [patch] sendfile on win32 slow (bug #20382)

2003-09-03 Thread Bill Stoddard
> To prevent an DoS, perhaps WaitForSingleObject() could be called in a loop with, check the value of GetOverLappedResult() for a 'sane' value (this can be the old MAX_SEGMENT_SIZE), and if the amount of bytes transmitted since the last call to GetOverlappedResult() is smaller than MAX_SEGMENT_SIZ

Re: remaining issues prior to 1.0?

2003-09-03 Thread Stas Bekman
Justin Erenkrantz wrote: --On Tuesday, September 2, 2003 2:30 PM -0700 Stas Bekman <[EMAIL PROTECTED]> wrote: Other outstanding issues that IMHO can/should be fixed in 1.0. Configure issues: 1) dealing with APR_HAS_LARGE_FILES on linux http://marc.theaimsgroup.com/?l=apr-dev&m=105277560530754&w=2

Re: remaining issues prior to 1.0?

2003-09-03 Thread Stas Bekman
Cliff Woolley wrote: On Tue, 2 Sep 2003, Stas Bekman wrote: 3) there is no apr_file_tell http://marc.theaimsgroup.com/?t=10074811064&r=1&w=2 You don't need one. Just as there is an lseek() but no ltell(), you can do: apr_off_t offs = 0; apr_file_seek(fd, APR_CUR, &offs); at which poi

Re: remaining issues prior to 1.0?

2003-09-03 Thread Cliff Woolley
On Tue, 2 Sep 2003, Stas Bekman wrote: > 3) there is no apr_file_tell > http://marc.theaimsgroup.com/?t=10074811064&r=1&w=2 You don't need one. Just as there is an lseek() but no ltell(), you can do: apr_off_t offs = 0; apr_file_seek(fd, APR_CUR, &offs); at which point offs will ha

Re: remaining issues prior to 1.0?

2003-09-03 Thread Justin Erenkrantz
--On Tuesday, September 2, 2003 2:30 PM -0700 Stas Bekman <[EMAIL PROTECTED]> wrote: Other outstanding issues that IMHO can/should be fixed in 1.0. Configure issues: 1) dealing with APR_HAS_LARGE_FILES on linux http://marc.theaimsgroup.com/?l=apr-dev&m=105277560530754&w=2 Currently it's just disa

Re: [PATCH] check NULL in apr_bucket_alloc

2003-09-03 Thread Cliff Woolley
On Tue, 2 Sep 2003, Jean-Jacques Clar wrote: > In the case that a server is running out of memory (yeah, I know it > never happens), apr_allocator_alloc() is returning NULL, but it is never > checked for in apr_bucket_alloc(). Does the bucket alloc function should > pass that NULL back to the func