Re: Opinions on refactored read_with_timeout, please?

2006-03-25 Thread Ryan Bloom
I'm with Garrett, this looks reasonable enough, but I just don't know enough about win32 to say that on a visual inspection. I think this needs to bake for a while. Ryan On 3/25/06, William A. Rowe, Jr. <[EMAIL PROTECTED]> wrote: > Garrett Rooney wrote: > > > >>I've refactored the read_with_time

Re: svn commit: r388863 - /apr/apr/branches/0.9.x/test/Makefile.in

2006-03-25 Thread Garrett Rooney
On 3/25/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Author: wrowe > Date: Sat Mar 25 16:29:46 2006 > New Revision: 388863 > > URL: http://svn.apache.org/viewcvs?rev=388863&view=rev > Log: > > testshmconsumer and testshmproducer are STARTED by testshm, they should > not be launched in 'ma

Re: Opinions on refactored read_with_timeout, please?

2006-03-25 Thread William A. Rowe, Jr.
Garrett Rooney wrote: I've refactored the read_with_timeout() code to account for observations about both WAIT_ABANDONED and the short race between ReadFile, WaitFor... CancelIo and GetCompletion. Considering the lack of regression tests to catch problems with this code, I think it's rather p

Re: svn commit: r388605 - /apr/apr-util/trunk/xml/expat/buildconf.sh

2006-03-25 Thread William A. Rowe, Jr.
Justin Erenkrantz wrote: On Fri, Mar 24, 2006 at 07:15:52PM -, [EMAIL PROTECTED] wrote: Author: wrowe Date: Fri Mar 24 11:15:49 2006 New Revision: 388605 URL: http://svn.apache.org/viewcvs?rev=388605&view=rev Log: Apply the same cache pre-clean/post-clean m4's version collision avoidance

Re: svn commit: r388595 - /apr/apr-util/trunk/buildconf

2006-03-25 Thread William A. Rowe, Jr.
Justin Erenkrantz wrote: Version guard; avoid seeing an installed 1.2.x or earlier apr when configuring apr-util. Thanks for breaking the build on Solaris. Your welcome, glad I could help. # Default place to look for apr source. Can be overridden with # --with-apr=[directory] + apr_s

Re: svn commit: r388595 - /apr/apr-util/trunk/buildconf

2006-03-25 Thread William A. Rowe, Jr.
Paul Querna wrote: Using 'which' isn't portable: http://mail-archives.apache.org/mod_mbox/httpd-dev/200502.mbox/[EMAIL PROTECTED] And to further add frustration, path=`which pathcmd` doesn't reflect a non-0 result when the which command fails on Solaris /bin/sh. /me ponders moving my primary

Re: svn commit: r388595 - /apr/apr-util/trunk/buildconf

2006-03-25 Thread Paul Querna
[EMAIL PROTECTED] wrote: Author: wrowe Date: Fri Mar 24 10:21:34 2006 New Revision: 388595 URL: http://svn.apache.org/viewcvs?rev=388595&view=rev Log: Version guard; avoid seeing an installed 1.2.x or earlier apr when configuring apr-util. Modified: apr/apr-util/trunk/buildconf Modifi

Re: svn commit: r388605 - /apr/apr-util/trunk/xml/expat/buildconf.sh

2006-03-25 Thread Justin Erenkrantz
On Fri, Mar 24, 2006 at 07:15:52PM -, [EMAIL PROTECTED] wrote: > Author: wrowe > Date: Fri Mar 24 11:15:49 2006 > New Revision: 388605 > > URL: http://svn.apache.org/viewcvs?rev=388605&view=rev > Log: > > Apply the same cache pre-clean/post-clean m4's version collision avoidance > that we

Re: svn commit: r388595 - /apr/apr-util/trunk/buildconf

2006-03-25 Thread Justin Erenkrantz
On Fri, Mar 24, 2006 at 06:21:38PM -, [EMAIL PROTECTED] wrote: > Author: wrowe > Date: Fri Mar 24 10:21:34 2006 > New Revision: 388595 > > URL: http://svn.apache.org/viewcvs?rev=388595&view=rev > Log: > > Version guard; avoid seeing an installed 1.2.x or earlier apr > when configuring apr